JTable repeats one row

Question

I created a JTable and inserted the column header and data into the table.

• data is vector of vectors
• column_header is vector of string

This is the code:

Vector<Diagnosis_data> Arraylist_object = new Vector<Diagnosis_data>();
Vector<Vector<Object>> data = new Vector<Vector<Object>>();

Diagnosis_data d1 = new Diagnosis_data("92992","1",1422-09-09,1422-09-18,E11.9,"Type 2 diabetes mellitus without complications");
Diagnosis_data d2 = new Diagnosis_data("8199111","2",1415-09-09,1415-09-18,E11.622,"Type 2 diabetes mellitus with other skin ulcer");

Arraylist_object.add(d1);
Arraylist_object.add(d2);

int f = 0;
while(f < Arraylist_object.size())
{
    Vector<Object> vector = new Vector<Object>();

    for(; f < Arraylist_object.size() ; f++)
    {
        vector.add(Arraylist_object.get(f).patient_ID);
        vector.add(Arraylist_object.get(f).Ad_ID);
        vector.add(Arraylist_object.get(f).Ad_start);
        vector.add(Arraylist_object.get(f).Ad_End);
        vector.add(Arraylist_object.get(f).Diagnosis_code);
        vector.add(Arraylist_object.get(f).Diagnosis_Des);

        data.add(vector);
    }
}


DefaultTableModel tableModel = new DefaultTableModel(data,column_header);

JTable table_2 = new JTable(tableModel);
JScrollPane scrollPane = new JScrollPane(table_2);

scrollPane.setBounds(1, 1, 1050, 500);
panel_1.add(scrollPane);

The result is:

Answer 1

The code you posted is working given the correct data - the problem must be the data. Use a debugger to check it or, just for testing, print out the content of data.

Probably the same Vector is being added to data multiple times or the content of each Vector is same (maybe the Patient object is using static fields?)

Note: data I used to test your code - a new Vector must be created for each row:

Vector<Vector<?>> data = new Vector<>();
Vector<String> column_header = new Vector<>();

column_header.addAll(Arrays.asList("A", "B", "C"));

Vector<String> row;
row = new Vector<>();
row.addAll(Arrays.asList("11", "12", "13"));
data.add(row);
row = new Vector<>();
row.addAll(Arrays.asList("21", "22", "23"));
data.add(row);
row = new Vector<>();
row.addAll(Arrays.asList("31", "32", "33"));
data.add(row);

EDIT: After the generating data code has been added, it is clear that the problem is, as I suspected above: "the same Vector is being added".

Look at this part:

Vector<Object> vector = new Vector<Object>();

for(; f < Arraylist_object.size() ; f++)
{
    vector.add(...);

    data.add(vector);
}

The vector is created only once OUTSIDE the loop, but being added multiple time inside the loop.

Solution: create the vector INSIDE the loop

And there is no need for the additional while, actually the convention is to declare the variable in the for loop (and use i as counter):

for(int i = 0; i < Arraylist_object.size() ; i++)
{
    Vector<Object> vector = new Vector<Object>();

    vector.add(Arraylist_object.get(i).patient_ID);
    ...

    data.add(vector);
}

or use foreach:

for (Diagnosis_data diagnosis : Arraylist_object)
{
    Vector<Object> vector = ...
    vector.add(diagnosis.patient_ID);
    vector.add(diagnosis.Ad_ID);
    ...
}

 

Advice: spend some time learning to use a debugger, it will not be wasted if you want to do serious programming.

Advice2: as commented by Andrew Thompson, use LayoutManager's instead of using constant coordinates to layout your components. Tutorial: Laying Out Components Within a Container