file.delete() returning true but the file is still there

Question

I'm following this code to delete an apk file before downloading another one and then installing it

String destination = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS) + "/";
String fileName = getResources().getString(R.string.apkname) + ".apk";
destination += fileName;
final Uri uri = Uri.parse("file://" + destination);

File file = new File(destination);
if (file.canRead()) {
    if (file.delete()) {
        Toast.makeText(getApplicationContext(), "File deleted", Toast.LENGTH_LONG).show();
    }
}

I'm finding the file, so I get to file.delete() and then I get the toast message, but when I check in downloads, the file is still there and I end up with multiple files with the same name, I can still use them with no issues, so it's like file.delete() did absolutely nothing.

For the record, I have WRITE_EXTERNAL_STORAGE permission in the manifest AND I request it in runtime too since I'm using sdkversion 25.

What's wrong?

Thanks in advance

Did you tried restarting your Android device and verified if the duplicate files exists? — Divya Mamgai, May 08 '17 at 06:21
@NitinPatel If there was a need of `try` and `catch` construct. it would have halted the app execution but the OP is not saying that it is happening. — Divya Mamgai, May 08 '17 at 06:27
@NitinPatel I achieve that with file.canRead() because file.exists() wasn't working for me — Santiago Cuartas Arango, May 08 '17 at 06:27
@SantiagoCuartasArango Have you tried printing out the `destination` variable value? — Divya Mamgai, May 08 '17 at 06:31
@DivyaMamgai ok I restarted the emulator with no positive result, and destination prints "/storage/emulated/0/Download/perlajorgecuartasotorrino.apk" Aditionally, I tried in my phone, and the same issue is happening — Santiago Cuartas Arango, May 08 '17 at 06:32
@SantiagoCuartasArango Please check this [answer](http://stackoverflow.com/a/23761450/6249775). What Android version are you using in the emulator? — Divya Mamgai, May 08 '17 at 06:33
@NitinPatel `File.delete()` doesn't throw exceptions. If there was a need for `try` and `catch`the code wouldn't have compiled, let alone executed. — user207421, May 08 '17 at 06:36
@DivyaMamgai apparently that answer is a workaround that it's not working anymore — Santiago Cuartas Arango, May 08 '17 at 06:39
`delete()` should return `true`, and I think it actually deletes the file, or at least *some* file. Apparently, it's still there. Try to call `delete()` twice, the second call should return `false`. Second, try to upload this to a phone, for an emulator might spoof the deletion of the file, maybe by some configuration or something. — MC Emperor, May 08 '17 at 06:39
@SantiagoCuartasArango I knew it's a workaround but I just wanted you to realize that Android might not be allowing you to modify files that are not part of your App. — Divya Mamgai, May 08 '17 at 06:42
@DivyaMamgai mmm so that's it? the files will accumulate from now on? that's really bad news since the people usually never checks download folder — Santiago Cuartas Arango, May 08 '17 at 06:46
check this link stackoverflow.com/questions/4943629/how-to-delete-a-whole-folder-and-content answer given by "teedyay" — Lingeshwaran, May 08 '17 at 06:48
@SantiagoCuartasArango No, you should try downloading your new APK to your own App's directory because according to that answer it is permitted to modify files their. Of course I'm assuming you want to download a updated version of your own APK but if that's not the case let me know. — Divya Mamgai, May 08 '17 at 06:49
@SantiagoCuartasArango Your code is working fine for `text` file in real device, I have checked. So, make sure check there is file. — Nitin Patel, May 08 '17 at 06:52
@SantiagoCuartasArango Then I would not store it in the user's Download folder anyway. In fact I would prefer to not keep the APK once its installed. So you should try to download in Package-Specific location and delete it once installed to save user's space after all user is your first priority. — Divya Mamgai, May 08 '17 at 06:56
@SantiagoCuartasArango "Double call didn't work" — so what was the result? Did both calls return `true`? — MC Emperor, May 08 '17 at 07:00
@DivyaMamgai how can I do that? I only know how to download to the downloads folder — Santiago Cuartas Arango, May 08 '17 at 07:00
@SantiagoCuartasArango Take a look at [this](http://stackoverflow.com/questions/4739374/android-get-applications-home-data-directory). Modify your destination path accordingly. PS: [This](https://developer.android.com/reference/android/content/ContextWrapper.html#getFilesDir%28%29) might be help full too. — Divya Mamgai, May 08 '17 at 07:04
@DivyaMamgai unfortunatelly I'm getting `java.lang.SecurityException: Unsupported path /data/user/0//files/perlajorgecuartasotorrino.apk` in this line: `final long idDownload = downloadManager.enqueue(request);` — Santiago Cuartas Arango, May 08 '17 at 07:30

score 0 · Answer 1 · edited May 23 '17 at 10:31

0

Try this solution I have tested...

        String destination = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS) + "/";
        String fileName = getResources().getString(R.string.apkname) + ".apk";
        destination += fileName;

        try {
            File file = new File(destination);
            if (file.canRead()) {

                boolean mDeleleFile = file.delete();
                context.sendBroadcast(new Intent(Intent.ACTION_MEDIA_SCANNER_SCAN_FILE, Uri.fromFile(new File(destination))));
                if (mDeleleFile) {
                    Toast.makeText(getApplicationContext(), "File deleted", Toast.LENGTH_LONG).show();
                }
            }
        } catch (Exception e) {
            e.printStackTrace();
        }

I have reference from How to delete a file from SD card?

edited May 23 '17 at 10:31

Community

1
1

answered May 08 '17 at 08:43

rockstar

587
4
22

The file is there but I'm still reaching the toast message, so `mDeleteFile` is true – Santiago Cuartas Arango May 08 '17 at 19:50
I have tested this work for me. Once please check app permission go to manually.. by app info and check external storage permission – rockstar May 09 '17 at 03:14
1

sorry for the delayed answer. Isn't the permission asked in runtime enough for that? And your solution works on which android version? – Santiago Cuartas Arango May 15 '17 at 22:20

file.delete() returning true but the file is still there

1 Answers1