12

I have three lists of different types :

List<Customer> customerList = new List<Customer>();
List<Product> productList = new List<Product>();
List<Vehicle> vehicleList = new List<Vehicle>();

I also have this list

List<string> stringList = {"AND","OR"};

Since first element of stringList is AND I want to make inner join with customerList and productList. Then I want to make right join vehicleList with the result such as :

from cust in customerList 
join prod in productList on cust.ProductId equals prod.Id
join veh in vehicleList on prod.VehicleId equals veh.Id into v
from veh in v.DefaultIfEmpty()
select new {customerName = cust.Name, customerVehicle=veh.VehicleName}

I want to make this in automatized way, lets say I have N number of lists and N-1 number of ANDs and ORs, how can I join them? Besides there can be many lists of the same type. Is such a thing even possible? If not what can I do to make this closer to my need? Thanks in advance.

EDIT : I'm holding the lists and their types in a Dictionary like this :

var listDict = new Dictionary<Type, object>();

So I can iterate inside this dictionary if necessary.

djangojazz
  • 14,131
  • 10
  • 56
  • 94
jason
  • 6,962
  • 36
  • 117
  • 198
  • you should consider using lambda expressions and .Join extension methods for that. It will make you see what you want to do better imo. – Volkan Seçkin Akbayır May 10 '17 at 14:38
  • You could use Dynamic Linq to construct your query from a string: https://dynamiclinq.codeplex.com/ – Gusman May 10 '17 at 14:41
  • Put your Lists into an enumerable type and iterate it. Fetch the according element from stringList for the current iteration and perform the needed operation. Save the result in a new list and use that list in as base in the next iteration. – Romano Zumbé May 10 '17 at 15:00
  • 1
    Make a List of your lists so you can enumerate through all the lists. – jdweng May 10 '17 at 15:01
  • @RomanoZumbé I already have those lists in a list, actually dictionary like this : `var listDict = new Dictionary();` So I'm holding both lists and their types. But I couldn't imagine the rest of what you said. Could you provide a small sample? Thanks. – jason May 10 '17 at 15:09
  • This example shows how to intersect lists of the same type. I need to do something close to this with different types: http://stackoverflow.com/a/14984958/1954132 – jason May 10 '17 at 15:22
  • I would ask if this is ultimately mocking up something you want to do that's connected to a database. It's just my opinion but when you get into something with a lot of joins you should be doing that more in your back end whether it is a SQL Server Database or service layer. Point being that Linq makes some crazy sql and other things of nesting when doing multiple front end joins. If you are doing this client only I would be curious if you could get a 'predict builder' extension. http://www.albahari.com/nutshell/predicatebuilder.aspx – djangojazz May 10 '17 at 15:45
  • @djangojazz Those lists are just filtered DB entities. I think it would be more complicated both filtering and joining them in the database. – jason May 10 '17 at 15:47
  • Not really I do full stack and doing dynamic sql 'sp_executesql' and building expressions is easier there than in the front end. SQL is made for result set based operations and the front end is built for everything else. I wouldn't be doing something like Select * from a join (Select * from b join (Select * from c) as c on b.Id2 = c.Id2) as b on a.Id = b.Id. Point being if you use a tool like LinqPad and see resultant sql it is crazy messy at times. That impacts your backend as you are trusting complex operations to be interpreted that should be made in the backend. – djangojazz May 10 '17 at 15:51
  • I could just make up Create Proc pDynamicBuilder Declare \@SQL NVarchar(max); Select \@SQL = 'Select * from ' + (some variable)'; exec sp_executesql \@SQL. I then could call the proc in .NET with EF or whatever I choose and the heavy lifting would be done on the backend. Else you get some crazy frankenstein sql that takes minutes to run that could be ran in seconds if someone just did some backend coding. You can go dynamic in the front end and I think it's fine if it's just two or three levels at most, more than that and it's a sql performance killer if you are not careful. – djangojazz May 10 '17 at 15:55
  • @djangojazz I see what you mean. But my db is not that big so performance is not my highest priority now. But could you support your idea with some code please? Because I really can't imagine what you said with code.. For example if user enters this query: `CustomerCity:Seattle OR ProductType:Computer AND VehicleNumber:8 AND CustomerName:Jason` What would you do with that? Thanks. – jason May 10 '17 at 15:59
  • @jason sure, hold up and I can give you a simple example in SQL for SQL Server 2016. – djangojazz May 10 '17 at 16:05
  • It'd be easier to write one query that joins all the relevant tables in the database, then just append a dynamic where clause to it. If you then want to get cuter with joining tables, you can have example blocks of SQLthat join each table and add them in if your querystring contains an indication that elements of that table will be needed.. – Caius Jard May 10 '17 at 16:37
  • Look at this [link](https://github.com/kbenhddia/LinqExtension), it generates dynamic queries from string conditions. It does not help with your question but you might get a hint or two on how to approach the problem using expression trees and generate dynamic query by looking at the code and maybe alter it to support joins. – mfahadi May 10 '17 at 17:37
  • Dictionary collections don't have an order. Although it may look as though it is the order that the items were added, this is not guaranteed. This can then adversely affect the match up with your boolean operators – K Scandrett May 13 '17 at 12:43
  • You can make a join but you cannot make a select when you store lists in `Dictionary`. I mean, your query now returns anonymous type `new {customerName = cust.Name, customerVehicle=veh.VehicleName}`. What do you expect it to return when you build join dynamically? – Evk May 14 '17 at 13:21
  • @Evk It should return another type that I made. My lists don't have to be in a list. They can be contained in anything. I put them inside a dictionary for ease. – jason May 14 '17 at 13:26
  • But how would you select columns for that type you made if you don't know types of lists you join at compile time? Maybe you can provide an example od syntax you expect. So you have some magical method which will join all tables, what it should return exactly? You also need to specify on which columns to join. – Evk May 14 '17 at 13:28
  • @Evk I don't have a magical method, I need one :) I prepared a custom class which contains most of the properties of all lists. It should return that. But it can return an anonymous type as well, that's fine. – jason May 14 '17 at 13:31
  • I understand you don't have magical method, I just ask about what signature (arguments and return type) of that method should be, not the method itself. – Evk May 14 '17 at 13:33
  • Did you know that you can use ForeignKeyAttribute and your life will be extremely simple? – Anup Sharma May 14 '17 at 13:33
  • @AnupSharma I don't know about that. – jason May 14 '17 at 13:34
  • @Evk It should receive n numbers of lists as input and it should return anything. A simple object is fine. – jason May 14 '17 at 13:34
  • http://www.entityframeworktutorial.net/code-first/foreignkey-dataannotations-attribute-in-code-first.aspx There you go. Just use Virtual Keyword and then you don't have to use join where you don't need to. – Anup Sharma May 14 '17 at 13:35
  • @AnupSharma yeah I know that. But I think that's not what I need. – jason May 14 '17 at 13:37
  • And how would you know on which columns to join (ProductId, VehicleId, Id)? Also will pass to that magical function? – Evk May 14 '17 at 13:40
  • @Evk I know which columns to join. As you said ProductId, VehicleId, Id. And yes these can be passed to the function. – jason May 14 '17 at 14:06
  • Isn't the relation between Customer and Product always 'AND'? And the relation between Product and Vehicle always 'OR'? –  May 19 '17 at 16:38
  • @RuardvanElburg No they are not – jason May 19 '17 at 16:49

6 Answers6

4

UPDATE 5-15-17:

Just for the sake of recap what I am proposing is an example that we want to:

  1. Pass in a list of N number of Table objects.
  2. Pass in a list of N-1 join clauses of how to join them. EG: You have 2 tables you need a single join, 3 you need 2, and so on.
  3. We want to be to pass in a predicate to go up or down the chain to narrow scope.

What I would propose is to do all of this in SQL and pass into SQL an xml object that it can parse. However to keep it a little more simple to not deal with XML serialization too, let's stick with strings that are essentially one or many values to pass in. Say we have a structure going off of above like this:

/*
CREATE TABLE Customer ( Id INT IDENTITY, CustomerName VARCHAR(64), ProductId INT)
INSERT INTO Customer VALUES ('Acme', 1),('Widgets', 2)
CREATE TABLE Product (Id INT IDENTITY, ProductName VARCHAR(64), VehicleId INT)
Insert Into Product Values ('Shirt', 1),('Pants', 2)
CREATE TABLE VEHICLE (Id INT IDENTITY, VehicleName VARCHAR(64))
INSERT INTO dbo.VEHICLE VALUES ('Car'),('Truck')

CREATE TABLE Joins (Id INT IDENTITY, OriginTable VARCHAR(32), DestinationTable VARCHAR(32), JoinClause VARCHAR(32))
INSERT INTO Joins VALUES ('Customer', 'Product', 'ProductId = Id'),('Product', 'Vehicle', 'VehicleId = Id')

--Data as is if I joined all three tables
CustomerId  CustomerName    ProductId   ProductName VehicleId   VehicleName
1   Acme    1   Shirt   1   Car
2   Widgets 2   Pants   2   Truck
*/

This structure is pretty simplistic and everything is one to one key relationships versus it could have some other identifiers. The key to making things work is to maintain a table that describes HOW these tables relate. I called this table joins. Now I can create a dynamic proc like so:

CREATE PROC pDynamicFind
  (
    @Tables varchar(256)
  , @Joins VARCHAR(256)
  , @Predicate VARCHAR(256)
  )
AS
BEGIN
  SET NOCOUNT ON;

    DECLARE @SQL NVARCHAR(MAX) = 
'With x as 
    (
    SELECT
    a.Id
  , {nameColumns}
  From {joins}
  Where {predicate}
  )
SELECT *
From x
  UNPIVOT (Value FOR TableName In ({nameColumns})) AS unpt
'
    DECLARE @Tbls TABLE (id INT IDENTITY, tableName VARCHAR(256), joinType VARCHAR(16))
    DECLARE @Start INT = 2
    DECLARE @alphas VARCHAR(26) = 'abcdefghijklmnopqrstuvwxyz'

    --Comma seperated into temp table (realistically most people create a function to do this so you don't have to do it over and over again)
    WHILE LEN(@Tables) > 0
    BEGIN
        IF PATINDEX('%,%', @Tables) > 0
        BEGIN
            INSERT INTO @Tbls (tableName) VALUES (RTRIM(LTRIM(SUBSTRING(@Tables, 0, PATINDEX('%,%', @Tables)))))
            SET @Tables = SUBSTRING(@Tables, LEN(SUBSTRING(@Tables, 0, PATINDEX('%,%', @Tables)) + ',') + 1, LEN(@Tables))
        END
        ELSE
        BEGIN
            INSERT INTO @Tbls (tableName) VALUES (RTRIM(LTRIM(@Tables)))
            SET @Tables = NULL
        END
    END

    --Have to iterate over this one seperately
    WHILE LEN(@Joins) > 0
    BEGIN
        IF PATINDEX('%,%', @Joins) > 0
        BEGIN
            Update @Tbls SET joinType = (RTRIM(LTRIM(SUBSTRING(@Joins, 0, PATINDEX('%,%', @Joins))))) WHERE id = @Start
            SET @Joins = SUBSTRING(@Joins, LEN(SUBSTRING(@Joins, 0, PATINDEX('%,%', @Joins)) + ',') + 1, LEN(@Joins))
            SET @Start = @Start + 1
        END
        ELSE
        BEGIN
            Update @Tbls SET joinType = (RTRIM(LTRIM(@Joins))) WHERE id = @Start
            SET @Joins = NULL
            SET @Start = @Start + 1
        END
    END

    DECLARE @Join VARCHAR(256) = ''
    DECLARE @Cols VARCHAR(256) = ''

    --Determine dynamic columns and joins
    Select 
      @Join += CASE WHEN joinType IS NULL THEN t.tableName + ' ' + SUBSTRING(@alphas, t.id, 1) 
      ELSE ' ' + joinType + ' JOIN ' + t.tableName + ' ' + SUBSTRING(@alphas, t.id, 1) + ' ON ' + SUBSTRING(@alphas, t.id-1, 1) + '.' + REPLACE(j.JoinClause, '= ', '= ' + SUBSTRING(@alphas, t.id, 1) + '.' )
      END
    , @Cols += CASE WHEN joinType IS NULL THEN t.tableName + 'Name' ELSE ' , ' + t.tableName + 'Name' END
    From @Tbls t
      LEFT JOIN Joins j ON t.tableName = j.DestinationTable

    SET @SQL = REPLACE(@SQL, '{joins}', @Join)
    SET @SQL = REPLACE(@SQL, '{nameColumns}', @Cols)
    SET @SQL = REPLACE(@SQL, '{predicate}', @Predicate)

    --PRINT @SQL
    EXEC sp_executesql @SQL
END
GO

I now have a medium for finding things that makes it stubbed query so to speak that I can replace the source of the from statement, what I query on, what value I use to query on. I would get results from it like this:

EXEC pDynamicFind 'Customer, Product', 'Inner', 'CustomerName = ''Acme'''
EXEC pDynamicFind 'Customer, Product, Vehicle', 'Inner, Inner', 'VehicleName = ''Car'''

Now what about setting that up in EF and using it in code? Well you can add procs to EF and get data from this as context. The answer that this addresses is that I am essentially giving back a fixed object now despite however many columns I may add. If my pattern is always going to be '(table)name' to N numbers of tables I can normalize my result by unpivoting and then just getting N number of rows for however many tables I have. Thus performance may be worse as you get larger result sets but the potential to make however many joins you want as long as similar structure is used is possible.

The point I am making though is that SQL is ultimately getting your data and doing crazy joins that result from Linq is at times more work than it's worth. But if you do have a small result set and a small db, you are probably fine. This is just an example of how you would get completely different objects in SQL using dynamic sql and how fast it can do something once the code for the proc is written. This is just one way to skin a cat of which I am sure there are many. The problem is whatever road you go down with dynamic joins or a method of getting things out is going to require some type of normalization standard, factory pattern or something where it says I can have N inputs that always yield the same X object no matter what. I do this through a vertical result set, but if you want a different column than say 'name' you are going to have to code more for that as well. However the way I built this if you want the description but say wanted to do a predicate for a date field, this would be fine with that.

djangojazz
  • 14,131
  • 10
  • 56
  • 94
  • My db is not that big. I don't care about performance at all. Could you tell me how I can do it with LINQ? Thanks. – jason May 10 '17 at 19:27
  • I could try but I need a case example of what you would do manually. I have never attempted doing a dynamically built join statement. EG: You have customer, product and vehicle and have them in a dictionary. How do you know the joins? Are you always doing foreign key like (table).(tablename)id = (table).id? If so you run into the problem if you want to join say four objects and have N+1 to say 'Option' how do I know the position from customer? You would then be hoping you could just browse your schema and have the (table)id to find the table reference. – djangojazz May 10 '17 at 19:55
  • EG: Doing this in sql is simple: "Select * from {token} where {token2} = {token3}" is pretty simple. Doing this "Select * from {structurewithjoinclauses} where {token} = {token2}" would require evaluating a list coming in. Meaning If I wanted to do 'Select * from tablea where thing = 'option1'' is quite different from 'Select * from tablea a inner join tableb b on a.tablebId = b.Id where thing = 'val1''. – djangojazz May 10 '17 at 19:59
  • Or are you just meaning to make a 'FIXED' statement with those three objects and just change the predicate (where clause) dynamically. Because if that is the case learning LinqKit is definitely your answer as everything I could show you would be built into that thing much better than I could homebrew. If you thinking the first thing and building a compounding join statement, that would be rather complex and would still be best done in SQL IMHO. Sorry for the long response, but this may a hard thing of what you are attempting to do, doable, but hard. – djangojazz May 10 '17 at 20:02
  • For example, could you do the dynamic version of the join in the question? Thank you for your answer. – jason May 14 '17 at 09:15
3

If you always want the same set of output columns, then write your query ahead of time:

select * 
from

  customerList c
  inner join 
  productList p on c.ProductId = p.Id

  inner join
  vehicleList v on p.VehicleId = v.Id

Then append a dynamic where. At its simplest, just replace 'CustomerCity:' with 'c.city' and so on, so that what they wrote becomes valid SQL (Danger danger: if your user is not to be trusted then you must must must make your SQL injection proof. At the very least scan it for DML, or limit the keywords they can provide. Better would be to parse it into fields, parameterise it properly and add the values they provide to parameters)

Simple (ugh) we let the SQL parser do some work:

string whereClause = userInput;
whereClause = whereClause.Replace("CustomerCity:", "c.City = '");
whereClause = whereClause.Replace("VehicleNumber:", "v.Number = ");
//and so on
whereClause = whereClause.Replace(" AND", "' AND");
//some logic here to go through the string and close up those apostrophes

Ugly, and fragile. And hackable (if you care).

Parsing would be better:

sqlCommand.CommandText = "SELECT ... WHERE ";

string whereBits = userInput.Split(" ");
var parameters as new Dictionary<string, string>();
parameters["customercity"] = "c.City";
parameters["vehiclenumber"] = "v.Number";

foreach(var token in whereBits){
    var frags = token.Split(':');
    string friendlyName = frags[0].ToLower();

    //handle here the AND and OR -> append to sql command text and continue the loop        

    if(parameters.ContainsKey(friendlyName)){
      sqlCommand.CommandText += parameters[friendlyName] + " = @" + friendlyName;
      sqlCommand.Parameters.AddWithValue("@" + friendlyname, frags[1]);
    }
}

//now you should have an sql that looks like
//SELECT ... WHERE customercity = @customercity ...
// and a params collection that looks like:
//sql.Params[0] => ("@customercity", "Seattle", varchar)...

One thing to consider: will your user be able to construct that query and get the results they want? What in a users mind does CustomerCity:Seattle OR ProductType:Computer AND VehicleNumber:8 AND CustomerName:Jason mean anyway? Everyone in Seattle, plus every Jason whose Computer is in vehicle 8? Everyone in Seattle or who has a computer, but they must have vehicle 8 and be called jason?

Without precedence, queries could just turn out garbage in the user's hands

Caius Jard
  • 72,509
  • 5
  • 49
  • 80
  • You are telling me to write joins at first. What would happen if user enters only `OR`s ? How should I decide inner join or right join? And it would be awesome if you could provide a short complete sample code... I want to see how to generate SQL completely. There is no need for parsing, the code can be ugly and fragile, but it should work and should be easy :) . And yes user wants such a weird output. Actually the desired output will be like this : Every Jason in Seattle or whose device is Computer and its product will be shipped with a vehicle whose number is 8. Thank you very much. – jason May 10 '17 at 19:22
  • But even in your English version of the statement, I'm (pretending to be a database) and I don't know what output you want. You said: "Every Jason in Seattle or whose device is Computer and its product will be shipped with a vehicle whose number is 8" but did you want "(Every Jason in Seattle or whose device is Computer) and its product will be shipped with a vehicle whose number is 8" or did you want "Every Jason in Seattle or (whose device is Computer and its product will be shipped with a vehicle whose number is 8)". These are potentially very different things.. – Caius Jard May 11 '17 at 03:52
  • Using OR in queries typically makes them useless to users. Can you imagine doing a search of your local DIY store site for "plastic shower tray" and it returns products where plastic OR shower OR tray occurs? There will be thousands of irrelevants. Users typically want AND, and they're willing to do OR by running another query. If you allow results to be appended then they can get their OR by running multiple queries.. – Caius Jard May 11 '17 at 03:55
  • Whether a user enters OR or not shouldn't be a criteria for right join. Left and right joins are used when you know or wish to search for a relationship that has broken down. Products LEFT JOIN Orders will allow you to find all products that have no orders ie all those things you hold in stock probably uselessly because they are not wanted by your buying population. Orders LEFT JOIN Products (a.k.a Products RIGHT JOIN Orders) shows you all orders with no products; probably draft orders that are erroneous. Ultimately my point is that your data in all your tables makes some sort of sense as... – Caius Jard May 11 '17 at 04:00
  • ...a single "entity" in the users mind. You probably have to join the tables together in the same way all the time so you can write that part of the query first as a fixed thing (select * from products join orders join customeraddresses join invoices join trackinginfo join reviews join blahblah..) if you're planning on letting the user search for anything "I want to find all black items ordered in Seattle that have a review of 3 stars and haven't been delivered yet" because you need this huge block of data, then to filter it. There isn't much point adding the complexity of varying which... – Caius Jard May 11 '17 at 04:04
  • ...tables you join based on what the user is searching for, if they're only going to complain that some data is missing.. "Oh, I pulled the list of black things ordered in Seattle undelivered with a review of 3, but I can't see the invoice info!" - as tech you'll be saying "yeah, you need to add something like AND invoice number>1 if you want the invoice data to be joined in." Don't make he system too smart for its own good, or yours :) – Caius Jard May 11 '17 at 04:07
  • I have decided doing this : 1.Create List of lists of the same type. 2. `Intersect` or `AddRange` them if there is an `AND` or` OR` in front of them. Then join those lists of different types once. Isn't it a good idea? – jason May 11 '17 at 06:20
1

I think it would have been better if you just describe what the requirement is, instead of asking how to implement this strange design.

Performance isn't a problem... now. But that is how it always starts...

Anyways, I do not think performance has to be an issue. But that depends on the relations between tables. In your example there are lists with only one foreign key. Each customer has one product and each product has one vehicle. Resulting in one record.

But what happens if one vehicle has multiple products, from multiple customers? If you allow to combine tables in all kinds of ways, you're bound to create a Cartesian Product somewhere. Resulting in 1000s or more rows.

And how are you going to implement multiple relations between objects? Suppose there are users, and customer has the fields UpdatedByUser and CreatedByUser. How do you know which user maps to which field?

And what about numeric fields? It seems that you are treating all fields as string.

If you want to allow users to build queries, according to the relations in the database and existing fields, the best thing to do may be to write (generic) code to build your own expression trees. Using reflection you can show properties, etc. That may also result in the best queries.

But you may also consider to use MongoDB instead of Sql Server. If relations are not that important, then a relational database may not be the right place to store data. You may also consider to use the Full-text search feature in Sql Server.

If you want to use Sql Server then you should take advantage of the navigation properties that are present in Entity Framework 6 (code first). You think that is not what you need, but I think it can be very easy.

First you'll need to create a model and entities. Please note that you should not use the [Required] attribute for foreign keys. Because if you do, this will be translated to an inner join.

Next take the table you want to query:

var ctx = new Model();
//ctx.Configuration.ProxyCreationEnabled = false;
var q = ctx.Customers.AsQueryable();
// parse the 'parameters' to build the query
q = q.Include("Product");
// You'll have to build the include string
q = q.Include("Product.Vehicle");
var res = q.FirstOrDefault();

This will get all the data you'll need, all using left joins. In order to 'convert' a left join to an inner join you filter the foreign key to be not null:

var res = q.FirstOrDefault(cust => cust.ProductId != null);

So all you need is the table where you want to start. And then build the query anyway you like. You can even parse a string: Customer AND Product OR Vehicle instead of using seperate lists.

The variable res contains the customer which links to Product. But res should be the result of a select:

var res = q.Select(r => new { CustName = Customer.Name, ProductName = Customer.Product.Name).FirstOrDefault();

In the question there is no mention of filters, but in the comments there is. In case you want to add filters you can also think of building your query like this:

q = q.Where(cust => cust.Name.StartsWith("a"));
if (someCondition = true)
    q = q.Where(cust => cust.Product.Name.StartsWith("a"));
var res = q.ToList();

This is just to give you an idea how you can take advantage of EF6 (code-first). You don't have to think about the joins, since these are already defined and automatically picked up.

0

decompose your linq/lambda expression using How to Convert LINQ Comprehension Query Syntax to Method Syntax using Lambda

you will get

   customerList.Join(productList, cust => cust.ProductId, prod => prod.Id, (cust, prod) => new { cust = cust, prod = prod })
                .GroupJoin(vehicleList, cp => cp.prod.VehicleId, veh => veh.Id, (cp, v) => new { cp = cp, v = v })
                .SelectMany(cv => cv.v.DefaultIfEmpty(), (cv, veh) => new { customerName = cv.cp.cust.Name, customerVehicle = veh.VehicleName });

besides listDict, you will need the following keyArr as well:

keyArr[0] = { OuterKey = cust => cust.ProductId; InnerKey = prod => cust.Id; };
keyArr[1] = ...

for loop the listDict using the follow code:

var result = customerList;
foreach(var ld in listDict)
{
    //use this
    result = result.Join(ld, keyArr[i].OuterKey, keyArr[i].InnerKey, (cust, prod) => new { cust = cust, prod = prod });

    //or this or both depends on the query
    result = result.GroupJoin(ld, cp => cp.prod.VehicleId, veh => veh.Id, (cp, v) => new { cp = cp, v = v })
}
// need to define concrete class for each table
// and grouping result after each join

//and finally
result.SelectMany(cv => cv.v.DefaultIfEmpty(), (cv, veh) => { customerName = cv.cp.cust.Name, customerVehicle = veh.VehicleName });
Community
  • 1
  • 1
Eric
  • 365
  • 3
  • 6
0

I think there are several reasons why you (and other answers and comments so far) are struggling with the solution. Primarily, as stated, you do not have enough meta information to successfully construct the complex relationship of the overall operation.

Absent Metadata

In looking at your inline LINQ example, specifically to quote:

from cust in customerList 
join prod in productList on cust.ProductId equals prod.Id
join veh in vehicleList on prod.VehicleId equals veh.Id into v
from veh in v.DefaultIfEmpty()
select new {customerName = cust.Name, customerVehicle=veh.VehicleName}

... if we are to parse the knowledge that is inherently stated in the above code, we'll identify the following:

  1. There are 3 separate data sets (of non-homogeneous types, though this is more evident from your List<T> examples at the beginning of the question) that serve as source of data. This meta information is available in the List<T> setups as sources to LINQ, and thus this part is not an issue.
  2. The join order and type of join (i.e. AND implies .Join() and OR implies .GroupJoin()). This meta information is more or less also available for the list approach setup.
  3. The relationship between the types, and the key to be used to compare one type to another. That is, that customer relates to product (as opposed to vehicle) and that customer-product relationship is defined as Customer.ProductId = Product.Id; or that vehicle relates to product (as opposed to customer) and that relationship is defined as Product.VehicleId = Vehicle.Id. This meta information, as list setup presented in your question is NOT available.
  4. Projection of the resulting (interim and final) data set members. The example is not specific whether each data set is represented by a unique model (i.e. for all List<T>s that each T is unique) or if repeats are possible. Because inline LINQ allows you to reference specific data set, having two data sets of the same type is not an issue when defined statically because each data set is referenced by name and thus relationship is clear. If type can appear more than once, and if metadata is available to determine type relationships dynamically, the trouble creeps in that you don't know which instance of multiple instances of the same type to relate to. In other words if it is possible to have Person join Friends join Person join Car, it is not clear if Car should be matched to first Person or second Person. One possibility is to make assumption that in such cases you resolve relationship to the last instance of Person. Needless to say your lists setup doesn't have this meta information. For the purposes of this answer going forward, I'll assume that all types are unique and do not repeat.
  5. Unlike the intersect example you referenced in comments, whereas Intersect is a parameter-less operator (besides the other set to intersect over), Join operator requires parameter(s) to identify the relationship by which to relate to the other data set. I.e. the parameter(s) is the meta information described in point 3 above.

Metadata

To close the gaps identified above is not simple, but is not insurmountable either. One approach is to simply annotate the data model types with relationship meta data. Something along the lines of:

class Vehicle
{
    public int Id;    
}

// PrimaryKey="Id" - Id refers to Vehicle.Id, not Product.Id
[RelationshipLink(BelongsTo=typeof(Product), PrimaryKey="Id", ForeignKey="VehicleId"]
class Product
{
    public int Id;
    public int VehicleId;
}

// PrimaryKey="Id" - Id refers to Product.Id, not Customer.Id
[RelationshipLink(BelongsTo=typeof(Product), PrimaryKey="Id", ForeignKey="ProductId"]
class Customer
{
    public int Id;
    public int ProductId;
}

This way, as you loop through the data sets as you're setting up joins, using reflection you can examine what type this data set is related to and how, lookup previous data sets for matching data type, and, again using reflection, setup .Join's or .GroupJoins key selectors for matching the relationship of instances of data.

Interim Projections

In static definitions of LINQ statements (be it using inline join or extension method .Join) you control what result of the join looks like and how data is merged and transformed into a shape (aka another model) convenient for subsequent operations (usually by use of anonymous objects). With dynamic set up, this is very difficult if not altogether impossible because you'd need to know what to keep, what not, how to resolve name collision of data models' properties, etc.

To solve this issue, you can probably propagate all interim results (aka projections) as a Dictionary<Type, object>, and simply carry through full models, each tracked by its type. And the reason you want to make it easy to track by its type is so that when you join previous interim result with the next dataset, and need to build the primary/foreign key functions, you have easy means to lookup the time that you discover from [RelationshipLink] metadata.

The final project of the result, again, is not really stated in your question, but you need some way of dynamically determining what part of very wide result do you want (or all of it), or how to transform its shape back into whatever function that will be consuming the results of the giant join.

Algorithm

Finally, we can put the whole thing together. The code below is going to be just high-level of algorithm in C#-pseudocode, and not full C#. See footnote.

var datasets = GetListsOfDatasets().ToArray(); // i.e. the function that returns customerList, productList, vehicleList, etc as a set of List<T>'s

var joins = datasets.First().Select(item => new Dictionary<Type, object> {[item.GetType()] = item});

var joinTypes = stringList.ToQueue() // the "AND", "OR" that tells how to join next one.  Convert to queue so we can pop of the top.  Better make it enum rather than string.

foreach(dataset in datasets.Skip(1))
{
    var outerKeyMember = GetPrimaryKeyMember(dataset.GetGenericEnumerableUnderlyingType());
    var innerKeyMember = GetForeignKeyMember(dataset.GetGenericEnumerableUnderlyingType());
    var joinType = joinTypes.Pop();

    if ()
    joins = joinType == "AND:
      ? joins.Join(
        dataset,
        outerKey => ReflectionGetValue(outerKeyMember.Member, outerKey[outerKeyMember.Type]),
        innerKey => ReflectionGetValue(innerKeyMember.Member, innerKey),
        (outer, inner) => {
            outer[inner.GetType] = inner;
            return outer;
        })
      : joins.GroupJoin(/* similar key selection as above */)
             .SelectMany (i => i) // Flatten the list from IGrouping<T> back to IEnumerable<T>
}

var finalResult = joins.Select(v => /* TODO: whatever you want to project out, and however you dynamically want to determine what you want out */);

/////////////////////////////////////

public Type GetGenericEnumerableUnderlyingType<T>(this IEnumerable<T>)
{
   return typeof(T);
}

public TypeAndMemberInfo GetPrimaryKeyMember(Type type)
{
   // TODO
   // Using reflection examine type, look for RelationshipLinkAttribute, and examine PrimaryKey specified on the attribute.
   // Then reflect over BelongsTo declared type and find member declared as PrimaryKey

   return new TypeAndMemberInfo {Type = __belongsToType, Member = __relationshipLinkAttribute.PrimaryKey.AsMemberInfo }
}

public TypeAndMemberInfo GetForeignKeyMember(Type type)
{
    // TODO Very similar to GetPrimaryKeyMember, but for this type and this type's foreign key annotation marker.
}

public object ReflectionGetValue(MemberInfo member, object instance)
{
   // TODO using reflection as member to return value belonging to instance.
}

So the high-level idea is that you take the first data set and wrap each member of the set with dictionary that specifies the type of the member and the member instance itself. Then, for each next dataset, you discover the underlying model type of the dataset, using reflection lookup the relationship metadata that tells you how to relate it to another type (that should have already been exposed in previous processed dataset or the code will blow up because join won't have anything to get key values from), lookup instance of the type from the outer enumerable's dictionary, get that instance and discovered key and get that instance's value as the value for outer key, and very similar reflect and discover value of the inner's foreign key member, and let .Join do the rest of the joining. Keep looping to the end, with each iteration projection carrying full instances of each model.

Once done with all datasets, define what you want out of it using .Select with whatever definition you want, and execute the complex LINQ to pump the data.

Performance Considerations

To perform a join, it means that at least one data-set must be fully read so that key membership may be probed into it while processing the other data-set for matches.

Modern DB engines like SQL Server are able to process joins of extremely large data sets because they go the extra step of having the ability to persist out interim results rather than build up everything in memory, and pull from disk as needed. As such, billions of items join billions of items does not blow up due to free memory starvation - once memory pressure is identified, the interim data and matched results are temporarily persisted to tempdb (or whatever disk storage that backs memory).

Here, default LINQ .Join is an in-memory operator. Large enough data set will blow memory and cause OutOfMemoryException. If you foresee processing many joins resulting in very large datasets, you may need to write your own implementation of .Join and .GroupJoin that use some sort of disk paging to store one data set in format that can be easily probed for membership when trying to match items from the other set, so as to relieve the memory pressure and use disk for memory.

Voila!

Footnotes

First, because you question (sans comments) is asked in the domain of a simple LINQ (meaning IEnumerable and not IQueryable and not SQL or stored procs, I have thus limited the scope of the answer to strictly that domain to follow the spirit of the question. This is not to say that at higher level this problem doesn't lend well to a solution in some other domain.

Second, even though SO rules are for good, compile-able, working code in answers, the reality of this solution is that it is probably at least a few hundred lines of code, and would require many lines of code to do reflection. How to do reflection in C# is, obviously, beyond the scope of the question. As thus, code presented is pseudo code and focuses on algorithm, reducing non-pertinent parts to comments describing what happens and leaving the implementation to the OP (or those finding this useful in the future.

Community
  • 1
  • 1
LB2
  • 4,802
  • 19
  • 35
0

The following code solves your problem.

Fist we need data, so I build some sample lists of three different types. My solution can handle multiple tables of the same data type.

Then I build the list of join specifications, specifying the tables, join fields and join type:

Warning: The order of the specifications must be same (must follow the topological sort). The first join joins two tables. The subsequent joins must join one new table to one of the existing tables.

var joinSpecs = new IJoinSpecification[] {
    JoinSpecification.Create(list1, list2, v1 => v1.Id, v2 => v2.ForeignKeyTo1, JoinType.Inner),
    JoinSpecification.Create(list2, list3, v2 => v2.Id, v3 => v3.ForeignKeyTo2, JoinType.LeftOuter)
};

then you just execute the joins:

//Creating LINQ query
IEnumerable<Dictionary<object, object>> result = null;
foreach (var joinSpec in joinSpecs) {
    result = joinSpec.PerformJoin(result);
}
//Executing the LINQ query
var finalResult = result.ToList();

The result is a list of dictionaries containing the joined items, so the access looks like this: rowDict[table1].Column2. You can even have multiple tables of same type - this system handles that easily.

Here is how you do the final projection of your joined data:

var resultWithColumns = (
    from row in finalResult
    let item1 = row.GetItemFor(list1)
    let item2 = row.GetItemFor(list2)
    let item3 = row.GetItemFor(list3)
    select new {
        Id1 = item1?.Id,
        Id2 = item2?.Id,
        Id3 = item3?.Id,
        Value1 = item1?.Value,
        Value2 = item2?.Value,
        Value3 = item3?.Value
    }).ToList();

The full code:

using System;
using System.Collections.Generic;
using System.Linq;

public class Type1 {
    public int Id { get; set; }
    public int Value { get; set; }
}

public class Type2 {
    public int Id { get; set; }
    public string Value { get; set; }
    public int ForeignKeyTo1 { get; set; }
}

public class Type3 {
    public int Id { get; set; }
    public string Value { get; set; }
    public int ForeignKeyTo2 { get; set; }
}

public class Program {
    public static void Main() {
        //Data
        var list1 = new List<Type1>() {
            new Type1 { Id = 1, Value = 1 },
            new Type1 { Id = 2, Value = 2 },
            new Type1 { Id = 3, Value = 3 }
            //4 is missing
        };
        var list2 = new List<Type2>() {
            new Type2 { Id = 1, Value = "1", ForeignKeyTo1 = 1 },
            new Type2 { Id = 2, Value = "2", ForeignKeyTo1 = 2 },
            //3 is missing
            new Type2 { Id = 4, Value = "4", ForeignKeyTo1 = 4 }
        };
        var list3 = new List<Type3>() {
            new Type3 { Id = 1, Value = "1", ForeignKeyTo2 = 1 },
            //2 is missing
            new Type3 { Id = 3, Value = "2", ForeignKeyTo2 = 2 },
            new Type3 { Id = 4, Value = "4", ForeignKeyTo2 = 4 }
        };

        var joinSpecs = new IJoinSpecification[] {
            JoinSpecification.Create(list1, list2, v1 => v1.Id, v2 => v2.ForeignKeyTo1, JoinType.Inner),
            JoinSpecification.Create(list2, list3, v2 => v2.Id, v3 => v3.ForeignKeyTo2, JoinType.LeftOuter)
        };

        //Creating LINQ query
        IEnumerable<Dictionary<object, object>> result = null;
        foreach (var joinSpec in joinSpecs) {
            result = joinSpec.PerformJoin(result);
        }

        //Executing the LINQ query
        var finalResult = result.ToList();

        //This is just to illustrate how to get the final projection columns
        var resultWithColumns = (
            from row in finalResult
            let item1 = row.GetItemFor(list1)
            let item2 = row.GetItemFor(list2)
            let item3 = row.GetItemFor(list3)
            select new {
                Id1 = item1?.Id,
                Id2 = item2?.Id,
                Id3 = item3?.Id,
                Value1 = item1?.Value,
                Value2 = item2?.Value,
                Value3 = item3?.Value
            }).ToList();

        foreach (var row in resultWithColumns) {
            Console.WriteLine(row.ToString());
        }
        //Outputs:
        //{ Id1 = 1, Id2 = 1, Id3 = 1, Value1 = 1, Value2 = 1, Value3 = 1 }
        //{ Id1 = 2, Id2 = 2, Id3 = 3, Value1 = 2, Value2 = 2, Value3 = 2 }
    }
}

public static class RowDictionaryHelpers {
    public static IEnumerable<Dictionary<object, object>> CreateFrom<T>(IEnumerable<T> source) where T : class {
        return source.Select(item => new Dictionary<object, object> { { source, item } });
    }

    public static T GetItemFor<T>(this Dictionary<object, object> dict, IEnumerable<T> key) where T : class {
        return dict[key] as T;
    }

    public static Dictionary<object, object> WithAddedItem<T>(this Dictionary<object, object> dict, IEnumerable<T> key, T item) where T : class {
        var result = new Dictionary<object, object>(dict);
        result.Add(key, item);
        return result;
    }
}

public interface IJoinSpecification {
    IEnumerable<Dictionary<object, object>> PerformJoin(IEnumerable<Dictionary<object, object>> sourceData);
}

public enum JoinType {
    Inner = 1,
    LeftOuter = 2
}

public static class JoinSpecification {
    public static JoinSpecification<TLeft, TRight, TKeyType> Create<TLeft, TRight, TKeyType>(IEnumerable<TLeft> LeftTable, IEnumerable<TRight> RightTable, Func<TLeft, TKeyType> LeftKeySelector, Func<TRight, TKeyType> RightKeySelector, JoinType JoinType) where TLeft : class where TRight : class {
        return new JoinSpecification<TLeft, TRight, TKeyType> {
            LeftTable = LeftTable,
            RightTable = RightTable,
            LeftKeySelector = LeftKeySelector,
            RightKeySelector = RightKeySelector,
            JoinType = JoinType,
        };
    }
}

public class JoinSpecification<TLeft, TRight, TKeyType> : IJoinSpecification where TLeft : class where TRight : class {
    public IEnumerable<TLeft> LeftTable { get; set; } //Must already exist
    public IEnumerable<TRight> RightTable { get; set; } //Newly joined table
    public Func<TLeft, TKeyType> LeftKeySelector { get; set; }
    public Func<TRight, TKeyType> RightKeySelector { get; set; }
    public JoinType JoinType { get; set; }

    public IEnumerable<Dictionary<object, object>> PerformJoin(IEnumerable<Dictionary<object, object>> sourceData) {
        if (sourceData == null) {
            sourceData = RowDictionaryHelpers.CreateFrom(LeftTable);
        }
        return
            from joinedRowsObj in sourceData
            join rightRow in RightTable
                on joinedRowsObj.GetItemFor(LeftTable).ApplyIfNotNull(LeftKeySelector) equals rightRow.ApplyIfNotNull(RightKeySelector)
                into rightItemsForLeftItem
            from rightItem in rightItemsForLeftItem.DefaultIfEmpty()
            where JoinType == JoinType.LeftOuter || rightItem != null
            select joinedRowsObj.WithAddedItem(RightTable, rightItem)
        ;
    }
}

public static class FuncExtansions {
    public static TResult ApplyIfNotNull<T, TResult>(this T item, Func<T, TResult> func) where T : class {
        return item != null ? func(item) : default(TResult);
    }
}

The code outputs:

{ Id1 = 1, Id2 = 1, Id3 = 1, Value1 = 1, Value2 = 1, Value3 = 1 }

{ Id1 = 2, Id2 = 2, Id3 = 3, Value1 = 2, Value2 = 2, Value3 = 2 }

P.S. The code absolutely lacks any error checking to make it more compact and easier to read.

Community
  • 1
  • 1
Ark-kun
  • 6,358
  • 2
  • 34
  • 70