Create a function to list array of values in an object

Question

This is for an assignment. Please DO NOT down vote. Everybody had to start somewhere, and each person learns differently.

I need to create a function that builds an array consisting solely of the values in any given simpler object: for example: //headache {abd:123, def: 345, ghi: 756} should yield array juice [123, 345, 756];

If I type the object.key 'headache.abd', the console will show the value '123', and using this logic, I attempted to use the 'array.push' function to build a list. Here's my code:

function listAllValues(headache) {
  var juice =[];
  for (var keys in headache){
      juice.push(obj.keys);
  }
  console.log(juice);
}

//But the above code prints out [undefined, undefined, undefined], instead of [123, 345, 756]. Where did I mess up? I feel like I'm close, but I've been unsuccessfully trying various combinations :(, help please.

headache is a basic object, I believe I posted it in the opening of the question:// headache {abd:123, def: 345, ghi: 756} — Joan, May 20 '17 at 14:33
So, you're just trying to add the keys of an object to a list? — Carcigenicate, May 20 '17 at 14:34
Possible duplicate of [Iterate through object properties](http://stackoverflow.com/questions/8312459/iterate-through-object-properties) — Carcigenicate, May 20 '17 at 14:36
Although, you should check the object itself first, since I wouldn't expect it to yield undefineds. I suspect the object you're passing in to the function isn't what you think it is. — Carcigenicate, May 20 '17 at 14:38

Dinesh undefined · Answer 1 · 2017-05-20T14:49:49.837

0

use headache[keys] insteda of obj.keys.

function listAllValues(headache) {
  var juice =[];
  for (var keys in headache){
      juice.push(headache[keys]);
  }
  alert(juice);
}


headache = {abd:123, def: 345, ghi: 756} ;
listAllValues(headache);

edited May 20 '17 at 14:49

answered May 20 '17 at 14:42

Dinesh undefined

5,490
2
19
40

score 0 · Answer 2 · answered May 20 '17 at 14:45

Your code has a couple wonky things:

It tries to use a obj object, but that doesn't exist
You're never using the keys item that the loop gives you
- It should probably be key instead
You're never filtering it using hasOwnProperty which you should always do.
You're printing inside the function which is generally regarded as bad

Fixed up code:

function listAllValues(headache) {
  var juice =[];
  for (var key in headache){
        if (headache.hasOwnProperty(key)) {
          juice.push(headache[key]);
       } 
  }
  return juice;
}

console.log(listAllValues({abd:123, def: 345, ghi: 756} ))

Create a function to list array of values in an object

2 Answers2