Generic stack push error

Question

Im trying to create a generic stack. I have a problem when i try to push a value into the stack, the programm crashes in the memmove line:

typedef struct s_node{
    void *info;
    struct s_node *next;
}t_node;

typedef struct{
    char name[50];
    int salary;
}t_employee;

typedef t_node* t_stack;

void createStack(t_stack *p){
    *p=NULL;
}

int push(t_stack *p,void *inf,int siz){
    t_node *new=(t_node*)malloc(sizeof(t_node));
    if(!new)return 0;
    memmove(new->info,inf,siz);    !!!!!CRASH
    new->next=*p;
    *p=new;
    return 1;
}

int main()
{
    t_stack p;
    t_employee e={"Jhon Freeman",30000};
    createStack(&p);
    push(&p,&e,sizeof(t_employee));
    return 0;
}

`memmove(new->info,inf,siz);` : `new->info` isn't uninitialized variable. You need to assign to it (allocate memory). — BLUEPIXY, May 23 '17 at 01:18

score 1 · Accepted Answer · answered May 23 '17 at 01:20

1

new->info is pointing to nowhere. Initialize it :)

answered May 23 '17 at 01:20

Gam

684
1
8
17

score 1 · Answer 2 · answered May 23 '17 at 01:31

1

You declare new, but new->info is not initialized.

answered May 23 '17 at 01:31

Felipe Maturana

13
4

Generic stack push error

2 Answers2