Replace some Characters in a String

Question

I have this String

link="https%3a%2f%2fen.wikipedia.org%2fwiki%2fHuawei/"

which shoud be like this:

link="https://en.wikipedia.org/wiki/Huawei/"

I wrote this code:

link.Replace("%2f", "/");
link.Replace("%3a", ":");

But it did not work.

You forgot to assign your variable: `link = link.Replace("%2f", "/");` and `link = link.Replace("%3a", ":");` — Mederic, May 29 '17 at 15:26
Replace works. There are dozens of duplicate questions already. Another one was asked today — Panagiotis Kanavos, May 29 '17 at 15:28
What means "doesn´t work"? Please be more specific on what you´ve tried and what you expect to get and what you get instead. — MakePeaceGreatAgain, May 29 '17 at 15:29
*"it did not work"* - extremely poor problem description. Please read [how to ask questions](https://stackoverflow.com/help/how-to-ask) — Sergey Berezovskiy, May 29 '17 at 15:29
@PanagiotisKanavos there are so many duplicates I cannot even decide which one to mark — Camilo Terevinto, May 29 '17 at 15:30

score 3 · Accepted Answer · answered May 29 '17 at 15:30

Instead of trying to decode the URL yourself I'd use HttpUtility.UrlDecode

HttpUtility.UrlDecode("https%3a%2f%2fen.wikipedia.org%2fwiki%2fHuawei/")
"https://en.wikipedia.org/wiki/Huawei/"

See: https://msdn.microsoft.com/en-us/library/system.web.httputility.urldecode(v=vs.110).aspx

score 1 · Answer 2 · answered May 29 '17 at 15:26

1

String.Replace does return the value replaced try:

link = link.Replace("%2f", "/");

answered May 29 '17 at 15:26

Cleptus

3,446
4
28
34

Storing the result on the same variable is going to cause additional confusion – Panagiotis Kanavos May 29 '17 at 15:31

score 0 · Answer 3 · answered May 29 '17 at 15:28

link is a string and is not mutating when you call the Replace method

link.Replace will not affect the link object itself, instead it returns a new String from the doc emphasis mine:

Returns a new string in which all occurrences of a specified Unicode character in this instance are replaced with another specified Unicode character.

do instead:

link = link.Replace("%2f", "/");   or
link = link.Replace("%3a", ":");

Replace some Characters in a String

3 Answers3