Table not updated when user logout

Question

What is the proper way to indicate in your db when a user is logout of an application.

session::start();
$username = session::check()["username"];
$link->query("UPDATE admin SET isOnline = 0 WHERE username = '".$username."'");
session::destroy();
exit;

This is my current implementation.

You have a comma before WHERE clause. I've never seen that so I think that could cause a syntax issue. — TurtleTread, Jun 05 '17 at 16:17
You're already using an API that supports **prepared statements**, you should utilize parameterized queries with placeholders (prepared statements) to protect your database against [SQL-injection](http://stackoverflow.com/q/60174/)! Get started with [`mysqli::prepare()`](http://php.net/mysqli.prepare). — Qirel, Jun 05 '17 at 16:21
@Qirel, you could have pointed that out, instead of downvoting it, but tnks anyways. — , Jun 05 '17 at 16:24
It's not my downvote.. I voted to close, yes - but that's not a downvote ;-) And I did point out the error in your query. — Qirel, Jun 05 '17 at 16:25

itay · Accepted Answer · 2017-06-05T16:21:39.013

1

edit:

$link->query("UPDATE admin SET isOnline = 0 WHERE username ='".$username."'");

edited Jun 05 '17 at 16:21

answered Jun 05 '17 at 16:15

itay

357
4
16

you are both right. I was thinking that he use prepared statement,I checked the question agian and saw that he have unessery comma, edit my answer. thank you – itay Jun 05 '17 at 16:22

score 0 · Answer 2 · edited Jun 08 '17 at 02:21

0

This is what I used:

$query = "UPDATE Logins SET logouttime='$logouttime' WHERE Email='$Email' AND 
            fromproxy='$pipaddress' AND fromip='$ipaddress'";
unset($_SESSION);

edited Jun 08 '17 at 02:21

Pang

9,564
146
81
122

answered Jun 05 '17 at 17:38

Jon Hogan

1
5

Table not updated when user logout

2 Answers2