App which displays List does not work

Question

I try to make an App with button which after the push will display all elements from list in editText. But I have a problem, currently after I push the button I see only "second" in editText
In my opinion I need a tips from you about how to do it. Maybe I shouldn't use a loop ?

public class MainActivity extends AppCompatActivity {

    private Button button;
    private EditText editText;
    private ArrayList<String> list = new ArrayList<>();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        button = (Button) findViewById(R.id.button);
        editText = (EditText) findViewById(R.id.editText);

        list.add(0, "first");
        list.add(1, "second");

        button.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

                for (String abc: list){

                    editText.setText(abc);

                }


            }
        });
    }

}

____ edit

public class MainActivity extends AppCompatActivity {

    private Button button;
    private EditText editText;
    private ArrayList<String> list = new ArrayList<>();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        button = (Button) findViewById(R.id.button);
        editText = (EditText) findViewById(R.id.editText);

        list.add(0, "first");
        list.add(1, "second");
        list.add(2, "3");
        list.add(3, "4");
        list.add(4, "5");

        button.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

                String final_text = "";

                for (String abc: list){

                    final_text = final_text + "\n" + abc;

                }

                editText.setText(final_text);

            }
        });
    }

}

enter image description here

Hint: You are overwriting `"first"` with "`second"` – Zakir Jun 07 '17 at 21:58 — Zakir, Jun 07 '17 at 21:58

score 2 · Accepted Answer · answered Jun 07 '17 at 22:05

2

You are overwriting the text in editText. Accumulate the strings from the list and do a setText outside the loop:-

@Override
public void onClick(View v) {
  String final_text ="";
  for (String abc: list){
   final_text = final_text +"\n" + abc;
  }
  editText.setText(final_text);
}

answered Jun 07 '17 at 22:05

Zakir

2,222
21
31

single words are still in this same lane – androidmanifest3 Jun 07 '17 at 22:40
every list element should be in a new line due to `final_text +"\n" + abc` – Zakir Jun 07 '17 at 22:41
i added edit question with screen and finally new code, how does it look on device, can you check why didn't work ? – androidmanifest3 Jun 07 '17 at 22:55
make sure your editText's property in manifest.xml is set to multi-line : https://stackoverflow.com/questions/4233626/allow-multi-line-in-edittext-view-in-android – Zakir Jun 07 '17 at 23:04
wow, nice, and last question, is it possible to do it without 1st emply line ? – androidmanifest3 Jun 07 '17 at 23:09
Glad it worked for you! Do you mind accepting-upvoting the ans.. There is no "1st empty line" in your picture - it's the way the layout is drawn - probably top padding and / or middle placement .. – Zakir Jun 07 '17 at 23:14
stack don't let me upvote answer because i don't have 15 reputation :/ – androidmanifest3 Jun 08 '17 at 15:50

score 0 · Answer 2 · answered Jun 07 '17 at 22:13

On this loop you will always get the last string of the list into the edittext

for (String abc: list){
    editText.setText(abc);
}

You need to create multiple edittext to add multiple value from your list, or else you need to compile all value from list to one string like @Zakir has propose.

App which displays List does not work

2 Answers2