How to splice user correctly from scope in AngularJS?

Question

I am trying to remove user from the list. For some reason, splicing is not removing the user from the list. Can any one help me solve this. I am getting the users from a backend API call, and I am using a PUT method to update it when it removes that particular user.

app.js

app.controller('MyCtrl', function($scope, $window) {

    $scope.inactive = true;

    $scope.confirmedAction = user => {
        const index = $scope.userInfo.users.indexOf(user);
        $scope.userInfo.users.splice(user, 1);
        $window.location.href = '#/user';
    };

});

@A.Akram I tried that too, still for some reason it does not remove. — , Jun 08 '17 at 02:25
Is index returning a correct value? What are type of `user`? if it's an object `indexOf` won't work ! — A.Akram, Jun 08 '17 at 02:26
Try changing indexOf into what is described here: https://stackoverflow.com/questions/15997879/get-the-index-of-the-object-inside-an-array-matching-a-condition?answertab=active#tab-top — A.Akram, Jun 08 '17 at 02:31
Ok, what is unique in `user` object ? do you have `id` property? — A.Akram, Jun 08 '17 at 02:34
yes, I do have a id property that is coming from the api call. — , Jun 08 '17 at 02:34

davidJohn · Answer 1 · 2017-06-08T02:39:07.430

1

you should splice based on index

$scope.userInfo.users.splice(index, 1);

as per the docs Array.prototype.splice

index at which to start changing the array (with origin 0). If greater than the length of the array, actual starting index will be set to the length of the array

just to show a POC

var array = ['val1','val2','val3']
var index = array.indexOf('val2')
array.splice(index,1);

console.log(array);
//['val1','val3']

edited Jun 08 '17 at 02:39

answered Jun 08 '17 at 02:26

davidJohn

11
3

lets check some steps 1) is it an array 2)is `user` in the array? – davidJohn Jun 08 '17 at 02:28
it its an object why not do `delete userInfo.users.user` – davidJohn Jun 08 '17 at 02:30
like this delete userInfo.users.splice(index, 1);? – Jun 08 '17 at 02:30
if yes, that did not removed – Jun 08 '17 at 02:31
@user3799108 delete won't work with array. it will turn that element to `undefined` but still there. :-) – Pengyy Jun 08 '17 at 02:32
sorry i thought the users was an object, delete works if its an object only,wont work for an array – davidJohn Jun 08 '17 at 02:41
where is `user` coming from? i have a feeling that `user` is not found in the array – davidJohn Jun 08 '17 at 02:42
or, there are duplicate `user` objects in `users`, since indexOf will only return index of first element found, other elements after will not be returned – davidJohn Jun 08 '17 at 02:50
the users are coming from my html " ng-repeat="person in userInfo.users | filter:userSearch" >" – Jun 08 '17 at 11:38

score 0 · Answer 2 · answered Jun 08 '17 at 02:38

0

From comments I noticed:

user is an object, and the function's parameter user is not the same instance!

Also assuming you have id property in user object.

Using Array.findIndex.

app.controller('MyCtrl', function($scope, $window) {
        $scope.inactive = true;
        $scope.confirmedAction = function (user) {
           var index = $scope.userInfo.users.findIndex(u=> u.id == user.id);
          if(index>=0) {
              $scope.userInfo.users.splice(user, 1);
              $window.location.href = '#/user';
          }
        }
    });

answered Jun 08 '17 at 02:38

A.Akram

412
5
22

This didn't work either. Should I post my PUT method code to see it? – Jun 08 '17 at 02:45
where did you declared u.id? – Jun 08 '17 at 02:58
equate both object using angular.equals var index = $scope.userInfo.users.findIndex(u=> angular.equals(u,user)); – Rajniprabha Jun 08 '17 at 04:05
@alle I get an error (red scribbly line under => and after the second parenthesis) saying "expecting new line or semicolon" ?? – Jun 08 '17 at 11:35
if you are using e5 var index = $scope.userInfo.users.findIndex(function (u){ return angular.equals(u,user)}); – Rajniprabha Jun 09 '17 at 04:13

How to splice user correctly from scope in AngularJS?

2 Answers2