RecyclerView filter not filtering

Question

i'm trying to implement search filter into my RecyclerView, just as in this post

I've debugged it and it does filter the items as expected, but the list does not seems to change in the application. I.E.: i filter for a name and there are 7 results, and in the screen it is the original list.

My onCreateMenuOptions on activity is:

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.menu_main, menu);

    final MenuItem searchItem = menu.findItem(R.id.action_search);
    final SearchView searchView = (SearchView) MenuItemCompat.getActionView(searchItem);
    searchView.setOnQueryTextListener(new SearchView.OnQueryTextListener() {
        @Override public boolean onQueryTextSubmit(String filterString) {
            adapter.getFilter().filter(filterString);
            return true;
        }

        @Override
        public boolean onQueryTextChange(String newText) {
            return false;
        }
    });

    return true;
}

my adapter looks like this:

public class AnimeAdapter extends RecyclerView.Adapter<AnimeAdapter.AnimeViewHolder> implements INameableAdapter {
    private List<Anime> items;
    private List<Anime> filteredItems;
    private AnimeFilter animeFilter;

    final private Context context;

    @Override
    public Character getCharacterForElement(int element) {
        Character c = items.get(element).getTitle().charAt(0);
        if(Character.isDigit(c)){
            c = '#';
        }
        return c;
    }

    public static class AnimeViewHolder extends RecyclerView.ViewHolder {
        // Campos respectivos de un item
        final public ImageView img;
        final public TextView title;

        public AnimeViewHolder(View v) {
            super(v);
            img = (ImageView) v.findViewById(R.id.image);
            title = (TextView) v.findViewById(R.id.title);
        }
    }

    public AnimeAdapter(List<Anime> items, Context context) {
        this.items = items;
        this.context = context;
        this.filteredItems = new ArrayList<>();
    }

    @Override
    public int getItemCount() {
        return items.size();
    }

    @Override
    public AnimeViewHolder onCreateViewHolder(ViewGroup viewGroup, int i) {

        View v = LayoutInflater.from(viewGroup.getContext())
                .inflate(R.layout.anime_card, viewGroup, false);
        return new AnimeViewHolder(v);
    }

    @Override
    public void onBindViewHolder(AnimeViewHolder viewHolder, int i) {
        if (BuildConfig.DEBUG) {
            //This is made to check if the image cache is working as expected.
            Picasso.with(context).setIndicatorsEnabled(true);
            Picasso.with(context).setLoggingEnabled(true);
        }
        final int position = i;
        final ImageView imageView = viewHolder.img;
        Picasso.with(context)
                .load(items.get(i).getImageUrl())
                .into(imageView);
        viewHolder.title.setText(items.get(i).getTitle());

        viewHolder.itemView.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(final View v) {
                Intent intent = new Intent(context, TabActivity.class);
                Bundle b = new Bundle();
                b.putString("title", items.get(position).title);
                b.putString("playlist", items.get(position).playlist);
                imageView.buildDrawingCache();
                Bitmap image = imageView.getDrawingCache();
                b.putParcelable("imageBitmap", image);
                intent.putExtras(b);

                v.getContext().startActivity(intent);
            }
        });
    }

    public Filter getFilter() {
        if(animeFilter == null)
            animeFilter = new AnimeFilter(this, items);
        return animeFilter;
    }

    private static class AnimeFilter extends Filter {

        private final AnimeAdapter adapter;

        private final List<Anime> originalList;

        private final List<Anime> filteredList;

        private AnimeFilter(AnimeAdapter adapter, List<Anime> originalList) {
            super();
            this.adapter = adapter;
            this.originalList = new LinkedList<>(originalList);
            this.filteredList = new ArrayList<>();
        }

        @Override
        protected FilterResults performFiltering(CharSequence constraint) {
            filteredList.clear();
            final FilterResults results = new FilterResults();

            if (constraint.length() == 0) {
                filteredList.addAll(originalList);
            } else {
                final String filterPattern = constraint.toString().toLowerCase().trim();

                for (final Anime anime : originalList) {
                    if (anime.getTitle().toLowerCase().contains(filterPattern)) {
                        filteredList.add(anime);
                    }
                }
            }
            results.values = filteredList;
            results.count = filteredList.size();
            return results;
        }

        @Override
        protected void publishResults(CharSequence constraint, FilterResults results) {
            adapter.filteredItems.clear();
            adapter.filteredItems.addAll((ArrayList<Anime>) results.values);
            adapter.notifyDataSetChanged();
        }
    }
}

What i'm forgetting here?

Thanks in advance!

Can you put all codes of your adapter? – coder Jun 09 '17 at 18:20 — coder, Jun 09 '17 at 18:20
@ramineftekhari done, edited – emboole Jun 09 '17 at 18:23 — emboole, Jun 09 '17 at 18:23

score 3 · Accepted Answer · answered Jun 09 '17 at 18:41

I do some changes to your code.

Check this:

public class AnimeAdapter extends RecyclerView.Adapter<AnimeAdapter.AnimeViewHolder> implements INameableAdapter {
private List<Anime> items;
private List<Anime> filteredItems;
private AnimeFilter animeFilter;

final private Context context;

@Override
public Character getCharacterForElement(int element) {
    Character c = items.get(element).getTitle().charAt(0);
    if(Character.isDigit(c)){
        c = '#';
    }
    return c;
}

public static class AnimeViewHolder extends RecyclerView.ViewHolder {
    // Campos respectivos de un item
    final public ImageView img;
    final public TextView title;

    public AnimeViewHolder(View v) {
        super(v);
        img = (ImageView) v.findViewById(R.id.image);
        title = (TextView) v.findViewById(R.id.title);
    }
}

public AnimeAdapter(List<Anime> items, Context context) {
    this.items = items;
    this.context = context;
    this.filteredItems = new ArrayList<>();
    // we copy the original list to the filter list and use it for setting row values
    this.filteredItems.addAll(items);
}

@Override
public int getItemCount() {
    return filteredItems.size();//you must always return count of filtered rows
}

@Override
public AnimeViewHolder onCreateViewHolder(ViewGroup viewGroup, int i) {

    View v = LayoutInflater.from(viewGroup.getContext())
            .inflate(R.layout.anime_card, viewGroup, false);
    return new AnimeViewHolder(v);
}

@Override
public void onBindViewHolder(AnimeViewHolder viewHolder, int i) {
    if (BuildConfig.DEBUG) {
        //This is made to check if the image cache is working as expected.
        Picasso.with(context).setIndicatorsEnabled(true);
        Picasso.with(context).setLoggingEnabled(true);
    }
    final int position = i;
    final ImageView imageView = viewHolder.img;
    Picasso.with(context)
            .load(filteredItems.get(i).getImageUrl())//we you filteredItems instead of items
            .into(imageView);
    viewHolder.title.setText(filteredItems.get(i).getTitle());

    viewHolder.itemView.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(final View v) {
            Intent intent = new Intent(context, TabActivity.class);
            Bundle b = new Bundle();
            b.putString("title", filteredItems.get(position).title);
            b.putString("playlist", filteredItems.get(position).playlist);
            imageView.buildDrawingCache();
            Bitmap image = imageView.getDrawingCache();
            b.putParcelable("imageBitmap", image);
            intent.putExtras(b);

            v.getContext().startActivity(intent);
        }
    });
}

public Filter getFilter() {
    if(animeFilter == null)
        animeFilter = new AnimeFilter(this, items);
    return animeFilter;
}

private static class AnimeFilter extends Filter {

    private final AnimeAdapter adapter;

    private final List<Anime> originalList;

    private final List<Anime> filteredList;

    private AnimeFilter(AnimeAdapter adapter, List<Anime> originalList) {
        super();
        this.adapter = adapter;
        this.originalList = new LinkedList<>(originalList);
        this.filteredList = new ArrayList<>();
    }

    @Override
    protected FilterResults performFiltering(CharSequence constraint) {
        filteredList.clear();
        final FilterResults results = new FilterResults();

        if (constraint.length() == 0) {
            filteredList.addAll(originalList);
        } else {
            final String filterPattern = constraint.toString().toLowerCase().trim();

            for (final Anime anime : originalList) {
                if (anime.getTitle().toLowerCase().contains(filterPattern)) {
                    filteredList.add(anime);
                }
            }
        }
        results.values = filteredList;
        results.count = filteredList.size();
        return results;
    }

    @Override
    protected void publishResults(CharSequence constraint, FilterResults results) {
        adapter.filteredItems.clear();
        adapter.filteredItems.addAll((ArrayList<Anime>) results.values);
        adapter.notifyDataSetChanged();
    }
}

}

i copy your code and: - When load, screen is black. - When filters, it shows results. - when i clear the filter, it shows what it should on the beginning. I think it is something related to the load of items on my activity. It grabs an XML List from internet before i set my adapter (new AnimeAdapter(items, this);) — emboole, Jun 09 '17 at 19:39
i changed the constructor to this: public AnimeAdapter(List items, Context context) { this.items = items; this.context = context; //this.filteredItems = new ArrayList<>(); this.filteredItems = items; // we copy the original list to the filter list and use it for setting row values //this.filteredItems.addAll(items); } and it worked fine. Thanks man, i didn't expected this working by today. You are the best! — emboole, Jun 09 '17 at 20:00

score 2 · Answer 2 · answered Jun 09 '17 at 18:44

2

The problem is that you populate your RecyclerView with the items from the items list instead of filteredItems. In your filter you only update the filteredItems list and notify the adapter that something has changed. But in fact the list that the adapter uses to populate the RecyclerView stays the same.

So change your adapter to always use the filtered list.

answered Jun 09 '17 at 18:44

Jakob Ulbrich

133
1
7

thanks your answer helped me to find the problem and trace back the code – Reem Aziz Sep 05 '18 at 09:07

RecyclerView filter not filtering

2 Answers2