Not able to change menu item color for light and dark theme

Question

I am trying to implement a light and dark theme for my app by following This blog

But in case of changing the menu items according to the theme, by following the above no menu icon is displayed only its string This is my attrs.xml code-

<?xml version="1.0" encoding="utf-8"?>
<resources>
<attr name="icon_favourite" format="reference" />
</resources>

This is my Light Theme Style

<item name="icon_favourite">@drawable/ic_liked_toolbar</item>

This is my Dark Theme Style

<item name="icon_favourite">@drawable/ic_liked_toolbar_white</item>

This is my menuitem -

<item xmlns:app="http://schemas.android.com/apk/res-auto"
    android:id="@+id/favourites"
    android:icon="?attrs/icon_favourite"
    android:title="@string/action_favourites" />

After applying all these my menu item's icon is not visible and only its string is visible

score -1 · Answer 1 · answered Jun 10 '17 at 21:28

-1

In the activity use method :

setTheme(Theme);

before calling

setContentView();

Hope this helps.

answered Jun 10 '17 at 21:28

Sarthak Gandhi

2,130
1
16
23

Actually even without switching the theme through setTheme, the menu items are shown as strings only. – Naimish Srivastava Jun 11 '17 at 06:35
Try this link https://stackoverflow.com/questions/32969172/how-to-display-menu-item-with-icon-and-text-in-appcompatactivity – Sarthak Gandhi Jun 11 '17 at 06:40
I got my code working. I forgot to make changes in styles.xml(v-23) while running it on marshmallow – Naimish Srivastava Jun 21 '17 at 22:09

Not able to change menu item color for light and dark theme

1 Answers1