Error "<-1> but was:<2147483647>". Tell me please, what's wrong with the code?

Question

Write a method that will withdraw money from a particular customer's account and return the balance on the account. If there is not enough money on the account, the method will return -1

The signature of the method - withdraw (String [] clients, int [] balances, String client, int amount)

    package Lesson5;

/**
 * Created by Ruslan on 12.06.2017.
 */
public class takeOffBalance {
    public static void main(String[] args) {
        String clients[] = {"John", "Pedro", "Valera", "Muchachos", "Vovan"};
        int [] balances = {1, 100, 3500, 222, 1234};
        System.out.println(withdraw(clients, balances, "Pedro", (int) 10000));
    }

    static int withdraw(String[] clients, int[] balances, String client, int amount) {

        int res = balances[findClient(clients, client)] - amount;
        return res >= 0 ? res : -1;

    }
    static int findClient (String [] clients, String client) {

        int clientIndex = 0;
        for (String name : clients) {
            if (name == client) {
                break;
            }
            clientIndex++;
        }
        return clientIndex;
    }


}

@ΦXocę웃Пepeúpaツ The code as provided wouldn't be affected by that. Reopening until we have more info. — shmosel, Jun 13 '17 at 07:08
@shmosel It is an excersise whats the point with a unit test withoout running regressions... — patrik, Jun 13 '17 at 07:09
@patrik The error message in the title looks like it's from a unit test. It's definitely not produced by the posted code. — shmosel, Jun 13 '17 at 07:09
@shmose so you mean the result of the the index variable will not be affected by this: ***if (name == client)*** ???? — ΦXocę 웃 Пepeúpa ツ, Jun 13 '17 at 07:11
@ΦXocę웃Пepeúpaツ Not in this example because `"Pedro" == "Pedro"`. And if it was affecting the index variable, it would cause a AIOOBE. — shmosel, Jun 13 '17 at 07:13
@chuckskull What about it? There are many ways to arrive at 2147483647. Btw, `(int)(Integer.MAX_VALUE + 1L) == Integer.MIN_VALUE`. — shmosel, Jun 13 '17 at 07:35
OP should check for negative amounts and negative balance and return -1. — damjad, Jun 13 '17 at 07:37
It is a negative test. As the title suggests, it is being tested by some kind of testing framework. — damjad, Jun 13 '17 at 07:43
Possible duplicate of [What is a debugger and how can it help me diagnose problems?](https://stackoverflow.com/questions/25385173/what-is-a-debugger-and-how-can-it-help-me-diagnose-problems) — Raedwald, Jun 13 '17 at 08:35

score 0 · Answer 1 · answered Jun 13 '17 at 07:59

Please try the following. You should check for negative amount and balances. It looks like there is a negative test that is failing.

static int withdraw(String[] clients, int[] balances, String client, int amount) {

    int index = findClient(clients, client);
    if (index == -1) // no client found
        return -1;
    // Negative balance, negative amount and insufficient credit.
    if(balances[index] < 0 || amount < 0 || balances[index] - amount < 0)
        return  -1;

    return balances[index] - amount;

}

static int findClient (String [] clients, String client) {

    int clientIndex = 0;
    for (String name : clients) {
        if (null != name && name.equals(client)) {
            break;
        }
        clientIndex++;
    }
    return -1; //no client found
}

score 0 · Answer 2 · answered Jun 13 '17 at 08:46

0

You have to check for negative amounts, also there is no check for the case if account doesn't exist. You need to add all these validations to make it work properly.

answered Jun 13 '17 at 08:46

Bhanu Boppana

134
1
2
10

Error "<-1> but was:<2147483647>". Tell me please, what's wrong with the code?

2 Answers2