angular4 how to call a function in a external js

Question

I have a jscript which displays a log to the console:

x.js contains

function open() {
    console.log('this a function');
}

in index.html of my app

<script src="x.js"></script>

in my component

declare var xJS : any;;

@Component({
   selector: 'employerfile',
   templateUrl: './employerfile.component.html'
})

export class EmployerFileComponent
    .....
    openURL() {
       xJS.open();  
    }
}

in html

<a (click)="openURL()"> click </a>

When I execute this code, I get an exception@

Original exception: xJS is not defined

How can I call this external function?

score 6 · Accepted Answer · answered Jun 19 '17 at 06:34

6

Importing your file like this <script src="x.js"></script> will not work.

You have to import it in the following way:

import * as xJS from './x.js';

If it will not work, the alternative way is to use System.import:

declare var System: any; 

System.import('./x.js')
    .then(xJS => {
        xJS.open();
    });

You can check the following SO post.

answered Jun 19 '17 at 06:34

Hristo Eftimov

13,845
13
50
77

i have this error error_handler.js:50 EXCEPTION: Uncaught (in promise): TypeError: xJS.open is not a function – Florence Jun 19 '17 at 06:48
1

Can you make your external file as a module and to export your function: `export default function open(){ .... }` – Hristo Eftimov Jun 19 '17 at 06:56
I have the same issue, but the difference is the js I am including, is in the website and not local `https://chggtt.gt/Critgtek/cfr.cerfritek.js` so any solution for this ? – Ghizlane Lotfi May 31 '18 at 12:12
@GhizlaneLotfi I have never faced with an issue with an external link. Maybe this post can help you https://stackoverflow.com/q/34607252/2765346 Good luck :) – Hristo Eftimov May 31 '18 at 12:16

Karan Hudia · Answer 2 · 2017-06-19T07:13:33.493

5

You have to declare the name of the function you want to use in your angular component, as-

declare var open: any;

This basically tells the compiler that open exists somewhere, which will be then found in your js file.

Also, to use the above method in your component, you will have to use this syntax-

anyCustomMethodName/anyLifeCycleMethod() {
    new open();
}

edited Jun 19 '17 at 07:13

answered Jun 19 '17 at 07:00

Karan Hudia

553
3
19

1

what if you want to store the return value from the open() function? – Rich Jan 09 '18 at 10:57
When I tried your answer, I got "Modifiers can'tappear here" error. – Vladimir Despotovic Sep 22 '18 at 16:36
What worked for me is I put let open: any; and then ignore the lintrule to put const , instead of let. Keep it as let. Without the 'declare' word. – Vladimir Despotovic Sep 22 '18 at 16:42

score 1 · Answer 3 · answered Jun 19 '17 at 06:15

1

You should first import it like this:

import * as xJS from 'xJS';

answered Jun 19 '17 at 06:15

borkovski

938
8
12

1

I have this compile error ERROR in C:/....app.component.ts (15,28): File 'C:/....js/x.js' is not a module. – Florence Jun 19 '17 at 06:36

score 1 · Answer 4 · answered Sep 17 '18 at 17:23

If your x.js file is not on your local machine or hosted on CDN or it is third-party library then you can't import it in above ways. Even System.import is deprecated.

You can add your js file into index.html and call its functions using window global object as we do earlier.

angular4 how to call a function in a external js

4 Answers4

Linked