How can i reudce the number if if statments to 2

Question

how do I reduce the number of if statements in this code

for (int i = 1; i < number;i++)
{

    if ( i % 3 == 0 && i % 5 != 0)
    {
        Console.WriteLine(i + " Fizz");
    }
    else if (i % 5 == 0 && i % 3 != 0)
    {
        Console.WriteLine(i + " Buzz");
    }
    else if(i % 3 == 0 && i % 5 == 0)
    {
        Console.WriteLine(i + " FizzBuzz");
    }

    else
    {
        Console.WriteLine(i);
    }
}

It would be great if you [format your code first](https://stackoverflow.com/posts/44653219/edit) — ΦXocę 웃 Пepeúpa ツ, Jun 20 '17 at 12:37
There are plenty of example code samples for fizzbuzz solutions, I'd suggest you take a look at them. Also, [codereview.se] — Sayse, Jun 20 '17 at 12:38
[Writing FizzBuzz c#](https://stackoverflow.com/q/11764539/1324033) — Sayse, Jun 20 '17 at 12:40
this sounds a lot like an interview question... what have you considered? — Marc Gravell, Jun 20 '17 at 12:40
you can't reduce number of if statements but you can use switch statement instead. — Bhuban Shrestha, Jun 20 '17 at 12:41

score 2 · Answer 1 · answered Jun 20 '17 at 12:42

2

You could do the following:

for (int i = 1; i < number;i++)
{
    Console.WriteLine(string.Format("{0} {1}{2}", i, i % 3 == 0 ? "Fizz":"", i % 5 == 0 ? "Buzz":"");
}

And use no if ;-)

answered Jun 20 '17 at 12:42

Romano Zumbé

7,893
4
33
55

Rafalon · Answer 2 · 2017-06-20T13:00:56.550

for (int i = 1; i < number;i++)
{
    string result = i + " ";
    if ( i % 3 == 0)
    {
        result += "Fizz";
    }
    if (i % 5 == 0)
    {
        result += "Buzz";
    }
    Console.WriteLine(result);
}

This would display for example 1_, 3 Fizz, 5 Buzz, 15 FizzBuzz.

See the javascript equivalent code snippet below :

var number = 20;
for (var i = 1; i < number;i++)
{
    var result = i + " ";
    if (i % 3 == 0)
    {
        result += "Fizz";
    }
    if (i % 5 == 0)
    {
        result += "Buzz";
    }
    document.write(result+"<br>");
}

Tim Schmelter · Answer 3 · 2017-06-20T13:19:46.600

Variables and the conditional operator can help to make code more readable:

for (int i = 1; i < number;i++)
{
    bool isMod3 = i % 3 == 0;
    bool isMod5 = i % 5 == 0;
    string fizz = isMod3 ? "Fizz" : "";
    string buzz = isMod5 ? "Buzz" : "";
    string result = $"{i} {fizz}{buzz}";
    Console.WriteLine(result);
}

Here's another approach that works with even more values(theoretically umlimited):

var modDict = new Dictionary<int, string> { { 3, "Fizz" }, { 5, "Buzz" } };
for (int i = 1; i < number; i++)
{
    string text = string.Join("", modDict.Select(kv => i % kv.Key == 0 ? kv.Value : ""));
    Console.WriteLine(i + " " + text);
}

score 0 · Answer 4 · answered Jun 20 '17 at 12:40

0

you can try conditional operators.

(i % 3 == 0)
? (i % 5 == 0)
  ? Console.WriteLine(i + " FizzBuzz")
  : Console.WriteLine(i + " Fizz");
: (i % 5 == 0)
  ? Console.WriteLine(i + " Buzz");
  : Console.WriteLine(i);

answered Jun 20 '17 at 12:40

praty

535
2
9

Peter · Answer 5 · 2017-06-20T12:52:37.290

0

  string output = i % 3 == 0
                    ? ( i % 5 != 0 ? $"{i} Fizz" : $"{i} FizzBuzz" )
                    : i % 5 == 0 && i % 3 != 0
                        ? $"{i} Buzz"
                        : i.ToString();
  Console.WriteLine( output );

edited Jun 20 '17 at 12:52

answered Jun 20 '17 at 12:42

Peter

76
7

score 0 · Answer 6 · answered Jun 20 '17 at 12:44

0

Try:

string str;
for (int i = 1; i < number; i++)
{
    str = i + " ";
    if (i % 3 == 0)
        str += "Fizz";
    if (i % 5 == 0)
        str += "Buzz";

    Console.WriteLine(str.Trim());
}

answered Jun 20 '17 at 12:44

Pablo notPicasso

3,031
3
17
22

score 0 · Answer 7 · answered Jun 20 '17 at 12:52

We can do like below, but it is not good for readability

for (int i = 1; i < number; i++)
        {
            var x = i % 3 == 0;
            var y = i % 5 == 0;

            string istr = i.ToString();
            string a = x ? (y ? istr + " FizzBuzz"
                                : istr + " Fizz")
                          : (y ? istr + " Buzz"
                                : istr);
            Console.WriteLine(a);
        }

How can i reudce the number if if statments to 2

7 Answers7