Searching for elegant if

Question

Is there more elegant way for this if?

   if (err.code === 'CONFLICT-GROUP-GENERAL' ||
    err.code === 'CONFLICT-USER-GENERAL' ||
    err.code === 'CONFLICT-FORM-GENERAL' ||
    err.code === 'CONFLICT-PROJECT-GENERAL' ||
    err.code === 'CONFLICT-TEMPLATE-GENERAL') {}

The correct solution depends a bit on what's between the `{}`. — Jordan Running, Jun 23 '17 at 16:29
I'd use a [switch](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch). — James, Jun 23 '17 at 16:47

score 6 · Answer 1 · answered Jun 23 '17 at 16:31

6

I would be better off with an array with all the codes and use indexOf to check if it's greater than -1:

if (['CONFLICT-GROUP-GENERAL', 'CONFLICT-USER-GENERAL', 'CONFLICT-FORM-GENERAL', 'CONFLICT-PROJECT-GENERAL', 'CONFLICT-TEMPLATE-GENERAL'].indexOf(err.code) > -1) {
}

answered Jun 23 '17 at 16:31

Praveen Kumar Purushothaman

164,888
24
203
252

2

or `includes()` – Pranav C Balan Jun 23 '17 at 16:31
@PranavCBalan Isn't that unsupported in old browsers? – Praveen Kumar Purushothaman Jun 23 '17 at 16:31
1

anyways for new browsers ;) – Pranav C Balan Jun 23 '17 at 16:32

Bruno Peres · Accepted Answer · 2017-06-23T17:28:53.270

This trick seems to me more elegant (using an array and indexOf):

var conflicts = ['CONFLICT-GROUP-GENERAL',
                    'CONFLICT-USER-GENERAL',
                    'CONFLICT-FORM-GENERAL',
                    'CONFLICT-PROJECT-GENERAL',
                    'CONFLICT-TEMPLATE-GENERAL'];

if (conflicts.indexOf(err.code) !== -1) {
    doSomething();   
}

If you are using ES7 then you can use includes() instead of indexOf. This will be more "expressive":

var conflicts = ['CONFLICT-GROUP-GENERAL',
                    'CONFLICT-USER-GENERAL',
                    'CONFLICT-FORM-GENERAL',
                    'CONFLICT-PROJECT-GENERAL',
                    'CONFLICT-TEMPLATE-GENERAL'];

if (conflicts.inclues(err.code)) {
    doSomething();
}

Note that includes() will not be suported by all browsers.

EDIT:

Another alternative: Using a switch. This way:

switch (err.code) {
    case 'CONFLICT-GROUP-GENERAL',:
    case 'CONFLICT-USER-GENERAL',:
    case 'CONFLICT-FORM-GENERAL',:
    case 'CONFLICT-PROJECT-GENERAL',:
    case 'CONFLICT-TEMPLATE-GENERAL':
        doSomething();
        break;
}

The code above will execute the doSomething() function when err.code is equal to one of specified strings in each case.

Searching for elegant if

2 Answers2