If-statement inside foreach, the statement is not applying

Question

I'm processing a json from an url and showing some data. The problem is that I just want to display two accounts with certain id's but when I execute the following code is echoing the name of each account and not selecting the ones I choosen in the if-statement.

foreach ($data as $row) {

    $id = $row->id;
    $account = $row->account;
    $time = date("Y-m-d H:i:s");

    if ($id = 100) {echo $account;}
    elseif ($id = 120) {echo $account;}
    else {}

}

The Json is like

{"id":120,"Name":"Companytest"},
{"id":121,"Name":"BensonTillis"},
{"id":123,"Name":"JSBrothers"}

Thank you.

faffaffaff · Accepted Answer · 2017-06-28T21:24:38.023

3

You need to use == instead of = in your if statements.

When you are comparing numbers you need to use "==" as it is one of the comparison operators http://php.net/manual/en/language.operators.comparison.php

The single "=" is an assigment operator and sets $id to the value on the right hand side. http://php.net/manual/en/language.operators.assignment.php

edited Jun 28 '17 at 21:24

answered Jun 28 '17 at 21:21

faffaffaff

3,429
16
27

While it's correct (and the question is a duplicate), you should elaborate *why* double equality is needed over single equality, not just "You need it". – Qirel Jun 28 '17 at 21:23
@Qirel OK, edited with an explanation of comparison and assignment operators. – faffaffaff Jun 28 '17 at 21:25
Thank you!!!!....newby mistake – Daniel Jun 28 '17 at 21:27

score 0 · Answer 2 · answered Jun 28 '17 at 21:24

0

You should use a double equals == instead of single = in your 'if' condition

answered Jun 28 '17 at 21:24

chrisjnr

36
6

score 0 · Answer 3 · answered Jun 28 '17 at 21:27

This is because you are actually assigning $id to be = to 100,

to fix that simply add a second = inside your if statment like so:

if ($id == 100) {echo $account;}

Also. I have learned to do my if statements like:

if (100 == $id) {echo $account;}

this simply prevents the possibility of assigning the variable and instead will cause:

syntax error, unexpected '='

which is easier to debug

If-statement inside foreach, the statement is not applying

3 Answers3