How to stop property onclick undefined

Question

I followed a tutorial to add a modal image on my website. https://www.w3schools.com/howto/howto_css_modal_images.asp

But as I have multiple images, i followed what this guy tell on this question Modal image galleries - multiple images

And it still doesn't work.

Here is my javascript: It tells me "Uncaught TypeError: Cannot set property 'onclick' of undefined" for my var "span"

var modal = document.getElementById('myModal');
var img = $('.myImg');
var modalImg = $("#img01");
var captionText = document.getElementById("caption");
$('.myImg').click(function(){
modal.style.display = "block";
var newSrc = this.src;
modalImg.attr('src', newSrc);
captionText.innerHTML = this.alt;
});
var span = document.getElementsByClassName("close")[0];
span.onclick = function() {
modal.style.display = "none";
}

And here is my html that i generate with a script :

<script id="mapListDetailTemplate" type="text/x-jQuery-tmpl">
<div class="result_item_detail">
<a href="#" class="map_details_close"><img src="src/close.png" alt="Close"></a>
<h3>${name}</h3>
<div class="result_item_detail_info">
    <div class="info">
        <ul class="list-unstyled">
            <li><b>Adresse</b>: ${address}</li>
        </ul>
    </div>
</div>
<div class="result_item_detail_info">
<h4>Description</h4>
${about}
</div>
<div class="result_item_detail_info">
<h4>Image</h4>
    <div class="slider_container">
        <div style="display: inline-block;">
              <img class="myImg" src="http://www.chinabuddhismencyclopedia.com/en/images/thumb/b/b8/Nature.jpg/240px-Nature.jpg" alt="Trolltunga, Norway" width="300" height="200"/>
        </div>
    </div>
</div>
<div class="result_item_detail_info">
<h4>Aujourdhui</h4>
    <div id="pano"> </div>
</div>
</div>
<div id="myModal" class="modal">
<span class="close" onclick="document.getElementById('myModal').style.display='none'">&times;</span>
<img class="modal-content" id="img01">
<div id="caption"></div>
</div>
</script>

And here is the CSS

/* Style the Image Used to Trigger the Modal */
.myImg {
border-radius: 5px;
cursor: pointer;
transition: 0.3s;
}

.myImg:hover {opacity: 0.7;}

/* The Modal (background) */
.modal {
display: none; /* Hidden by default */
position: fixed; /* Stay in place */
z-index: 1; /* Sit on top */
padding-top: 100px; /* Location of the box */
left: 0;
top: 0;
width: 100%; /* Full width */
height: 100%; /* Full height */
overflow: auto; /* Enable scroll if needed */
background-color: rgb(0,0,0); /* Fallback color */
background-color: rgba(0,0,0,0.9); /* Black w/ opacity */
}

/* Modal Content (Image) */
.modal-content {
margin: auto;
display: block;
width: 80%;
max-width: 700px;
}

/* Caption of Modal Image (Image Text) - Same Width as the Image */
#caption {
margin: auto;
display: block;
width: 80%;
max-width: 700px;
text-align: center;
color: #ccc;
padding: 10px 0;
height: 150px;
}

/* Add Animation - Zoom in the Modal */
.modal-content, #caption {
-webkit-animation-name: zoom;
-webkit-animation-duration: 0.6s;
animation-name: zoom;
animation-duration: 0.6s;
}

@-webkit-keyframes zoom {
from {-webkit-transform:scale(0)}
to {-webkit-transform:scale(1)}
}

@keyframes zoom {
from {transform:scale(0)}
to {transform:scale(1)}
}

/* The Close Button */
.close {
position: absolute;
top: 15px;
right: 35px;
color: #f1f1f1;
font-size: 40px;
font-weight: bold;
transition: 0.3s;
}

.close:hover,
.close:focus {
color: #bbb;
text-decoration: none;
cursor: pointer;
}

/* 100% Image Width on Smaller Screens */
@media only screen and (max-width: 700px){
.modal-content {
    width: 100%;
}
}

You know why I have this error? Is it because my html is into a script??

Is the modal, with the `.close` span loaded then the `span.onclick` is defined? It looks like you're adding the `onclick` to the `.close` span twice - inline and with `span.onclick`. The inline should be all you need. — Brett DeWoody, Jul 06 '17 at 09:48
Okay i have no longer this error message, but it still doesnt work >< Thank you Brett — Alexandre Roussel, Jul 06 '17 at 10:04
Any other errors? What do you mean it doesn't work? If you can share your CSS we'd have the complete code so we can help more. — Brett DeWoody, Jul 06 '17 at 10:05
I have no more errors in the console, i share the CSS by editing my post — Alexandre Roussel, Jul 06 '17 at 10:10
The code makes it appear like there's a modal in a modal. Is that right? — Brett DeWoody, Jul 06 '17 at 10:31

score 0 · Accepted Answer · answered Jul 06 '17 at 10:45

As mentioned in the comments, it appears the HTML structure is a modal in a modal, which might be an UX/UI issue but could be done. Ignoring that, here's a basic working example. A few changes from what you had.

the jQuery template script needs to be loaded since you're using a template
then .tmpl() needs to be called on the template, along with some data
the onClick needs to be added after the templates have been created

$(document).ready(function() {
  var items = [
    {name: 'Name 1', address: 'Address 1', about: 'About 1'}
  ];
  
  // Render the item using the template
  $("#mapListDetailTemplate").tmpl(items).appendTo("#container");

  var modal = document.getElementById('myModal');
  var modalImg = $("#img01");
  var captionText = document.getElementById("caption");
  $('.myImg').on('click', function() {
    modal.style.display = "block";
    var newSrc = this.src;
    modalImg.attr('src', newSrc);
    captionText.innerHTML = this.alt;
  });
  
  
});

/* Style the Image Used to Trigger the Modal */

.myImg {
  border-radius: 5px;
  cursor: pointer;
  transition: 0.3s;
}

.myImg:hover {
  opacity: 0.7;
}


/* The Modal (background) */

.modal {
  display: none;
  /* Hidden by default */
  position: fixed;
  /* Stay in place */
  z-index: 1;
  /* Sit on top */
  padding-top: 100px;
  /* Location of the box */
  left: 0;
  top: 0;
  width: 100%;
  /* Full width */
  height: 100%;
  /* Full height */
  overflow: auto;
  /* Enable scroll if needed */
  background-color: rgb(0, 0, 0);
  /* Fallback color */
  background-color: rgba(0, 0, 0, 0.9);
  /* Black w/ opacity */
}


/* Modal Content (Image) */

.modal-content {
  margin: auto;
  display: block;
  width: 80%;
  max-width: 700px;
}


/* Caption of Modal Image (Image Text) - Same Width as the Image */

#caption {
  margin: auto;
  display: block;
  width: 80%;
  max-width: 700px;
  text-align: center;
  color: #ccc;
  padding: 10px 0;
  height: 150px;
}


/* Add Animation - Zoom in the Modal */

.modal-content,
#caption {
  -webkit-animation-name: zoom;
  -webkit-animation-duration: 0.6s;
  animation-name: zoom;
  animation-duration: 0.6s;
}

@-webkit-keyframes zoom {
  from {
    -webkit-transform: scale(0)
  }
  to {
    -webkit-transform: scale(1)
  }
}

@keyframes zoom {
  from {
    transform: scale(0)
  }
  to {
    transform: scale(1)
  }
}


/* The Close Button */

.close {
  position: absolute;
  top: 15px;
  right: 35px;
  color: #f1f1f1;
  font-size: 40px;
  font-weight: bold;
  transition: 0.3s;
}

.close:hover,
.close:focus {
  color: #bbb;
  text-decoration: none;
  cursor: pointer;
}


/* 100% Image Width on Smaller Screens */

@media only screen and (max-width: 700px) {
  .modal-content {
    width: 100%;
  }
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<script src="https://ajax.microsoft.com/ajax/jquery.templates/beta1/jquery.tmpl.min.js"></script>
<div id="container"></div>
<script id="mapListDetailTemplate" type="text/x-jQuery-tmpl">
  <div class="result_item_detail">
    <a href="#" class="map_details_close"><img src="src/close.png" alt="Close"></a>
    <h3>${name}</h3>
    <div class="result_item_detail_info">
      <div class="info">
        <ul class="list-unstyled">
          <li><b>Adresse</b>: ${address}</li>
        </ul>
      </div>
    </div>
    <div class="result_item_detail_info">
      <h4>Description</h4>
      ${about}
    </div>
    <div class="result_item_detail_info">
      <h4>Image</h4>
      <div class="slider_container">
        <div style="display: inline-block;">
          <img class="myImg" src="http://www.chinabuddhismencyclopedia.com/en/images/thumb/b/b8/Nature.jpg/240px-Nature.jpg" alt="Trolltunga, Norway" width="300" height="200" />
        </div>
      </div>
    </div>
    <div class="result_item_detail_info">
      <h4>Aujourdhui</h4>
      <div id="pano"> </div>
    </div>
  </div>
  <div id="myModal" class="modal">
    <span class="close" onclick="document.getElementById('myModal').style.display='none'">&times;</span>
    <img class="modal-content" id="img01">
    <div id="caption"></div>
  </div>
</script>

Thanks a lot Brett :) – Alexandre Roussel Jul 06 '17 at 10:47 — Alexandre Roussel, Jul 06 '17 at 10:47

How to stop property onclick undefined

1 Answers1