Subsequent HTML not being displayed after PHP call

Question

I am relatively new to PHP programming. I am building a small crud app (to-do list) to be exact for practice. I am working on fleshing out the UI and testing how information displays from my database on the page.

When a user logs in, they are shown a table of all the items they have saved.

table listing items

  <div class="container">
    <table class="table">
      <tr>
        <th>Completed</th>
        <th>Description</th>
        <th>Actions</th>
      </tr>
      <tr>
        <td colspan="3"></td>
      </tr>
      <?php
      $document_get = mysql_query("SELECT * FROM todolist WHERE user_id='$user_id' ORDER BY id DESC");
      while($match_value = mysql_fetch_array($document_get)) {
      ?>
      <tr>
        <td>
          Hi
        </td>
      </tr>
    </table>
    <?php
    }
    ?>
  </div>

php call to display list item

      <?php
      $document_get = mysql_query("SELECT * FROM todolist WHERE user_id='$user_id' ORDER BY id DESC");
      while($match_value = mysql_fetch_array($document_get)) {
      ?>

Anything under this PHP request does not show up for some reason. I have looked at other posts where people have mentioned the same thing but I did not see anything specific that matched my issue per say.

Several things: 1. This code is vulnerable to [SQL Injections](https://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php/60496#60496). This is bad. Don't use `mysql_` functions, they are deprecated. If you're on PHP 7, they are removed and this is the problem. 2. Check [this](https://stackoverflow.com/questions/12769982/reference-what-does-this-error-mean-in-php) to debug your problem. Are you sure the last `` is not being displayed? If it is not, you have a syntax error. If it is, there is simply not data to display. — Imanuel, Jul 07 '17 at 20:52
Thanks for the comment. The example that I was starting with did in fact run on PHP 5.6. I noticed quite a few things that did not look correct when looking at newer documentation. I am changing things around so I will be using PHP 7 instead. The last DIV was not being displayed i.e., the DIV that simply says 'Hi' — Marty Lavender, Jul 07 '17 at 22:29

score 0 · Answer 1 · answered Jul 07 '17 at 20:54

mysql_fetch_array returns an array. The structure of your while statement will not have the outcome that you desire. The while loop will continue to be true forever because nothing is changing in the while condition.

This should have the effect closer to what you are looking for:

$document_get = mysql_query("SELECT * FROM todolist WHERE user_id='$user_id' ORDER BY id DESC");
$match_value = mysql_fetch_array($document_get);
foreach ($match_value as $value){
    //Do something
}

As a side note - I would highly recommend using PDO and not putting php in-line with html. Tutorial here: https://phpdelusions.net/pdo

If you use PDO your loop would look more like this:

while($row = $st->fetch(PDO::FETCH_ASSOC)){
    //Do something
}

the while is not the problem. actually it is required to retrieve the result row by row (same as you suggest with PDO). mysql_fetch_array() just get's the row's columns as associative and not as numerical array. — masterfloda, Jul 07 '17 at 21:42

Lew Perren · Answer 2 · 2017-07-07T21:22:32.927

enter code here  <?php
  $document_get = mysql_query("SELECT * FROM todolist WHERE user_id='$user_id' ORDER BY id DESC");
  while($match_value = mysql_fetch_array($document_get)) {
  echo "
  <tr>
    <td>
      Hi
    </td>
  </tr>

";

}
echo    " </table>";
?>

Do the whole thing in php using echo to display the table elemts and Hi. Remove the extra php tags so loop and echo all php. Also look at security issues mentioned in comments. By the way, I moved the table end tag outside loop after reading comment below the question.

score 0 · Accepted Answer · answered Jul 07 '17 at 21:00

0

Try to alter your query from:

$document_get = mysql_query("SELECT * FROM todolist WHERE user_id='$user_id' ORDER BY id DESC");

to

$document_get = mysql_query("SELECT * FROM todolist WHERE user_id='".$user_id."' ORDER BY id DESC");

answered Jul 07 '17 at 21:00

Just_Do_It

821
7
20

this will not solve the problem. You can use variables in double quoted strings. – masterfloda Jul 07 '17 at 21:39

Subsequent HTML not being displayed after PHP call

3 Answers3