i want that when the give input in employee_address is Banglore and salary is more than 25000,i get all the details of employee

Question

I have written this code but when i am giving input Banglore and 26000 it is not returning desired condition.

I want to get all employee details when the employee address is Banglore and salary is more than 25000.

import java.util.Scanner;

public class ContactManager {

    public static void main(String[] args) {
        // TODO Auto-generated method stub

        @SuppressWarnings("resource")
        Scanner s=new Scanner(System.in);

        int employee_id;
        String employee_name;
        String address;
        int mobile;
        int salary;
        String q;

        System.out.println("empolyee_id:");
        employee_id=s.nextInt();

        System.out.println("employee_name:");
        employee_name=s.next();

        System.out.println("mobile:");
        mobile=s.nextInt();

        System.out.println("address:");
        address=s.next();

        System.out.println("salary:");
        salary=s.nextInt();

        q = "Banglore";

        if(address==q && salary > 25000) {
            System.out.println(employee_name);
            System.out.println(employee_id);
            System.out.println(address);
            System.out.println(mobile);
            System.out.println(salary);
        } else {
            System.out.println("Sorry");
        }
    }
}

In Java, the == operator checks equality by reference. In this case, q and address won't match. You want to use the "equals" method: address.equals(q). Also consider converting the strings to upper or lowercase before comparison. — John Scattergood, Jul 08 '17 at 17:09

Ihor Dobrovolskyi · Answer 1 · 2017-07-08T16:53:25.150

0

You must compare strings using equals() method.

== tests for reference equality (whether they are the same object).

.equals() tests for value equality (whether they are logically "equal").

Variable String address and String q = "Banglore" are not the same objects, so address == q returns false.

Replace if(address==q && salary>25000) on if(q.equals(address) && salary>25000), and it will work perfectly.

edited Jul 08 '17 at 16:53

answered Jul 08 '17 at 16:44

Ihor Dobrovolskyi

1,241
9
19

if i will create a object and this string value in that and then use that object with address using == will it work. – hta72 Jul 08 '17 at 16:48
What object? An instance of Object class or what? – Ihor Dobrovolskyi Jul 08 '17 at 16:49
instance of class object ob – hta72 Jul 08 '17 at 16:52
If `q` and `ob.address` have the same reference, `ob.address == q` returns `true`. – Ihor Dobrovolskyi Jul 08 '17 at 16:56
The easiest way to compare 2 strings is using the code like this `q.equals(address)`. – Ihor Dobrovolskyi Jul 08 '17 at 16:58
@hta72 don't *ever* compare the *content* of two strings with `==`: **always** use `equals`. Don't come with complicated "what if I do this" scenerio's - there is no reason ever to compare the *content* of strings with `==`. – Erwin Bolwidt Jul 08 '17 at 17:09

score 0 · Answer 2 · answered Jul 08 '17 at 17:00

0

Instead of if(address==q && salary>25000) you can use if (address.equals(q) && salary > 25000) it should work then.

answered Jul 08 '17 at 17:00

Shahbaz

141
2
7

I've already written about that. – Ihor Dobrovolskyi Jul 08 '17 at 17:01

i want that when the give input in employee_address is Banglore and salary is more than 25000,i get all the details of employee

2 Answers2