Why does this code not reverse the name given as a value of a variable?

Question

  string myName = "Angel Hadzhiev";
        char[] CharName = myName.ToCharArray();
        Array.Reverse(CharName);
        foreach (char name in myName)
        {
            Console.WriteLine(name);
        }

        Console.ReadLine();

The problem is that the given name(Angel Hadzhiev) is not reversed when I run the Console Application. The output is this - http://prntscr.com/fvbis1

You can join an array of characters back into a string with the String constructor: `string newString = new String(CharName);` — spender, Jul 13 '17 at 18:17

score 6 · Accepted Answer · answered Jul 13 '17 at 18:17

6

You reverse the characters in CharName, but you write to the Console the characters in myName (which isn't reversed, and contains the original order). Your loop should have looked like this:

    foreach (char name in CharName)
    {
        Console.WriteLine(name);
    }

answered Jul 13 '17 at 18:17

hatchet - done with SOverflow

15,919
5
47
57

Thank you. It was successful but could you tell my why it is displayed vertically but not horizontally ? – Ангел Хаджиев Jul 13 '17 at 18:31
Because you are using `WriteLine`, which appends new line character(s) to the output of each character. If you used `Write`, it should out put horizontally, as that will output only the characters, without adding the line breaks. – hatchet - done with SOverflow Jul 13 '17 at 18:34
I got it. Thank you a lot. – Ангел Хаджиев Jul 13 '17 at 18:38
You should mention that `Array.Reverse` [does not reverse strings](https://stackoverflow.com/a/15111719/22437). – Dour High Arch Jul 13 '17 at 19:58
@DourHighArch - if you're talking about the special case considered by the second answer to that question, then yes, the OP's approach will have problems with some potential strings. – hatchet - done with SOverflow Jul 13 '17 at 20:19

score 0 · Answer 2 · edited Jul 13 '17 at 18:33

You made a simple mistake that in foeach loop instead of reversed array you are taking old array.

Please check this link for example

public static void Main(string[] args)
    {
        string myName = "Angel Hadzhiev";
        char[] CharName = myName.ToCharArray();
        Array.Reverse(CharName);
        foreach (char name in CharName)
        {
            Console.WriteLine(name);
        }
    }

Why does this code not reverse the name given as a value of a variable?

2 Answers2