Using Memoizee with node.js

Question

I want to use Memoizee on my node.js backend, to speed up the requests.

But for some reason, I can't get it to work like I want to. I have a route, that waits for the callback of another method, but no matter how long I save the result in cache, it runs the whole method every time.

What am I doing wrong?

Here is an example of my implementation.

var memoize = require('memoizee');

module.exports = function (app) {

app.route('/someurl/:user_id')
    .get(function (req, res) {

        var user_id = req.params.user_id;

        memoized(user_id, function (result) {      
            res.send(result)
        })
    });
};

var doWork = memoize(function(user_id, done) {
    //Handling a lot of data - takes about 10-15 seconds
    done(index);
});

var memoized = memoize(doWork, {maxAge: 300000});

to memorizeing you just hash, do it yourself. or provide the data structure you are dealing with. — Rick, Jul 14 '17 at 17:22
For one, don't call `memoize` twice on the same function. And use promises instead of that callback, or at least [tell it](https://www.npmjs.com/package/memoizee#nodejs-callback-style-functions) that you're going to pass a new different callback every time! — Bergi, Jul 14 '17 at 21:12

score 1 · Answer 1 · answered Jul 18 '17 at 13:00

There are two issues:

As there are two function parameters, memoization memoizes against those two.
It's likely that done callback on every call is different, hence you see function re-run every time.
How to fix it? Firstly you can limit memoization scope to just first parameter by passing { length: 1 } in options. Secondly I have a notion it's an async function that you try to memoize, for that it would be better to rely on either async or promise configuration options in memoizee (see it's documentation)
As @Bergi pointed you try to memoize already memoized function. Second memoization (one with maxAge) has no effect, as memoization internally detects what you're trying to do, and ignores second call. There should be just one memoizee wrap (options can be combined, there's no problem with that).

Using Memoizee with node.js

1 Answers1