32

With JPA 2 Criteria Join method I can do the following:

    //Join Example (default inner join)
    int age = 25;
    CriteriaBuilder cb = entityManager.getCriteriaBuilder();
    CriteriaQuery<Team> c = cb.createQuery(Team.class);
    Root<Team> t = c.from(Team.class);
    Join<Team, Player> p = t.join(Team_.players);
    c.select(t).where(cb.equal(p.get(Player_.age), age));
    TypedQuery<Team> q = entityManager.createQuery(c);
    List<Team> result = q.getResultList();

How can I do the same with fetch method, I expected that Fetch interface had get method for path navigation but it doesn't:

    //Fetch Join Example

    int age = 25;
    CriteriaBuilder cb = entityManager.getCriteriaBuilder();
    CriteriaQuery<Team> cq = cb.createQuery(Team.class);
    Root<Team> t = cq.from(Team.class);
    Fetch<Team,Player> p = t.fetch(Team_.players);
    cq.where(cb.equal(p.get(Player_.age), age)); //This leads to compilation error there is no such method get in interface Fetch
    TypedQuery<Team> q = entityManager.createQuery(cq);
    List<Team> result = q.getResultList();

According to Hiberante Documentation fetch returns a Join object which is wrong. http://docs.jboss.org/hibernate/stable/entitymanager/reference/en/html/querycriteria.html#querycriteria-from-fetch

Alfredo Osorio
  • 11,297
  • 12
  • 56
  • 84

7 Answers7

23

Agree with you about that method, and the fact that you would expect it to allow what you say. Another option would be

Join<Team, Player> p = t.join(Team_.players);
t.fetch(Team_.players);
c.select(t).where(cb.equal(p.get(Player_.age), age));

i.e do a join(), add a fetch() for it, and then make use of the join. This is illogical and only adds to the inelegant nature of JPA Criteria, but anyway, ought to be a workaround

Simulant
  • 19,190
  • 8
  • 63
  • 98
DataNucleus
  • 15,497
  • 3
  • 32
  • 37
  • 12
    Apparently it works but it leads to joining multiple times: Hibernate: select ... from Team team0_ inner join Player players1_ on team0_.id=players1_.team_id inner join Person players1_1_ on players1_.id=players1_1_.id inner join Player players2_ on team0_.id=players2_.team_id inner join Person players2_1_ on players2_.id=players2_1_.id where players1_1_.age=25 – Alfredo Osorio Dec 22 '10 at 19:45
  • 3
    See also http://blogs.sun.com/ldemichiel/entry/jpa_next_thinking_about_the#comment-1291653518000 where the problem is mentioned. Basically an API that isn't thought out – DataNucleus Dec 23 '10 at 08:54
  • 4
    This breaks when you do a `order by` and `distinct(true)` with `mssql` – Quincy Nov 08 '12 at 03:29
  • 2
    As Alfredo says, this does double join. – Stephan Jan 24 '17 at 14:19
  • 1
    the blogs.sun.com link above is done, it can be found on the wayback machine at https://web.archive.org/web/20110820095223/http://blogs.oracle.com:80/ldemichiel/entry/jpa_next_thinking_about_the – Peter Sep 18 '17 at 11:38
10

It Works for me using Hibernate Provider.

//Join Example (default inner join)

    int age = 25;
    CriteriaBuilder cb = entityManager.getCriteriaBuilder();
    CriteriaQuery<Team> c = cb.createQuery(Team.class);
    Root<Team> t = c.from(Team.class);

    // Join<Team, Player> p = t.join(Team_.players); 
    Join<Team, Player> p = (Join<Team, Player>)t.fetch(Team_.players); 

    c.select(t).where(cb.equal(p.get(Player_.age), age));
    TypedQuery<Team> q = entityManager.createQuery(c);
    List<Team> result = q.getResultList();

Certainly, it could broken the portability, but in our case we have been using others hibernate's exclusive features.

*It is very strange because the hibernate documentation doesn't show this example.

To grasp it look at this interface.

/*
 * Hibernate, Relational Persistence for Idiomatic Java
 *
 * Copyright (c) 2010, Red Hat Inc. or third-party contributors as
 * indicated by the @author tags or express copyright attribution
 * statements applied by the authors.  All third-party contributions are
 * distributed under license by Red Hat Inc.
 *
 * This copyrighted material is made available to anyone wishing to use, modify,
 * copy, or redistribute it subject to the terms and conditions of the GNU
 * Lesser General Public License, as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
 * or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License
 * for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this distribution; if not, write to:
 * Free Software Foundation, Inc.
 * 51 Franklin Street, Fifth Floor
 * Boston, MA  02110-1301  USA
 */
package org.hibernate.ejb.criteria;

import javax.persistence.criteria.Fetch;
import javax.persistence.criteria.Join;

/**
 * Consolidates the {@link Join} and {@link Fetch} hierarchies since that is how we implement them.
 * This allows us to treat them polymorphically.
*
* @author Steve Ebersole
*/
public interface JoinImplementor<Z,X> extends Join<Z,X>, Fetch<Z,X>, FromImplementor<Z,X> {
    /**
     * {@inheritDoc}
     * <p/>
     * Refined return type
     */
    public JoinImplementor<Z,X> correlateTo(CriteriaSubqueryImpl subquery);
}
Eduardo Fabricio
  • 2,151
  • 2
  • 25
  • 32
  • 1
    Nice. As you said it is possible that this will make it not portable across other JPA vendors. – Alfredo Osorio Jun 28 '12 at 14:38
  • The cast didn't work for me, using WAS v8.0's OpenJPA 2.1.2-SNAPSHOT. :-( – Chris Harris Apr 30 '14 at 21:09
  • This cast doesn't work. What Hibernate version are you using? – svlada Apr 22 '15 at 07:12
  • In this specific case i was using : hibernate 3.6.9.Final, i will test it with a new version and comment here. what version are u using @amgohan ? – Eduardo Fabricio Apr 23 '15 at 13:21
  • Works great but I have nullpointer when getting fields in second levels (child tables) so I have to use String names for fields instead of those in the metamodel, ¿Anybody with the same problem? – eduyayo Oct 27 '15 at 13:47
6

Beginning with JPA 2.1, dynamic entity graphs can be used for fetching in criteria queries, while using join() instead of fetch(). From the example in the question:

//Join Example (default inner join)
int age = 25;
CriteriaBuilder cb = entityManager.getCriteriaBuilder();
CriteriaQuery<Team> c = cb.createQuery(Team.class);
Root<Team> t = c.from(Team.class);
Join<Team, Player> p = t.join(Team_.players);
c.select(t).where(cb.equal(p.get(Player_.age), age));
TypedQuery<Team> q = entityManager.createQuery(c);
List<Team> result = q.getResultList();

If this:

TypedQuery<Team> q = entityManager.createQuery(c);

is replaced with this:

EntityGraph<Team> fetchGraph = getEntityManager().createEntityGraph(Team.class);
fetchGraph.addSubgraph(Team_.players);
TypedQuery<Team> q = entityManager.createQuery(c).setHint("javax.persistence.loadgraph", fetchGraph);

then all players will be eager fetched.

Darren Reimer
  • 741
  • 8
  • 9
5

All you have to do is the following:

1- Do Fetch. 2- Then, go over the path to where you want.

In your case:

int age = 25;
CriteriaBuilder cb = entityManager.getCriteriaBuilder();
CriteriaQuery<Team> cq = cb.createQuery(Team.class);
Root<Team> t = cq.from(Team.class);
Fetch<Team,Player> p = t.fetch(Team_.players);
cq.where(cb.equal(t.get("player").get("age"), age)); 
Haytham Salhi
  • 91
  • 1
  • 4
  • 2
    `t.get("player")` doesn't exist, as Team entity has only players attribute (also in our example is Team_.players). So I'll get `java.lang.IllegalArgumentException: Unable to resolve attribute [player] against path` – myroch Apr 22 '20 at 11:00
2

I am using JPA 2.1 with Hibernate 4.3.7 and the below works for me well. It does not even look that ugly.

Join<Team,Player> p = (Join) t.fetch(Team_.players);
thegeko
  • 1,382
  • 1
  • 13
  • 18
0

ugly but:

Join<Team, Player> p=t.fetch(Team_.players);

will produce singel join with fetch in sql but is a ugly hack that works JBoss6.1 hibernate

Georgios Syngouroglou
  • 18,813
  • 9
  • 90
  • 92
Jernej
  • 121
  • 1
  • 2
0

I updated the Hibernate Version to "5.6.5.Final" and I think the problem is resolved.

Woo
  • 41
  • 3