Delete identical elements from string

Question

Got string, need to delete same words from there.

Here is my code. I tried to split string into array and then sort but it didn't work. It didn't even go through my if. I would like to hear your advice and maybe working code :)

  var str = "I wont go anywhere as soon as I wont go there";
    var array = str.split(" ");
    document.getElementsByTagName('p')[0].innerHTML = str;
    document.getElementsByTagName('p')[1].innerHTML = array;
    document.getElementsByTagName('button')[0].onclick = function () {
            for (var i = 0; i < array.length; i++) {
                if (array[i] == array[i + 1]) {
                    array.splice(i, 1);
                }
            }
            document.getElementsByTagName('p')[2].innerHTML = array;
        }

Possible duplicate of [Javascript how to remove text from a string](https://stackoverflow.com/questions/10398931/javascript-how-to-remove-text-from-a-string) — Gustavo Magalhães, Jul 17 '17 at 20:00

score 1 · Answer 1 · answered Jul 17 '17 at 20:14

1

If you like one-lines try this

var reducedString  = array.reduce(function(out, s) {
    return out.indexOf(s) == -1 ? out + ' ' + s : out;
},'').substring(1);

or in ES6

var reducedString = array.reduce( (out, s) => out.indexOf(s) == -1 ? out + ' ' + s : out);

answered Jul 17 '17 at 20:14

Jarek Kulikowski

1,399
8
9

I have no idea if this works, but +1 for ES6! – Mark Carpenter Jr Jul 17 '17 at 20:18
@MarkCarpenterJr thanks :), I recently discovered array.reduce(), saves a lot of space – Jarek Kulikowski Jul 17 '17 at 20:23

score 0 · Answer 2 · answered Jul 17 '17 at 19:57

You can use an ES6 Set with the spread syntax after splitting the sentance:

const str = "I wont go anywhere as soon as I wont go there";
const unique = [...new Set(str.split(' '))].join(' ');

console.log(unique);

In ES5 you can use Array#reduce with a dictionary object.

var str = "I wont go anywhere as soon as I wont go there";

var dict = Object.create(null); // creates an empty object, without inherited properties and methods
var unique = str.split(' ').reduce(function(arr, w) {
  if(!dict[w]) {
    arr.push(w);
    dict[w] = true;
  }
  
  return arr;
}, []).join(' ');

console.log(unique);

score 0 · Answer 3 · answered Jul 17 '17 at 19:58

0

You can just replace the substring you are searching for

var ret = "data-123".replace('data-','');
console.log(ret);

answered Jul 17 '17 at 19:58

Gustavo Magalhães

330
3
17

score 0 · Accepted Answer · answered Jul 17 '17 at 20:00

0

Your problem is that you don't check every array element with every other array element.

Your code:

for (var i = 0; i < array.length; i++) {
            if (array[i] == array[i + 1]) {
                array.splice(i, 1);
            }
        }

Just checks array elements in sequence.

Try:

for (var i = 0; i < array.length; i++) {
     for(var j = 0; j < array.length; j++){
          if (array[i] == array[j] && i != j) {
                array.splice(i, 1);
            }
     }
}

answered Jul 17 '17 at 20:00

Abbas Akhundov

562
6
12

Thanks mate it worked! By the way i tried double loop i and j as you wrote but unfortunately i forgot to add && i != j to if :) – ttmcswg Jul 17 '17 at 20:07
@ttmcswg Glad to help you out. If it worked please accept my answer as the correct one :) – Abbas Akhundov Jul 17 '17 at 20:10

Delete identical elements from string

4 Answers4