'CityListViewSet' should either include a `serializer_class` attribute, or override the `get_serializer_class()` method

Question

I am assuming by the error in the title, once more here for clarity

'CityListViewSet' should either include a `serializer_class` attribute, 
or override the `get_serializer_class()` method.

that my serializer isn't connected to my view, which in my code it should be. I'm not really sure where the bug is in this one. I wonder if any of you have seen something similar?

Here is the code.

Router:

router.register(r'city-list', CityListViewSet, base_name='city-list')

view:

class CityListViewSet(viewsets.ReadOnlyModelViewSet):                 
    queryset = Venue.objects.values('city').distinct()
    serializer = CitySerializer(queryset, many=True)
    ordering_fields = ('city',)
    ordering = ('city',)

serializer:

class CitySerializer(serializers.ModelSerializer):    
    class Meta:
        model = City
        fields =('city',)

what is it that would be causing such an assertion error with the code seemly wired up correctly?

score 18 · Accepted Answer · answered Jul 18 '17 at 03:50

18

The exception says it itself. You need a serializer_class attribute. You have serializer.

answered Jul 18 '17 at 03:50

Cory Madden

5,026
24
37

1

lol and I confirmed what you just said in the docs. OK your right my bad thank you – Jul 18 '17 at 03:52
this brought a new issues which is `'ListSerializer' object is not callable` currently researching it – Jul 18 '17 at 03:54
Interesting. Are you sure it's related? Because you're not using ListSerializer anywhere in your code example. – Cory Madden Jul 18 '17 at 03:55
my `CityListViewSet` is inheriting from `viewsets.ReadOnlyModelViewSet` I wonder if that might be the cause – Jul 18 '17 at 03:56
Hmm. I just took a look at the DRF source and I don't see any reference to ListSerializer. – Cory Madden Jul 18 '17 at 03:59
it is werid. Im going to see what I can find – Jul 18 '17 at 04:00
1

For a noob like me, it means in your `CityListViewSet`, add `serializer-class = CitySerializer` – Darpan Nov 05 '19 at 17:33

score 4 · Answer 2 · edited Apr 23 '22 at 20:52

4

Add this code snippet to your views.py file

class CityListViewSet(viewsets.ReadOnlyModelViewSet):  # (viewsets.ModelViewSet) 
    serializer_class = CitySerializer
            
    queryset = City.objects.values('city').distinct()
    serializer = CitySerializer(queryset, many=True)
    ordering_fields = ('city',)
    ordering = ('city',)

edited Apr 23 '22 at 20:52

Benyamin Jafari

27,880
26
135
150

answered Mar 16 '22 at 23:35

Aje

41
2

score 2 · Answer 3 · edited Jul 31 '21 at 06:35

2

serializer = CitySerializer(queryset, many=True)

The above line should be replaced with

serializer_class = CitySerializer(queryset, many=True)

edited Jul 31 '21 at 06:35

Saeed

3,294
5
35
52

answered Dec 12 '20 at 06:47

maguluri

75
1
1

score 2 · Answer 4 · edited Jul 03 '21 at 05:29

2

error says you define a serializer attribute, you need to correct with writing serializer_class attribute in your code,

serializer_class = yourCreatedSerializer

edited Jul 03 '21 at 05:29

Simas Joneliunas

2,890
20
28
35

answered Jul 02 '21 at 05:49

Manoj Parmar

71
3

score 1 · Answer 5 · answered Aug 11 '18 at 06:47

Here you used a different model name:

view:

class CityListViewSet(viewsets.ReadOnlyModelViewSet):     #(viewsets.ModelViewSet)             
queryset = City.objects.values('city').distinct()
serializer = CitySerializer(queryset, many=True)
ordering_fields = ('city',)
ordering = ('city',)

import -> from .serializers import TaskSerializers,CitySerializer

serializer:

class CitySerializer(serializers.ModelSerializer):    
class Meta:
    model = City
    fields =('city',)

score 1 · Answer 6 · answered Feb 15 '20 at 19:22

1

i got this error when declared post method in view and trying to send post data without serialize, if you are doing the request from javascript i solved it using JSON.stringify()

answered Feb 15 '20 at 19:22

Francisco Rodeño Sanchez

607
1
9
15

score 0 · Answer 7 · edited Feb 16 '21 at 09:07

0

you have to override the user just add

from django.contrib.auth.models import User
from rest_framework.permissions import IsAdminUser

and in createViewList

permission_classes = [IsAdminUser]

edited Feb 16 '21 at 09:07

Martin Brisiak

3,872
12
37
51

answered Feb 16 '21 at 08:03

Ashwani Kumar

1

score 0 · Answer 8 · answered Feb 10 '23 at 17:22

0

Rename this to

    serializer = CitySerializer(queryset, many=True)

This

    serializer_class = yourCreatedSerializer

Your job is done

answered Feb 10 '23 at 17:22

Harshil shrivastava

88
1
2
10

'CityListViewSet' should either include a `serializer_class` attribute, or override the `get_serializer_class()` method

8 Answers8