Displaying open/closed sign

Question

I want my site to display "Open" or "Closed" based on the current time.

My question is nothing is showing up on the site, so i'm trying to figure out whats wrong with the code

<script type="text/javascript">
var today = new Date(),
var open = "Open",
var closed = "Closed",
var display = document.getElementById('hours-display'); 
if (today.getHours() >= 9 && today.getHours() < 18) {
display.innerHTML = open;
} else {
display.innerHTML = closed;
}
</script>


<div id="hours-display"></div>

Soooo shouldn't `var closed = "Open"` be `var closed = "Closed"` otherwise the output will be `Open` no matter if `open` or `closed` variable is used... — NewToJS, Jul 18 '17 at 18:53
Start by looking at the errors thrown in browser console. The clues there would have given you a start — charlietfl, Jul 18 '17 at 19:08

Sam Denty · Answer 1 · 2017-07-18T18:56:59.470

0

You can only getElementById once the specified element has been declared. Additionally you used commas instead of semi-colons

<div id="hours-display"></div>
<script>
  var today = new Date();
  var display = document.getElementById("hours-display");
  if (today.getHours() >= 9 && today.getHours() < 18) {
    display.innerHTML = "Open";
  } else {
    display.innerHTML = "Closed";
  }
</script>

edited Jul 18 '17 at 18:56

answered Jul 18 '17 at 18:55

Sam Denty

3,693
3
30
43

Care to explain the changes or why this might be useful? Or do you expect people to just use it and not care to understand the changes? – NewToJS Jul 18 '17 at 18:56
It's for a client, Car dealership, they really wanted it – Kevin Jul 18 '17 at 18:58

Richboy · Answer 2 · 2017-07-18T19:05:00.353

0

The way you declare your variables are the issue. You should remove the var from the other variables since you are using commas like this:

var today = new Date(),
open = "Open",
closed = "Closed",
display = document.getElementById('hours-display'); 
if (today.getHours() >= 9 && today.getHours() < 18) {
    display.innerHTML = open;
} else {
    display.innerHTML = closed;
}

edited Jul 18 '17 at 19:05

answered Jul 18 '17 at 18:58

Richboy

33
4

Did you try running it? Theres more that one error in the script – Sam Denty Jul 18 '17 at 18:58
Well, i discovered the errors and updated my answer. – Richboy Jul 18 '17 at 19:05
And the script tag needs to go below the DIV – Sam Denty Jul 18 '17 at 19:06
1

@SamDenty Or the script needs to be placed in a DOM ready function like `window.onload=function(){}` – NewToJS Jul 18 '17 at 19:07

Displaying open/closed sign

2 Answers2