3

So I have the following:

var change_handler = function(element) {
    // ... do some fancy stuff ...
}

Now, I want to attach this to an element. Which is the better/best or more correct method?

$('element_selector').change(change_handler(this));

Or...

$('element_selector').change(function() { change_handler(this); });

And does it make any difference if you're passing the object to the function or not?

PeeHaa
  • 71,436
  • 58
  • 190
  • 262
Darryl Hein
  • 142,451
  • 95
  • 218
  • 261

2 Answers2

6

Neither..

$('element_selector').change(change_handler);

change_handler will be the so to speak pointer to the method and the argument of the element is already passed by jQuery

If you were to use $('element_selector').change(change_handler(this)); it wouldn't actually assign the method as the handler but rather run the method and attempt to assign the result as the handler, the other option is superfluous because you can use the method name as described above instead of re-wrapping the method.

Quintin Robinson
  • 81,193
  • 14
  • 123
  • 132
1

This is another way to approach the problem given by the OP... partial function application a la another SO Q. Bind the change handler with the arg of interest and pass the resulting partial as the arg to the change handler:

var myChangeHandler = partial(change_handler, this);
$('element_selector').change(myChangeHandler);
Community
  • 1
  • 1
gap
  • 2,766
  • 2
  • 28
  • 37