Converting time to ago format failed

Question

When using this answer from this thread. It fails for me, I checked the $now, $ago, $diff and $string and they all work or in proper condition.

public static function convertTime($datetime)
{
    $now = new DateTime;
    $now->setTimezone(new DateTimeZone('Asia/Manila'));
    $now->format('Y-m-d h:i:s');

    $ago = new DateTime($datetime);
    $diff = $now->diff($ago);

    $diff->w = floor($diff->d / 7);
    $diff->d -= $diff->w * 7;

    $string = [
      'y' => 'year',
      'm' => 'month',
      'w' => 'week',
      'd' => 'day',
      'h' => 'hour',
      'i' => 'minute',
      's' => 'second'
    ];

    foreach ($string as $k => &$v) {
        if ($diff->$k) {
            $v = $diff->$k . ' ' . $v . ($diff->$k > 1 ? 's' : '');
        } else {
            unset($string[$k]);
        }
    }
}

Why does it fail:

If I var_dump($diff->$k), it returns all the value to me is 0, making it null; the only problem is why?

Just to be certain, where are you putting your `var_dump()`? Your method doesn't actually return anything. — Nathan Dawson, Jul 23 '17 at 02:38

score 0 · Answer 1 · answered Jul 23 '17 at 02:33

0

Perhaps you forget to return the value?

answered Jul 23 '17 at 02:33

mokamoto12

383
1
6

score 0 · Accepted Answer · answered Jul 23 '17 at 03:06

Your method needs to return a value, this could be the main reason why it currently returns NULL. However, you should as well create a whole new string for your output, as you currently seem to override $v every time you loop through the $string array. I've as well reformatted the output, as some whitespace was missing between the words.

By the way: you don't need to unset $string[$k] as you will loop only once through the array anyway. So that doesn't change anything.

This worked fine for me:

public static function convertTime($datetime)
{
    $now = new DateTime;
    $now->setTimezone(new DateTimeZone('Asia/Manila'));
    $now->format('Y-m-d h:i:s');

    $ago = new DateTime($datetime);
    $diff = $now->diff($ago);

    $diff->w = floor($diff->d / 7);
    $diff->d -= $diff->w * 7;

    $string = [
        'y' => 'year',
        'm' => 'month',
        'w' => 'week',
        'd' => 'day',
        'h' => 'hour',
        'i' => 'minute',
        's' => 'second'
    ];
    $result = '';
    foreach ($string as $k => $v) {
        if ($diff->$k) {
            $result .= $diff->$k . ' ' . $v . ($diff->$k > 1 ? 's ' : ' ');
        }
    }

    return $result;
}

@knawledgelol It doesn't show the value if the value equals to zero. So in your case the hour value seems to be equal to zero. You can remove the `if($diff->$k)` clause (but not the content of it!) if you don't want or need that. — webFashion, Jul 23 '17 at 03:15

score 0 · Answer 3 · answered Jul 23 '17 at 06:24

look at the code:

function ego($date) { 
$delta = time() - strtotime($date);
if ( $delta < 60 && $delta >= 0)$data =  strval(round(($delta),0)). ' second ego';
elseif ($delta >= 60 && $delta < (60*60))$data = strval(round(($delta/60),0)). ' minute ego';
elseif ($delta >= (60*60) && $delta < (24*60*60))$data = strval(round(($delta/3600),0)). ' houre ego';
elseif ($delta >= (24*60*60) && $delta < (24*60*60*365))$data =  strval(round(($delta/86400),0)). ' day ego';
elseif ($delta >= (24*60*60*365)) $data = strval(round(($delta/31536000),0)). ' year ego';
return $data;
}

Please explain why your code should be 'looked at', try and show why your answer solves the original question. — Nigel Ren, Jul 23 '17 at 06:31

Converting time to ago format failed

3 Answers3