How to increment a number inside foreach loop?

Question

I want to fetch some data from database and show it in the form of HTML table.

I want the first column of the table to show the number of row like 1,2,3,4...

This is my foreach loop

$i=0;    
foreach($sql as $sql)    
{
    echo "<tr>";
        echo "<td>$i++</td>";
        echo "<td>$sql->jobseeker_name</td>";
        echo "<td>$sql->jobseeker_phone</td>";
        echo "<td>$sql->login_email</td>";
    echo "</tr>";
}

It is not working and I don't know what is wrong with it.

Answer 1

Don't write $i++where you want the echo. Echo it first and at the end of the loop, add $i++ to incement the value:

<?php    

$i = 1;    

foreach ($sql as $sql) {
    echo "<tr>";
    echo "<td>$i</td>";
    echo "<td>$sql->jobseeker_name</td>";
    echo "<td>$sql->jobseeker_phone</td>";
    echo "<td>$sql->login_email</td>";
    echo "</tr>";

    $i++;
}

Answer 2

The basic version of string interpolation is ignoring the ++ operator, as it only knows about simple variables - see String Parsing

If you want a nicer-looking bit of code, you can do something like this:

<!-- language: lang-php -->
<?php    

$i = 1;    
foreach($sql as $sql): ?>

   <tr>
     <td><?= $i++ ?></td>
     <td><?= $sql->jobseeker_name ?></td>
     <td><?= $sql->jobseeker_phone ?></td>
     <td><?= $sql->login_email ?></td>
   </tr>
<?php endforeach;

Answer 3

Normally when I vote to close a question as duplicate, I will not post an answer, but there are several opportunities to educate on this question that are difficult to delineate in mere comments.

It is vital, if you are going to increment in the echo line, that the ++ comes before $i. If the ++ comes after $i, then the initial value of $i is echoed THEN the incrementation occurs.

Assuming I've got the structure of your resultset right, this is how I would write the snippet:

Code: (Demo)

$sql=[
    (object)['jobseeker_name'=>'A','jobseeker_phone'=>'B','login_email'=>'C'],
    (object)['jobseeker_name'=>'D','jobseeker_phone'=>'E','login_email'=>'F'],
    (object)['jobseeker_name'=>'G','jobseeker_phone'=>'H','login_email'=>'I']
];
foreach($sql as $i=>$row){
    echo "<tr>";
        echo "<td>",++$i,"</td>";
        echo "<td>$row->jobseeker_name</td>";
        echo "<td>$row->jobseeker_phone</td>";
        echo "<td>$row->login_email</td>";
    echo "</tr>";
}

Output:

<tr>
    <td>1</td>
    <td>A</td>
    <td>B</td>
    <td>C</td>
</tr>
<tr>
    <td>2</td>
    <td>D</td>
    <td>E</td>
    <td>F</td>
</tr>
<tr>
    <td>3</td>
    <td>G</td>
    <td>H</td>
    <td>I</td>
</tr>

Additionally, as a matter of best practice:

• Use a new variable name to distinguish each row of the $sql array of objects. If you use foreach($sql as $sql){ then if you need to access $sql again, you will only be able to access the last iterated subarray of $sql This is because the foreach loop is constantly overwriting the input array.

• Use commas rather than dots to concatenate with echo. It is a nano-optimization, but there is no downside to doing this a matter of habit.

• Also as a matter of nano-optimization, it is faster to use "pre-incrementation" (++$i) rather than "post-incrementation" ($i++) in all cases where the outcome is the same. What's the difference between ++$i and $i++ in PHP?

Answer 4

You just need to escape your i++

echo "<td>".$i++."</td>";

Because $i++ is a PHP incrementation it needs to be parsed.

So the complete code would look like this:

<?php    
$i=1;    
        foreach($sql as $sql)    
        {
         echo "<tr>";
         echo "<td>".$i++."</td>";
         echo "<td>$sql->jobseeker_name</td>";
         echo "<td>$sql->jobseeker_phone</td>";
         echo "<td>$sql->login_email</td>";
         echo "</tr>";
        }
?>

Tested and working as expected. Proof of concept here: https://3v4l.org/mUqZ1.

Answer 5

try this code

   $i=0;    
   foreach($sql as $sql){
      echo "<tr>";
      echo "<td>$i++</td>";
      echo "<td>$sql->jobseeker_name</td>";
      echo "<td>$sql->jobseeker_phone</td>";
      echo "<td>$sql->login_email</td>";
      echo "</tr>";
      i++;
   }