11

I am trying to use Piston to provide REST support to Django. I have implemented my handlers as per the documentation provided . The problem is that i can "read" and "delete" my resource but i cannot "create" or "update". Each time i hit the relevant api i get a 400 Bad request Error.

I have extended the Resource class for csrf by using this commonly available code snippet:

class CsrfExemptResource(Resource):
    """A Custom Resource that is csrf exempt"""
    def __init__(self, handler, authentication=None):
        super(CsrfExemptResource, self).__init__(handler, authentication)
        self.csrf_exempt = getattr(self.handler, 'csrf_exempt', True)

My class (code snippet) looks like this:

user_resource = CsrfExemptResource(User)

class User(BaseHandler):
    allowed_methods = ('GET', 'POST', 'PUT', 'DELETE')

    @require_extended
    def create(self, request):
        email = request.GET['email']
        password = request.GET['password']
        phoneNumber = request.GET['phoneNumber']
        firstName = request.GET['firstName']
        lastName = request.GET['lastName']
        self.createNewUser(self, email,password,phoneNumber,firstName,lastName)
        return rc.CREATED

Please let me know how can i get the create method to work using the POST operation?

Wolph
  • 78,177
  • 11
  • 137
  • 148
Cheezo
  • 761
  • 9
  • 24
  • Okay, i commented out "django.middleware.csrf.CsrfViewMiddleware" from the settings file instead of using the extension of Resource Class. I still see the issue though – Cheezo Dec 27 '10 at 08:30
  • How are you attempting the "PUT" or "POST" HTTP operation that corresponds to "create" or "update"? How do you know this client-side code is creating a correct and valid HTTP request? – S.Lott Dec 27 '10 at 15:04
  • For the POST, i use a restclient WizTools.org from which i can explicitly create a POST request.So atleast i am sure of the request going through and that is enough i guess. – Cheezo Dec 28 '10 at 04:11

7 Answers7

10

This is happening because Piston doesn't like the fact that ExtJS is putting "charset=UTF-8" in the content-type of the header.

Easily fixed by adding some middleware to make the content-type a bit more Piston friendly, create a file called middleware.py in your application base directory:

class ContentTypeMiddleware(object):

    def process_request(self, request):
        if request.META['CONTENT_TYPE'] == 'application/x-www-form-urlencoded; charset=UTF-8':
            request.META['CONTENT_TYPE'] = 'application/x-www-form-urlencoded'
        return None

Then simply include this middleware in your settings.py:

MIDDLEWARE_CLASSES = (
    'appname.middleware.ContentTypeMiddleware',
)
joekrell
  • 341
  • 2
  • 4
7

Proposed solutions still did not work for me (django 1.2.3/piston 0.2.2) so I've tweaked joekrell solution and this finally works (I'm only using POST and PUT, but presumably you can add other verbs to the list):

class ContentTypeMiddleware(object):

def process_request(self, request):

    if request.method in ('POST', 'PUT'):
        # dont break the multi-part headers !
        if not 'boundary=' in request.META['CONTENT_TYPE']:
            del request.META['CONTENT_TYPE']

with:

MIDDLEWARE_CLASSES = (
'appname.middleware.ContentTypeMiddleware',
)

I haven't noticed any side-effect, but I can't promise it's bullet-proof.

Eric Gazoni
  • 846
  • 7
  • 7
  • 2
    Yes, your solution worked for me as well (Django 1.3, Piston 0.2.2). In general it looks like Piston became an abandon-ware --- it was not updated in a long time. – Eugene Lazutkin May 23 '11 at 10:00
4

I have combined some of what other people have said, and added support for any content type, json for instance...

class ContentTypeMiddleware(object):
    def process_request(self, request):
        if request.method in ('POST', 'PUT') and request.META['CONTENT_TYPE'].count(";") > 0:
            request.META['CONTENT_TYPE'] = [c.strip() for c in request.META['CONTENT_TYPE'].split(";") ][0]
        return None
Eric
  • 41
  • 1
4

I thought Eric's solution worked the best but then ran into problems when saving things in admin. This tweak seems to fix it if anyone else comes across it:

class ContentTypeMiddleware(object):

    def process_request(self, request):
        if request.method in ('POST') and not 'boundary=' in request.META['CONTENT_TYPE']:
            request.META['CONTENT_TYPE'] = [c.strip() for c in request.META['CONTENT_TYPE'].split(";") ][0]
        return None
GivP
  • 2,634
  • 6
  • 32
  • 34
1

This is solution which worked for me, after a tweak:

class ContentTypeMiddleware(object):

    def process_request(self, request):
        if 'charset=UTF-8' in request.META['CONTENT_TYPE']:
            request.META['CONTENT_TYPE'] = request.META['CONTENT_TYPE'].replace('; charset=UTF-8','')
        return None
anils
  • 1,782
  • 6
  • 19
  • 29
1

In utils.py, change this.

def content_type(self):
    """
    Returns the content type of the request in all cases where it is
    different than a submitted form - application/x-www-form-urlencoded
    """
    type_formencoded = "application/x-www-form-urlencoded"

    ctype = self.request.META.get('CONTENT_TYPE', type_formencoded)

    if ctype.strip().lower().find(type_formencoded) >= 0:
        return None

    return ctype

https://bitbucket.org/jespern/django-piston/issue/87/split-charset-encoding-form-content-type

TIMEX
  • 259,804
  • 351
  • 777
  • 1,080
0

We had a resource that was simply updating a timestamp based on the request credentials and PUT. It turns out that Piston does not like PUT without a payload. Adding an empty string payload '' fixed it.

A quick Google search indicates that other systems like Apache may not like PUT without a payload, as well.

helix7
  • 34
  • 2