Unable to delete data from oracle database using php

Question

I am using php to delete data from the database but its not deleting and there is no error showing.

Please help me.

<?php
    include('connect.php');
    $p_No = $_POST['p_No'];
    $sql2 = "DELETE FROM usersR WHERE p_No = '$p_No'";
    $compiled1 = oci_parse($conn,$sql2);
    $ex = oci_execute($compiled1,OCI_DEFAULT);
?>

Its my connect.php code

 <?php
       $username = "system";
       $password = "******";
       $connectionString = "localhost/ORCL";

       $conn = oci_connect($username, $password, $connectionString);
       if (!$conn) {
          $e = oci_error();
          trigger_error(htmlentities($e['message'], ENT_QUOTES), E_USER_ERROR);
          }

        ?>

See What Error It's Coming by `if (!$ex) {echo oci_error();}` — Nana Partykar, Aug 03 '17 at 10:21
Is the `p_No` column `char` or `num`? If it's `num` remove the single quotes (`'`) around the variable `$p_No`. Also, you're vulnerable to [SQL injection](https://stackoverflow.com/q/60174/3775731). — timclutton, Aug 03 '17 at 10:29
@timclutton i have removed the single quotes but still its not working — Nida Akram, Aug 03 '17 at 10:33

score 0 · Answer 1 · answered Aug 05 '17 at 02:51

From the manual:

OCI_NO_AUTO_COMMIT: Do not automatically commit changes. Prior to PHP 5.3.2 (PECL OCI8 1.4) use OCI_DEFAULT which is equivalent to OCI_NO_AUTO_COMMIT.

So, you should be using OCI_COMMIT_ON_SUCCESS or doing an explicit commit.

To emphasize the comments everyone's made: add error checking and use bind variables to prevent SQL Injection.

When in doubt read the PHP OCI8 manual and also the Underground PHP & Oracle Manual, which I keep linking to because it is really a big FAQ.

Unable to delete data from oracle database using php

1 Answers1