Sort a list with a string like an int

Question

I have a list of objectsList<Batch> batchesList new List<Batch>();with fields string orderNo and int lineNo

I print "orderNo-lineNo"

I want to sort it by orderNo then lineNo. The problem I have is that using linq's sort(), this will sort as a string, thus 11AG131-13 would actually come before 11AG131-2

batchesList.Sort((x, y) => (x.orderNo + x.lineNo).CompareTo(y.orderNo + y.lineNo));

Thanks for help

If you want them to be sorted as int's you have to convert them to `int` before sorting. — maccettura, Aug 11 '17 at 14:50
I'm in a car writing in a mobile... Try OrderBy(int.tryparse(your string))The by(int.TryParse(secondstring)) — Juan, Aug 11 '17 at 14:52
Just so I am clear.. you want `11AG131-2` to come before `11AG131-13` even though `11AG131-13` could have a `lineNo` that is less than `11AG131-2`'s `lineNo`? — Grizzly, Aug 11 '17 at 15:00
@juharr ohhhhh I see now.. I was interpreting that all to just be the `orderNo`.. okay I see now. Sorry about my confusion — Grizzly, Aug 11 '17 at 15:07
There is the separate issue of ordering the `orderNo` But that's only an issue if it's length can vary like "2AG131" and "11AG131" — juharr, Aug 11 '17 at 15:08

score 6 · Accepted Answer · answered Aug 11 '17 at 14:52

6

var sortedBatches = batchesList.OrderBy(b => b.orderNo)
                               .ThenBy(b => b.lineNo)
                               .ToList();

answered Aug 11 '17 at 14:52

Maxim

1,995
1
19
24

This is also a good approach – J. D. Aug 11 '17 at 14:52
@J.D. It's identical to yours. ;) – cdhowie Aug 11 '17 at 14:53
If I am reading the OP question clearly, they want `11AG131-2` to come before `11AG131-13`? If so, your solution produces the outcome that the OP has already experienced – Grizzly Aug 11 '17 at 14:59
Yes and this code will do it because 2 is before 13 :) – Maxim Aug 11 '17 at 15:02
1

@T_Roy No, this will put the 2 before the 13 because `lineNo` is an `int`. The OP's issue is that they sort on a string concatenation of the values. – juharr Aug 11 '17 at 15:03

J. D. · Answer 2 · 2017-08-11T15:16:30.247

1

var newList = (from x in batchesList orderby x.orderNo, x.lineNo select x).ToList();

edited Aug 11 '17 at 15:16

answered Aug 11 '17 at 14:51

J. D.

1,351
8
13

1

This is missing the `select`. – juharr Aug 11 '17 at 15:01
LOL, right you are. I'll fix it now. – J. D. Aug 11 '17 at 15:16

score 0 · Answer 3 · answered Aug 11 '17 at 14:51

0

There's an idiomatic approach to ordering on multiple values:

batchesList.Sort((x, y) => {
    var i = x.orderNo.CompareTo(y.orderNo);

    if (i != 0) { return i; }

    return x.lineNo.CompareTo(y.lineNo);
});

answered Aug 11 '17 at 14:51

cdhowie

158,093
24
286
300

Sort a list with a string like an int

3 Answers3