Mockito When...thenReturn not returning expected value on Collection

Question

I'm doing a Mockito unit test on one of my service and I tried to mock it, but I cannot return the desired object. A snippet of my code looks like this:

   @RunWith(MockitoJUnitRunner.class)
    public class RunBinaryApprovalActivityTest {

        @Mock
        CountryToMarketplaceMapper countryToMarketplaceMapper;

        @Test
        void doSomeTestHere() {
        Set<Integer> marketplaces = new HashSet<Integer>();
        marketplaces.add(1);

        List<String> countries = new ArrayList<String>();
        countries.add("US");




Mockito.when(countryToMarketplaceMapper.getMarketplacesForCountries(Mockito.anyCollection())).thenReturn(marketplaces);

Mockito.when(otherTestInstance.otherMethod("inputString")).thenReturn("ExpectedOutput");

Assert.assertEquals(otherTestInstance.otherMethod("inputString"),"ExpectedOutput");

Assert.assertEquals(countryToMarketplaceMapper.getMarketplacesForCountries(countries), marketplaces);


        }


    }

Right now the otherTestInstance.otherMethod("inputString") passed the test case but the countryToMarketplaceMapper.getMarketplacesForCountries(countries) failed because junit.framework.AssertionFailedError: expected:<[]> but was:<[1]>.

I'm confused, didn't I just simulate the behavior of countryToMarketplaceMapper.getMarketplacesForCountries(countries) to return a marketplaces which has entry inside? I did some research and found this post: Mockito when/then not returning expected value and I chenged how I defined the mocking behaviour using "doReturn()...when()" but still doesn't resolve this issue.

I'm thinking maybe it's because thenReturn() cannot return a collection of thing but I didn't find any resource that explain this. If anyone know some hint, please let me know! Lots of thanks!

score 2 · Accepted Answer · answered Aug 11 '17 at 19:09

2

I am not sure what version of java and mockito you are using. Try this

Mockito.when(countryToMarketplaceMapper.getMarketplacesForCountries(Mockito.anyListOf(String.class))).thenReturn(marketplaces);

answered Aug 11 '17 at 19:09

want2learn

2,471
2
20
37

It works! Could you briefly explain why your version works? Thanks! – OD Street Aug 11 '17 at 22:04
Which version of mockito you are using ? – want2learn Aug 14 '17 at 14:55
I believe I'm using 1.10.19. – OD Street Aug 14 '17 at 18:52

Mockito When...thenReturn not returning expected value on Collection

1 Answers1