@PreUpdate doesn't save parent object when it's updated

Question

I have two entities with relation one to many. Parent can have several Child entity instances. I added a field to the parent that stores the date of children modifications(childrenLastModifiedDate). To maintain that, I added method:

@PrePersist
@PreUpdate
@PreRemove
private void handle() {
    parent.setChildrenLastModifiedDate(now());
}

Here is the problem. It's not always invoke when the child is saved. Locally(mac os), it works as expected, all three types of changes are tracked and saved to the parent entity. However, on the server(linux) it only works for:

@PrePersist
@PreRemove

Even though, PreUpdate is invoked, the changes are not saved. I have even tried to add a direct repository call to save the parent. The result is the same. Nothing is saved on update, but saved on remove or persist. I tried to make this change in additional transaction and it worked, but it's too resource consuming. Also, I can see that someone had very similar experience:

JPA/Hibernate preUpdate doesn't update parent object

However, there is nothing on how to handle the problem itself. The question is: is there a way to guarantee that using of this annotations will always work and perform additional updates of dependent entities? If it's not, what is the best way to handle such logic? The update is required on each change to children. Even if it is saved by cascade.

Is it possible to add a comment and explain how the accepted answer solved the issue. Was it related to @EntityListeners? — Arashsoft, Jan 21 '19 at 20:37

asinkxcoswt · Accepted Answer · 2021-09-09T11:54:36.497

I got the same problem. I fixed it by using Hibernate Interceptor.

First, you have to declare some base method in the base entity class that allow us to find the parent of an entity, an a method to chaining update your desired fields.

public abstract class BaseEntity {
    public Optional<BaseEntity> getParent() {
        // subclass should override this method to return the parent entity
        return Optional.empty();
    }
    public void updateChain() { 
        // update your desired fields
        ...
        this.getParent().ifPresent(p -> p.updateChain());
    }
}

Then you can use following Hibernate interceptor to force update all parents of the dirty entities.

public class EntityChainForceUpdateHibernateInterceptor extends EmptyInterceptor {

    @Override
    public void preFlush(Iterator entities) {
        entities.forEachRemaining(e -> {
            if (BaseEntity.class.isAssignableFrom(e.getClass())) {
                BaseEntity b = (BaseEntity) e;
                b.getParent().ifPresent(p -> p.updateChain());
            }
        });
    }
}

To register this interceptor with Spring, just add following line to application.properties

spring.jpa.properties.hibernate.ejb.interceptor=com.your.package.EntityChainForceUpdateHibernateInterceptor

And this is an example of how to override the getParent().

@MappedSuperclass
public abstract class BaseEntity {

    @Column(name = "last_updated_at")
    private Instant lastUpdatedAt;

    public Optional<BaseEntity> getParent() {
        return Optional.empty();
    }
    public void updateChain() {
        this.lastUpdatedAt = Instant.now();
        this.getParent().ifPresent(p -> p.updateChain());
    }
}

@Entity
public class ParentEntity extends BaseEntity {
    @Id
    @Column(name = "id")
    private String id;

    @Column(name = "something")
    private String somethingToUpdateWhenChildSaved;

    @Override
    public void updateChain() {
        this.somethingToUpdateWhenChildSaved = "anything";
        super.updateChain();
    }
}

@Entity
public class ChildEntity extends BaseEntity {

    @ManyToOne
    @JoinColumn(name = "parent_id", referencedColumnName = "id")
    private ParentEntity parent;

    @Override
    public Optional<BaseEntity> getParent() {
        return Optional.of(this.parent);
    }
}

Could you give an example of overriding getParent(). I'm stuck with the syntax. How do you return the parent object through the model? — Leena, Sep 02 '21 at 16:07
@Leena sorry I have just seen your comment. I added the example. — asinkxcoswt, Sep 09 '21 at 11:56

score 1 · Answer 2 · answered Aug 29 '17 at 19:11

It seems your issue is with @PreUpdate only.

My personal opinion is your entity was not updated if @PreUpdate was not called. But you can check it easily. I would recommend use optimistic lock (just use version field following hibernate doc) or auditing for entities where you need check update activity. If update was processed you could definitely detect if @PreUpdate activity processed or not. After some tests you'll detect where was the issue.

P.S.

I've never checked behavior if @PreUpdate is used at same time for the entity and for subscribed @EntityListeners for the entity. As for me conflict could be in this case. Not sure but if you have both of this annotations, please check complex and separate behavior (Who knows, may be hibernate developers decided that impossible case, because you do not need @PreUpdate handlers in entity if some declared in your entity listener implementation. If you'll check it, please let me know in comment).

@PreUpdate doesn't save parent object when it's updated

2 Answers2

P.S.