PHP MySQL query help

Question

I am trying to use this query to return every instance where the variable $d['userID'] is equal to the User ID in a separate table, and then echo the username tied to that user ID.

Here's what I have so far:

$uid = $d['userID'];

$result = mysql_query("SELECT u.username
FROM users u
LEFT JOIN comments c
ON c.userID = u.id
WHERE u.id = $uid;")$row = mysql_fetch_assoc($result);
echo $row['username'];

Does echo print something here? – Shakti Singh Jan 01 '11 at 04:59 — Shakti Singh, Jan 01 '11 at 04:59
You are missing a semi colon on the end of $result=... – tkt986 Jan 01 '11 at 05:09 — tkt986, Jan 01 '11 at 05:09

score 2 · Accepted Answer · edited May 28 '11 at 20:55

2

This should work

$uid = mysql_real_escape_string($d['userID']);

$result = mysql_query("SELECT u.username
FROM users u
LEFT JOIN
 comments c
ON c.userID = u.id
WHERE u.id = '$uid'");


    while($row = mysql_fetch_assoc($result))
{
   //PRINTS ALL INSTANCES OF THE ROW
    echo $row['username'];
}

what is printed from the echo above.

edited May 28 '11 at 20:55

Johan

74,508
24
191
319

answered Jan 01 '11 at 05:12

tkt986

1,081
3
17
25

If that it the case, you can ignore the while loop. – tkt986 Jan 01 '11 at 14:21
fixed SQL-injection hole (http://stackoverflow.com/questions/332365/xkcd-sql-injection-please-explain) – Johan May 28 '11 at 20:55

Chandu · Answer 2 · 2011-01-01T05:12:26.197

0

Try this:

$uid = $d['userID'];

$result = mysql_query("SELECT u.username
FROM users u
LEFT JOIN comments c
ON c.userID = u.id
WHERE u.id = $uid");
while($row = mysql_fetch_assoc($result))
{
  echo $row['username'];
}

*EDIT:*Removed semicolon.

edited Jan 01 '11 at 05:12

answered Jan 01 '11 at 05:05

Chandu

81,493
19
133
134

You still need the semi colon at the end. – tkt986 Jan 01 '11 at 05:13
1

Thx tsegay, I think I had enough beer. time to hit bed now :) – Chandu Jan 01 '11 at 05:15
1

@Cybernate Good for you, Happy New Year. – tkt986 Jan 01 '11 at 05:17

score 0 · Answer 3 · answered Jan 01 '11 at 05:10

0

if you're looking to get all the results. wrap your mysql_fetch_assoc in a while loop:

$result = mysql_query("SELECT u.username
FROM users u
LEFT JOIN comments c
ON c.userID = u.id
WHERE u.id = $uid;");
while($row = mysql_fetch_assoc($result)){
    echo $row['username'];

}

answered Jan 01 '11 at 05:10

seanh

214
1
7

sorry for the dupe. other responses happened before page refresh. – seanh Jan 01 '11 at 05:12

PHP MySQL query help

3 Answers3