Data sent on button press persists when different button is pressed

Question

Issue: I have a table view in complaintController which has "open" buttons in it. Whenever I press on the open button I segue to DetailComplaintViewController with the data of that row, but when I go back to ComplaintController and select a different button I am presented with the same data from previous selection.

NOTE - I have created a segue from button in cell of tableView.

This is the code I am using to segue from ComplaintController to DetailComplaintController.

var passRow = 0
        public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell{

            let billCell = tableView.dequeueReusableCell(withIdentifier: "complaintCell") as! ComplaintTableViewCell
            billCell.openBtn.tag = indexPath.row
            billCell.openBtn.addTarget(self, action: #selector(btnClicked), for: .touchUpInside)
            return billCell

    }

             func btnClicked(sender: UIButton) {
                    passRow = sender.tag
                    print("Position......\(sender.tag)")
                }

                override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
                    let rVC = segue.destination as? DetailComplaintViewController
                    rVC?.issueType = self.complaintListArray[passRow].issueType
                    rVC?.issuedescription = self.complaintListArray[passRow].description
                    rVC?.issuedate = self.complaintListArray[passRow].issueDate
                }

The data from my previous selection is getting displayed even when I select a different button — Ojas Chimane, Aug 19 '17 at 06:32
Okay that mean you are getting wrong data even you select different open button in cell right? — Bhupat Bheda, Aug 19 '17 at 06:33
Then get the indexpath of that row and according to that row take the value from array and send it from Prepareforsegue method — Bhupat Bheda, Aug 19 '17 at 06:35
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/152311/discussion-between-bhupat-bheda-and-ojas-chimane). — Bhupat Bheda, Aug 19 '17 at 06:36
How are you dismissing the detailComplainViewcontroller?? Can you please post the code of the detailComplaintViewController — OverD, Aug 19 '17 at 06:44
I am not doing anything to dismiss detailComplainViewController — Ojas Chimane, Aug 19 '17 at 06:59
Then how can you go back to the complainViewController from the detail I think the issue is that the detailComplainViewctonroller is staying in the view hierarchy and is not being loaded again — OverD, Aug 19 '17 at 07:05
Can you send an image of your storyboard so I can understand the layout of your views so I can help you...it looks like your using a navigation controller — OverD, Aug 19 '17 at 07:19

score 1 · Accepted Answer · answered Aug 19 '17 at 08:35

The problem is that the prepare for segue will be called before your btnClicked function and thats why you are not getting the correct data.

A quick fix for your situation would be to get the button tag inside the prepare for segue method like this:

override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
    guard let button = sender as? UIButton else {
        print("Segue was not called from button")
        return
    }
    let row = button.tag
    let rVC = segue.destination as? DetailComplaintViewController
    rVC?.issueType = self.complaintListArray[row].issueType
    rVC?.issuedescription = self.complaintListArray[row].description
    rVC?.issuedate = self.complaintListArray[row].issueDate
}

Other option is to remove the segue from the button and create it on the view controller and programatically perform that segue inside your btnClicked method which is explained in this answer

Data sent on button press persists when different button is pressed

1 Answers1