Deleting from table with @OneToOne annotation

Question

I'm using JPA2 and Hibernate implementation.

I've got simple mapping like this:

@Entity 
class Topic {

    @Id
    @GeneratedValue(strategy = IDENTITY)

    int id;

   @OneToOne(cascade = ALL)
   @JoinColumn(name = "id_poll")
   private Poll poll;

}

@Entity 
class Poll {
    @Id
    @GeneratedValue(strategy = IDENTITY)
    int id;
}

Now, when I delete a Poll object which is also in Topic I get an error.

java.sql.SQLException: Integrity constraint violation FKCC42D924982D3F4B table: TOPICS in statement [delete from polls where id=?]

I understand that it is because I can't delete the Poll record if it has references in another table. How can I solve this problem? Do I have to manually set poll = null in a Topic table or is there a better solution?

score 6 · Accepted Answer · edited May 23 '17 at 12:06

This is expected behavior:

A common problem with bi-directional relationships is the application updates one side of the relationship, but the other side does not get updated, and becomes out of sync. In JPA, as in Java in general it is the responsibility of the application, or the object model to maintain relationships.

Source: Object corruption, one side of the relationship is not updated after updating the other side

The correct place to handle this is in a @PreRemove callback:

@Entity 
class Poll {

    ...

    @PreRemove
    private void preRemove() {
        Poll poll = topic.getPoll();
        topic.setPoll( null );
    }
}

See also: Have JPA/Hibernate to replicate the “ON DELETE SET NULL” functionality

score 2 · Answer 2 · edited Aug 11 '14 at 14:07

2

I was not able to find a solution by now, so before I delete a Poll object I always get a Topic object which contains given Pool and set it to null.

Topic topic = entityManager.find( Topic.class, 1 );
Poll poll = topic.getPoll();
topic.setPoll( null );
entityManager.remove( poll );

And it works correctly.

edited Aug 11 '14 at 14:07

Sam

7,252
16
46
65

answered Jan 04 '11 at 13:05

Dawid

644
1
14
30

score 1 · Answer 3 · answered Jan 03 '11 at 02:58

1

It looks like the @OneToOne annotation in JPA 2 contains an orphanRemoval flag, you could try setting that and see if it removes it gracefully.

answered Jan 03 '11 at 02:58

digitaljoel

26,265
15
89
115

Edmondo · Answer 4 · 2011-12-20T13:44:25.873

The problem lies in the fact that you are using Auto-Generated ID on both sides. When you persist the parent entity, the child entity is persisted as well but its ID inside the parent entity is not updated with the one generated from the database.

As a result, when you delete the parent, you won't delete the child, because the child has no ID.

Try setting manually the ID of the child entity and orphanRemoval will work.

Deleting from table with @OneToOne annotation

4 Answers4