ListView from cursor with checkbox

Question

I have a Listview that looks like the following:

checkbox:textview {0 .. n}

I have a OnCheckChangedListener that listens for checkbox changes (checkbox has focusable set to false as recommended by http://www.mousetech.com/blog/?p=74).

The behaviour that I am looking for is that users can click the checkbox to set its state, and they can click on the listview item to get a description.

Currently, checkbox state is saved properly and if you click on an item, then it shows a description. However, if you first change a state and then click to get the description, the checkbox reverts to a prior state. In fact all checkboxes revert back to a prior state.

Anyone know how i can get this working?

Thanks.

*****EDIT********

SimpleCursorAdapter adapter = 
    new SimpleCursorAdapter(this,
        R.layout.listview_item, 
        cursor, 
        new String[] {MyContentColumns.NAME, MyContentColumns.MyBoolean }, 
        new int[] {R.id.listview_item_title,R.id.listview_item_myBoolean });

adapter.setViewBinder(new SimpleCursorAdapter.ViewBinder() {
    @Override
    public boolean setViewValue(View view, Cursor cursor,int columnIndex) {
        String c_name = cursor.getColumnName(columnIndex);
        if (c_name.equals(MyContentColumns.NAME)) {
            // set up name and description of listview
            MyContent v = mycontent.getMyContent(cursor.getString(columnIndex));
            if (view instanceof TextView) {
                TextView tv = (TextView) view;
                if (tv.getId() == R.id.listview_item_title) {
                    tv.setText(v.getLongName());
                }
            }
            return true;
        } else if (c_name.equals(MyContentColumns.MyBoolean)) {
            // if myBoolean == 0, box is checked
            // if myBoolean == 1, box is unchecked
            int myBoolean = cursor.getInt((cursor.getColumnIndex(MyContentColumns.MyBoolean)));
            final String myCont_name = cursor.getString(cursor.getColumnIndex(MyContentColumns.NAME));
            final String myCont_cid = cursor.getString(cursor.getColumnIndex(MyContentColumns.CONTENT_ID));
            final long c_id = cursor.getLong(cursor.getColumnIndex(MyContentColumns._ID));

            if (view instanceof CheckBox) {
                ((CheckBox) view).setChecked(myBoolean == 1);
                ((CheckBox) view)
                        .setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
                            @Override
                            public void onCheckedChanged(CompoundButton buttonView,boolean isChecked) {
                                ContentValues values = new ContentValues();
                                values.put(MyContentColumns.MyBoolean,isChecked ? 1 : 0);
                                int rows = getContentResolver()
                                .update(
                                        ContentUris.withAppendedId(Uri.withAppendedPath(MyContentColumns.CONTENT_URI,"mycontent"),c_id),
                                        values,
                                        null,
                                        null);
                                if ( rows == 0) {
                                    Logger.wLog(String
                                            .format("Couldn't update values for %s into db for content %d",
                                                    myCont_name, myCont_cid));
                                }
                            }
                        });
            }
            return true;
        }
        return false;
    }
});

So it seems that clicking on one list item causes the other list items to also get clicked... so values revert and my states become inconsistent... ideas? thanks.

I think that i am having the same problem as: http://stackoverflow.com/questions/2757121/android-listview-with-checkbox-automatically-unchecks any ideas on how to solve it? — ekawas, Jan 05 '11 at 15:23

score 0 · Answer 1 · answered Jan 06 '11 at 06:26

 boolean[] itemChecked =  new boolean[100];     

public View getView(int pos, View inView, ViewGroup parent) {



System.out.println("  ImageCursorAdapter : getView : ");
View v = inView;
    // Associate the xml file for each row with the view
if (v == null) {
    LayoutInflater inflater = (LayoutInflater) context
        .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
    v = inflater.inflate(R.layout.main, null);
}
this.c.moveToPosition(pos);

    final CheckBox checkBox = (CheckBox) v.findViewById(R.id.bcheck);


checkBox.setTag(pos);

checkBox.setOnClickListener(new OnClickListener() {

    @Override
    public void onClick(View arg0) {



    String position = (String) checkBox.getTag();

    if (checkBox.isChecked() == true) {

        itemChecked[Integer.valueOf(position)] = checkBox.isChecked();  

    } else {

        itemChecked[Integer.valueOf(position)] = checkBox.isChecked();  

    }



    }

});

checkBox.setChecked(itemChecked[pos]); 

return (v);

}

score 0 · Accepted Answer · answered Jan 09 '11 at 04:36

0

So I managed to fix it by calling cursor.requery() when my checkbox listener was called. Not sure if this is a good method, but it works.

answered Jan 09 '11 at 04:36

ekawas

6,594
3
27
39

score -1 · Answer 3 · edited Dec 05 '11 at 07:56

decalare a boolean array globally and save the chek box state in it

public class CheckBoxAdapter extends SimpleCursorAdapter {

    private Cursor c;
    private Context context;


  private boolean[] itemChecked =  new boolean[100]; 


 public CheckBoxAdapter (Context context, int layout, Cursor c,
        String[] from, int[] to) 
{
    super(context, layout, c, from, to);

    this.c = c;
    this.context = context;
    }



  public View getView(int pos, View inView, ViewGroup parent) {

    View v = inView;

   final CheckBox checkBox = (CheckBox) v.findViewById(R.id.bcheck);

   checkBox.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {
if (checkBox.isChecked() == true) {
 itemChecked[Integer.valueOf(position)] = checkBox.isChecked();  
}
else{
 itemChecked[Integer.valueOf(position)] = checkBox.isChecked();  

}
}
});

    checkBox.setChecked(itemChecked[pos]); 

}//end of getView method



}//end of class CheckBoxAdapter

That didnt work for me. I used your code, fixed a few syntax errors but it didnt work for me. — ekawas, Jan 05 '11 at 14:52
you have to set the postion of check box in checkbox.setTag(). I will add another code .. try with that — jennifer, Jan 06 '11 at 06:21

ListView from cursor with checkbox

3 Answers3

Linked