Java Swing Icon not appearing

Question

I'm trying to create a piece of code that displays either a smiley face or a sad face when a button is pressed, depending on some value, but it just won't display the image. I know that it's definitely getting past the if/else statements, so I really don't know what is going wrong.

 try {
    if(data[2] <= ((int) ChronoUnit.DAYS.between(localDate, RTS()))*MnHrs())
    {
        JLabel lblSmiley = new JLabel(new ImageIcon("C:\\. . .\\smileyface.jpeg"));
        panel.add(lblSmiley);
    }
    else
    {
        JLabel lblSmiley = new JLabel(new ImageIcon("C:\\ . . . \\sadeface.png));
        panel.add(lblSmiley);
    }
} catch (Exception e1) {
    e1.printStackTrace();
}

I tried using "panel.repaint()" and "panel.revalidate()" but it didn't work — R.McGuigan, Sep 01 '17 at 09:15
@Antoniossss Great suggestion re posting an MCVE, and a tip. `[mcve]` in a comment will auto-expand to [mcve]. OP: One way to get image(s) for an example is to hot link to images seen in [this Q&A](http://stackoverflow.com/q/19209650/418556). — Andrew Thompson, Sep 01 '17 at 10:04
I tried both combinations of "panel.repaint()" and "panel.revalidate()" within the if/else statements and it produced no changes. — R.McGuigan, Sep 01 '17 at 10:06
@AndrewThompson to be honest, sometimes it expands for me, sometimes id dont (after just pasting link) — Antoniossss, Sep 01 '17 at 10:07
@Antoniossss *"sometimes it expands for me, sometimes id don't"* There must be differences in how it is posted (e.g. no space before /after the 6 letters). I've posted it ..I was about to say hundreds, but it'd easily be thousands of times now, and it has worked every single time. — Andrew Thompson, Sep 01 '17 at 10:10
@R.McGuigan: Can't you just at the label once and use `setIcon()`? — Catalina Island, Sep 01 '17 at 10:10
@CatalinaIsland I swear I did that before, but now it seems to be working, thanks! — R.McGuigan, Sep 01 '17 at 10:33
@R.McGuigan: You can [answer your own question](http://meta.stackoverflow.com/q/17463/163188). — trashgod, Sep 01 '17 at 11:11

score 1 · Answer 1 · answered Sep 02 '17 at 10:30

It looks like you're loading the icon and adding a new label each time. Instead, you can add the label once and call setIcon() like they show here.

Icon smile = new ImageIcon("C:\\…\\smileyface.jpeg");
Icon sad = new ImageIcon("C:\\…\\sadeface.png");
JLabel lblSmiley = new JLabel();
…
frame.add(lblSmiley);
…
if (…) {
    lblSmiley.setIcon(smile);
} else {
    lblSmiley.setIcon(sad);
}

Depending on your layout, you may need to change the labels preferred size or add an empty label before you pack() the window.

score 0 · Answer 2 · answered Sep 01 '17 at 09:22

0

Probably, it is getting in the panel, but due to dimensions of panel it might be getting placed off screen. Check by modifying the panel dimensions and placing the smiley within that.

answered Sep 01 '17 at 09:22

NKumar

546
5
14

1

*"modifying the panel dimensions"* The correct way to do that is to `pack()` the top level container. The programmer should not be trying to guess the size needed (for a cross-platform GUI that is designed using layouts). – Andrew Thompson Sep 01 '17 at 10:07

Java Swing Icon not appearing

2 Answers2