foreach() with Laravel query

Question

I have one question, maybe it's really stupid, sorry. For example, I have "Users" table and I need to perform some action with each user (not with all users so I can't use bulk update. Just imagine this situation).

Is there any difference between:

$users = Users::all();
foreach ($users as $user) {
    //some action
}

and

foreach (Users::all() as $user) {
        //some action
}

Appreciate any explanation.

Nothing different but it's better to use first method in above code — Sagar Gautam, Sep 01 '17 at 09:45
Possible duplicate of [How does PHP 'foreach' actually work?](https://stackoverflow.com/questions/10057671/how-does-php-foreach-actually-work) — Neodan, Sep 01 '17 at 09:47
@Scuzzy It depends on the context. If you might need again Users::all() then you better off assign it to a variable instead of making another query to the database. — GiamPy, Sep 01 '17 at 10:02
@Ross Wilson I need to check Stripe subscription status of each user and send the order if I have new success payment. So I really need to loop all users. — Andrey P., Sep 01 '17 at 10:09

score 1 · Accepted Answer · answered Sep 01 '17 at 11:08

1

It really depends on your situation. Personally I find readability the key. Using 'one use' variables is mostly more readable.

answered Sep 01 '17 at 11:08

jjj

187
1
9

foreach() with Laravel query

1 Answers1