switching activities with textview

Question

am trying to make the text under my login button "no account yet? signup now" when clicked to send me to my RegisterFragment.so i added an OnClickListener for it like this in my LoginFragment.

  @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {

    TextView signup = (TextView) getView().findViewById(R.id.signup);
    signup.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            LoginFragment.this.startActivity(new Intent(getActivity(), RegisterFragment.class));

        }
    });

but when i run the code the app crashes on this line

        TextView signup = (TextView) getView().findViewById(R.id.signup);

this is my fragment_login.xml file

<TextView android:id="@+id/signup"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:layout_marginBottom="24dp"
    android:text="No Account Yet? Signup_now"
    android:gravity="center"
    android:textSize="16dp"
    android:clickable="true"/>

please guys i really need your help.

Inflate you xml file where you have declared the textview before initialising the textview — Ezio, Sep 03 '17 at 04:54

Sandip Fichadiya · Answer 1 · 2017-09-03T05:28:41.557

2

onCreateView() method is responsible for creating view, so you should first create it. You can't directly use getView() inside onCreateView().

You need to inflate it first like

View view = inflater.inflate(R.layout.my_layout, container, false);

Then use

TextView signup = (TextView) view.findViewById(R.id.signup);

So full code should look like this

@Override
            public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {

                View view = inflater.inflate(R.layout.my_layout, container, false);
                TextView signup = (TextView) view.findViewById(R.id.signup);
                signup.setOnClickListener(new View.OnClickListener() {
                    @Override
                    public void onClick(View v) {


                    }
                });

    return view;
}

On side note, setting up click listener initializing TextView's etc should be done inside onViewCreated(). onCreateView() should just create & return the view.

like

@Override
    public void onViewCreated(View view, @Nullable Bundle savedInstanceState) {
TextView signup = (TextView) view.findViewById(R.id.signup);
// and so on...
}

edited Sep 03 '17 at 05:28

answered Sep 03 '17 at 04:30

Sandip Fichadiya

3,430
2
21
47

Theres nothing wrong with using onCreateView to set listeners – OneCricketeer Sep 03 '17 at 04:39
@cricket_007 yes, there's nothing wrong in it, but doing it in proper way won't harm even. Please see this answer: https://stackoverflow.com/a/31861425/1852343 – Sandip Fichadiya Sep 03 '17 at 04:43
thanks alot it worked but when i click on the link it shows unfortunately app has stoped.logcat points to this line " startActivity(new Intent(getActivity(), RegisterFragment.class));" – Eric Sep 03 '17 at 04:45
Is your RegisterFragment class a Fragment or Activity? – Sandip Fichadiya Sep 03 '17 at 04:47
@Eric Read the logcat for `Caused by`. "Unforuntely app has stopped" is not any reasonable error message. – OneCricketeer Sep 03 '17 at 04:48
@sam_0829 Hmm. Didn't know about the null check. Is the page blank when the View is null? – OneCricketeer Sep 03 '17 at 04:49
@Eric You can't `start` an **Activity** for a Fragment class. – OneCricketeer Sep 03 '17 at 04:50
@cricket_007 what do you suggest i do? – Eric Sep 03 '17 at 04:53
1

@Eric as cricket_007 said, you can't start a Fragment like this. This is separate question so accept this answer if it has helped & try to find How to replace fragment. This might help you. https://stackoverflow.com/a/39825000/1852343 If you struggle in this, then please post separate question – Sandip Fichadiya Sep 03 '17 at 04:55
1

@sam_0829 Might want to edit the answer to remove `startActivity`, then – OneCricketeer Sep 03 '17 at 05:01
please how can i start a fragment? i appreciate you guys help so far you guys are great – Eric Sep 03 '17 at 05:18
@Eric it seems you are still having problem with this one. Is it so? – Sandip Fichadiya Sep 05 '17 at 06:02
@sam_0829 i have finally resolved it, thanks for your concern – Eric Sep 11 '17 at 19:57

OneCricketeer · Answer 2 · 2017-09-03T05:07:37.637

I would recommend not setting a click listener into something you want to type into
You can't call getView before onCreateView has actually returned a proper View

findViewById in Fragment

RegisterFragment.class is not an Activity, you cannot startActivity for it.

Use the FragmentManager

getSupportFragmentManager().beginTransaction()
    .replace(R.id.<someContainer>, RegisterFragment.class)
    .commit();

Or you can see the documentation on Communication between Fragments to see how you might implement on onLogin() or onRegistrationSelected() action to swap out to the registration fragment or "post-login" main fragment.

switching activities with textview

2 Answers2