pytest fixtures Redefining name from outer scope [pylint]

Question

I'm learning pytest and I lint my code with pylint. But pylint still complaints about:
W0621: Redefining name %r from outer scope (line %s)

for the following example from pytest:

# test_wallet.py

@pytest.fixture
def my_wallet():
    '''Returns a Wallet instance with a zero balance'''
    return Wallet()

@pytest.mark.parametrize("earned,spent,expected", [
    (30, 10, 20),
    (20, 2, 18),
])
def test_transactions(my_wallet, earned, spent, expected):
    my_wallet.add_cash(earned)
    my_wallet.spend_cash(spent)
    assert my_wallet.balance == expected

Redefining name my_wallet from outer scope.

I found workaround to add _ prefix to the fixture name: _my_wallet.

What would be the best practice if I want to keep fixtures in same file as functions?

Prepend all fixtures with _?
Disable this pylint check for tests?
Better suggestion?

score 160 · Answer 1 · edited Jun 21 '21 at 00:01

160

The pytest docs for @pytest.fixture say this:

If a fixture is used in the same module in which it is defined, the function name of the fixture will be shadowed by the function arg that requests the fixture; one way to resolve this is to name the decorated function fixture_<fixturename> and then use @pytest.fixture(name='<fixturename>').

So this solution is similar to your option 1, except that the pytest author suggests a slightly more descriptive name for the fixture function. So replace these two lines

@pytest.fixture
def my_wallet():

with:

@pytest.fixture(name="my_wallet")
def fixture_my_wallet():

The description in the docs also hints at another solution which is to move the fixtures into conftest.py so they are not in the same module as the test code using the fixtures. This location is also useful for sharing fixtures among test modules.

edited Jun 21 '21 at 00:01

aruku7230

843
8
20

answered Jul 13 '19 at 00:35

hallidave

9,579
6
31
27

13

This should be the valid answer. – adem.sh Sep 16 '20 at 07:52
1

Here's an updated link to the relevant [pytest docs](https://docs.pytest.org/en/documentation-restructure/how-to/builtin.html#fixtures-and-requests) – benwshul Apr 15 '21 at 16:19
1

This works. But you still get pylint errors if you are using mocker. For example: `from pytest_mock import mocker` followed by `def test_my_thing(mocker):` gives you a pylint error. I think this is why so many people voted for the other answer which suggests disabling this pylint rule for the WHOLE file. This is BAD imo. It seems to me that pylint stomps all over good linting rules. – Lqueryvg Sep 30 '21 at 15:32
funny thing, now I get "unused argument 'name'" – dVeza Aug 09 '23 at 11:38

score 45 · Accepted Answer · answered Jan 04 '19 at 20:39

45

I just disabled that rule in my test files:

# pylint: disable=redefined-outer-name
# ^^^ this
import pytest

@pytest.fixture
def my_wallet():
    '''Returns a Wallet instance with a zero balance'''
    return Wallet()

@pytest.mark.parametrize("earned,spent,expected", [
    (30, 10, 20),
    (20, 2, 18),
])
def test_transactions(my_wallet, earned, spent, expected):
    my_wallet.add_cash(earned)
    my_wallet.spend_cash(spent)
    assert my_wallet.balance == expected

answered Jan 04 '19 at 20:39

Garrett Bates

823
1
11
16

1

This is sad. The lint rule is there for a good reason. I blame pylint for this. – Lqueryvg Sep 30 '21 at 15:35
3

@Lqueryvg I am a Pylint contributor, I opened a bug issue regarding this False Positive message. https://github.com/PyCQA/pylint/issues/6531 – Or b May 06 '22 at 22:01

score 8 · Answer 3 · edited Dec 26 '20 at 13:20

Add name parameter for fixture and fixture_ prefix in def.

@pytest.fixture(name="my_wallet")
def fixture_wallet():
    '''Returns a Wallet instance with a zero balance.'''
    return Wallet()

@pytest.mark.parametrize("earned, spent, expected", [
    (30, 10, 20),
    (20, 2, 18),
])
def test_transactions(my_wallet, earned, spent, expected):
    my_wallet.add_cash(earned)
    my_wallet.spend_cash(spent)
    assert my_wallet.balance == expected

score 6 · Answer 4 · edited May 06 '20 at 14:02

6

It's usually disabled (1, 2).

There is a pylint-pytest plugin that tried to fix some problems, but the error W0621 is not fixed yet.

edited May 06 '20 at 14:02

Boris Verkhovskiy

14,854
11
100
103

answered Sep 08 '17 at 19:16

phd

82,685
13
120
165

3

Doesn't this plugin *error out during pytest on pylint warnings*, instead of suppressing pylint warnings in tests code? – sqd Aug 24 '18 at 16:21
11

yes, the pluging @insysion is linking to runs pylint as part pytest, and has nothing to do with fixing pylint error messages on common pytest fixture usage. – RasmusWL Nov 05 '18 at 12:59
this plugin doesn't seem to work properly when using the "enable" pytest configuration. Any flag that is "enabled" takes precedence over what pylint-pytest is trying to do. – Cody Django Aug 10 '21 at 22:54

pytest fixtures Redefining name from outer scope [pylint]

4 Answers4