Syntax error on php code

Question

PLease help me with this code

<?php
if (!empty($this->product->customfieldsSorted['youtube'])) {
    $this->position = 'youtube';
    echo '<button class="shop_tablinks tab2"  onclick='"openSpecs(event, 'Specs3')"' >';
    echo JText::_('Video'); 
    echo '</button>';
} // Product Custom ontop end
?>

It seems I don't wrote ok the

onclick='"openSpecs(event, 'Specs3')"' >'

Possible duplicate of [What is the difference between single-quoted and double-quoted strings in PHP?](https://stackoverflow.com/questions/3446216/what-is-the-difference-between-single-quoted-and-double-quoted-strings-in-php) — crazyloonybin, Sep 12 '17 at 08:17

Naincy · Answer 1 · 2017-09-12T08:35:46.900

5

Replace you code with below:

<?php  if (!empty($this->product->customfieldsSorted['youtube'])) {
        $this->position = 'youtube';
        echo '<button class="shop_tablinks tab2"  onclick="openSpecs(event, \'Specs3\')">';
        echo JText::_('Video'); 
       echo '</button>';
   } // Product Custom ontop end
    ?>

Need to use escape operator for '' if you want to use in html code while echoing as you are echoing with ''. So in HTml code its taking it as concat operator.

edited Sep 12 '17 at 08:35

answered Sep 12 '17 at 08:19

Naincy

2,953
1
12
21

It would probably improve your answer if you pointed out what you've changed and why. – Nigel Ren Sep 12 '17 at 08:31
@ValiRossi https://meta.stackexchange.com/questions/5234/how-does-accepting-an-answer-work – chris85 Sep 12 '17 at 09:00

score 2 · Answer 2 · answered Sep 12 '17 at 08:19

Change your line

echo '<button class="shop_tablinks tab2"  onclick='"openSpecs(event, 'Specs3')"' >';

to

echo '<button class="shop_tablinks tab2"  onclick="openSpecs(event, \'Specs3\')" >';

final code:

if (!empty($this->product->customfieldsSorted['youtube'])) {
    $this->position = 'youtube';
    echo '<button class="shop_tablinks tab2"  onclick="openSpecs(event, \'Specs3\')" >';
    echo JText::_('Video'); 
    echo '</button>';
}

Syntax error on php code

2 Answers2