Having trouble with a for loop in shell script

Asked Sep 20 '17 at 22:01

Active Sep 21 '17 at 00:32

Viewed 44 times

#!/bin/sh
echo "Please enter your name here $RESPONSE!"
read RESPONSE
echo "Hello $RESPONSE, I will now create a new ${RESPONSE}_file for you"
touch ${RESPONSE}_file
echo "Would you like to remove this file. If yes, please enter in all lower 
case"
read RESPONSE
if ["$RESPONSE" == "yes"];
then
rm ${RESPONSE}_file
fi

Hello,

I think I'm a little misguided in accomplishing my goal here. Each time I run this script I get an error message that states the "yes: command not found" error. I understand the shell is not reading this as a string. Should I create another variable that stores the result? I really have no idea at the moment how to make this work. Your input is much appreciated.

asked Sep 20 '17 at 22:01

Justin Henderson

There's no `for` loop in your code. What does the title have to do with the text? – Charles Duffy Sep 20 '17 at 22:04
btw, `==` isn't guaranteed to work as an argument to `test` (the command also known as `[`) with `/bin/sh`. Use `=` instead -- and see the relevant specification at http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html – Charles Duffy Sep 20 '17 at 22:04
Change `if [ "$RESPONSE" == "yes" ];` Note the space – Fredrik Pihl Sep 20 '17 at 22:05
@FredrikPihl, that's still wrong; `==` isn't robust (doesn't work with dash or ash). – Charles Duffy Sep 20 '17 at 22:05
True, `=` is they way to go. On mobile, was a bit to fast – Fredrik Pihl Sep 20 '17 at 22:07
@JustinHenderson, ...btw, consider making a habit of running your code through http://shellcheck.net/ before asking questions here. – Charles Duffy Sep 20 '17 at 22:08
It's saying `[yes` is not found, not that `yes` is not found. That's a critical difference. – Charles Duffy Sep 21 '17 at 00:30
@JustinHenderson Did you get an answer? – LAS Sep 21 '17 at 00:56
My title was misleading, I apologize @CharlesDuffy. I did run it the code through shell check prior but I still did not achieve the desired result. – Justin Henderson Sep 21 '17 at 15:23

Having trouble with a for loop in shell script

0 Answers0