how to copy stuff from getenv()?

Asked Sep 21 '17 at 19:30

Active Sep 21 '17 at 19:41

Viewed 154 times

I'm trying to make a copy of path, here is what I have:

char *path = getenv("PATH");
char *path_copy;
path_copy = (char*)malloc(sizeof(path));
memcpy(path_copy, path, sizeof(path));

and now path is: /soft/linux/bin:/usr/local/bin:/usr/bin:/bin: (etc) but path_copy is: /soft/li

what am I doing wrong?

edited Sep 21 '17 at 19:41

dlmeetei

asked Sep 21 '17 at 19:30

HOHO

2

`sizeof(path)` is the size of pointer. Use `strcpy` and friends. In your case `strdup` is the ideal one (yet non-standard) – Eugene Sh. Sep 21 '17 at 19:30
if you must use malloc then malloc(strlen(path)+1). Also memcpy the same, with the +1, for the terminating NULL – PhilC Sep 21 '17 at 19:36
Or use `snprintf` or even better `asprintf` – Basile Starynkevitch Sep 21 '17 at 19:36
As soon as I can find what I'm sure is one of *many* duplicates I'm deleting that answer =P – WhozCraig Sep 21 '17 at 19:38
https://stackoverflow.com/questions/9937181/sizeof-vs-strlen, https://stackoverflow.com/questions/3695263/how-to-allocate-the-array-before-calling-strcpy, https://stackoverflow.com/questions/1533519/newbie-questions-about-malloc-and-sizeof – Ilja Everilä Sep 21 '17 at 19:38
Thanks, @IljaEverilä. The last one looks like a winner – WhozCraig Sep 21 '17 at 19:42

0 Answers0