Warning: Attempting to access 'myProperty' within its own getter vs SwiftFormat

Question

I have code like this:

@IBInspectable var myProperty: String? {
    set(newValue) {
        //logic for setter
    }
    get {
        return myProperty
    }
}

The above code generates a warning:

Attempting to access 'myProperty' within its own getter. Access 'self' explicitly to silence this warning.

So I fix the code as suggested:

@IBInspectable var myProperty: String? {
    set(newValue) {
        //logic for setter
    }
    get {
        return self.myProperty
    }
}

The problem would be solved but I am using SwiftFormat during the application build phase. And SwiftFormat automatically removes the self keyword, treating it as unnecessary here.

I see two solutions:

Turn off the redundantSelf rule in SwiftFormat.
Modify (how?) the code to be acceptable for both the compiler and the SwiftFormat.

What would be the best choice for this?

Your getter recursively calls itself, so that is wrong anyway (leading to a stack overflow quickly) – with or without warning. Compare https://stackoverflow.com/q/24025340/1187415. — Martin R, Sep 23 '17 at 13:45

score 6 · Accepted Answer · answered Sep 23 '17 at 14:25

6

Your code is incorrect in the first place. Adding self will not help.

What you have created is infinite recursion. When myProperty's getter is called, you return myProperty, which calls the getter again. in the getter you return myProperty again and this calls the getter again. This will go on forever until the stack overflows.

If you just want a custom setter, you can try willSet or didSet.

var myProperty: String {
    willSet(newValue) {
        // do stuff
    }
}

// or

var myProperty: String {
    didSet(oldValue) {
        // do stuff
    }
}

answered Sep 23 '17 at 14:25

Sweeper

213,210
22
193
313

1

What if need a custom getter? – Britto Thomas Mar 07 '18 at 09:41
@BrittoThomas then write a custom getter. – Sweeper Mar 07 '18 at 10:50
can please write syntax for that – Britto Thomas Mar 07 '18 at 10:54
https://stackoverflow.com/questions/49148782/how-to-create-a-custom-getter-method-in-swift-4 – Britto Thomas Mar 07 '18 at 10:58
Can you please check the above question? – Britto Thomas Mar 07 '18 at 10:59
@BrittoThomas, [this](https://stackoverflow.com/a/25829062/3833666) might be cleaner. – ScottyBlades Jun 13 '18 at 03:41

score 1 · Answer 2 · answered Oct 19 '21 at 23:15

I hit this same warning when attempting to write an Objective-C style property with a backing ivar:

var myProperty: String {
    guard let myProperty = _myProperty else {
        _myProperty = "some string"
        return myProperty // Attempting to access 'myProperty' within its own getter
    }
    return myProperty
}
var _myProperty: String? = nil

Expanding the error message in Xcode, however, shows that the warning has a hint on the second line:

// Attempting to access 'myProperty' within its own getter
// Access 'self' explicitly to silence this warning

Changing to return self.myProperty thus silences the warning in cases where the calls will not cause infinite recursion.

Warning: Attempting to access 'myProperty' within its own getter vs SwiftFormat

2 Answers2