Display the largest Number , Getting Error on If line

Question

so Sorry admin If the Code is posted in wrong way, I can't understand how to post the code. Its a Code in Codeblocks,

So yup my problem is I have to Take three integers from User and The Code will see which one is the largest and will display it on screen. So in my Code everything is fine but when ever i try to run it is is giving error on if line saying error expected '{' before token and some other error like that I even put {} these but still error . So Anyone help me out :)

int Number1 , Number2 , Number3;
cout<<"Enter First Number"<<endl;
cin>>Number1;
cout<<"Enter Second Number"<<endl;
cin>>Number2;
cout<<"Enter Third Number"<<endl;
cin>>Number3;

if ("Number1 > Number2") && ("Number1 > Number3")
    cout<<"Number1 is the Largest Number"<<endl;
if {(Number2>Number1) && (Number2>Number3)}:
    cout<<"Number2 is the largest Number"<<endl;
else
    cout<<"Number3 is the Largest Number"<<endl;
return 0;

I highly recommend that you get a [good book](https://stackoverflow.com/questions/388242/the-definitive-c-book-guide-and-list), because you seem to guess the syntax. — Rakete1111, Sep 23 '17 at 14:25
@Rakete1111 Yup I can Guess Syntax error But New in Code blocks , And Yup i am also Learning Python So python is more easy then C++ But my Subject is C++ :) So Yup new some help. — AHMED ALI, Sep 23 '17 at 14:44
I'm just saying that you'll need to get a book to learn C++, there are very few good C++ online tutorials. The link is just a link to list of books that have proved to be good books for learning C++. — Rakete1111, Sep 23 '17 at 14:46
Colons are not used like this in C++. Also, your syntax is not even consistent — Post Self, Sep 23 '17 at 14:47
i am tested that if line with ; and without ; and with even {} "" but still nothing — AHMED ALI, Sep 23 '17 at 14:49

Post Self · Accepted Answer · 2017-09-23T17:21:33.873

0

If statements in C++ are written like this:

if (Number1 > Number2 && Number1 > Number3)
    cout << "Number1 is the Largest Number" << endl;
if (Number2 > Number1 && Number2 > Number3)
    cout << "Number2 is the largest Number" << endl;
else
    cout << "Number3 is the Largest Number" << endl;

No colons, no curly braces in the condition, no quotation marks, and only one pair of parentheses.

edited Sep 23 '17 at 17:21

answered Sep 23 '17 at 14:48

Post Self

1,471
2
14
34

thanks bro .. oh that Mistake i was watching that parenthese :) but was thinking that it is good in two other parentheses.. – AHMED ALI Sep 23 '17 at 14:51
@AHMEDALI Click the tick mark on the left to mark this as the solution, if it helped – Post Self Sep 23 '17 at 14:52
why my points are getting in negative?? i was having 9 points now only 1 point/ – AHMED ALI Sep 23 '17 at 14:57
Also, no double quotes when comparing numerical variables. – Thomas Matthews Sep 23 '17 at 17:10
1

A good coding style is to group the compares with parenthesis, e.g. `if ((Number1 > Number2) && (Number1 > Number3))`. – Thomas Matthews Sep 23 '17 at 17:13
@ThomasMatthews Thanks for the edit. Overlooked that one. – Post Self Sep 23 '17 at 17:21

Display the largest Number , Getting Error on If line

1 Answers1