Generic Vararg Safety

Asked Sep 24 '17 at 20:42

Active Sep 24 '17 at 21:28

Viewed 36 times

I have a function. I like my function. It makes lists and it makes me happy. My IDE gives me a warning about my function though, talking about potential heap pollution. I can add an annotation to suppress this warning, but I want to make sure I'm not suppressing a legitimate concern. Can anyone confirm whether the function below is safe/unsafe?

public static <T> List<T> listIt(T... t) {
    List<T> lzt = new ArrayList<T>();
    for (T i: t)
        lzt.add(i);
    return lzt;
}

edited Sep 24 '17 at 21:28

shmosel

49,289
6
73
138

asked Sep 24 '17 at 20:42

Carl Shiles

3

Perhaps instead of describing the diagnostic message, you could actually present the message itself? – John Bollinger Sep 24 '17 at 20:44
1

BTW, `return new ArrayList(Arrays.asList(t));` is a bit more pithy, and potentially a bit more performant, although it doesn't avoid the issue you ask about. – John Bollinger Sep 24 '17 at 20:48
Arrays.asList returns a list that isn't modifiable! That's the only problem there.. – Carl Shiles Sep 25 '17 at 01:05

Generic Vararg Safety

0 Answers0