Validation messages aren't showed on the view in Laravel

Question

I have ItemController.php and ItemRequest.php.. ItemController.php is responsible for adding items and ItemRequest.php for form validation.

In ItemRequest.php I have this rules

class ItemRequest extends Request
{
    public function authorize()
    {
        return true;
    }
    public function rules()
    {
        return [
            'title' => 'required',
            'category_id' => 'required',
        ];
    }

    public function messages()
    {
        return [
            'title.required' => 'The :attribute field is required.',
            'category_id.requred' => 'The :attribute field is required.',
        ];
    }
}

In my view I have this

@if($errors->has())
    <div class="alert alert-danger alert-dismissible">
        <button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>
        <h4><i class="icon fa fa-ban"></i> Alert!</h4>
        @foreach ($errors->all() as $error)
               {{ $error }}</br>
        @endforeach
    </div>
@endif

The problem is that the form doesn't get any validation. I'm able to click Submit with empty fields and they are inserted in DB.

and this is the store function from ItemController.php

public function store( ItemRequest $request )
{      
    $item = new Item;
    $item->title = $request['title'];
    if( empty( $request['alias']) ) {
      $request['alias'] = $request['title'];
    }
    $item->category_id = $request['category_id'];
    $item->save();
    return redirect()->route('admin.items');
}

Why I don't get any messages or validation on the page?

Answer 1

$request is an object, not an array. Your code should look like this

$item = new Item;
$item->title = $request->get('title');
if( $request->has('alias') ) {
    // ??? 
    $request['alias'] = $request['title'];
}
$item->category_id = $request->get('category_id');
$item->save();
return redirect()->route('admin.items');

You can also use $request->has('name') to check if a field has been submitted. But i am not sure what are you trying to do in the if statement.

Answer 2

You need to define a validator function in ItemController that validates ItemRequest using the rules you so defined.

protected function validator($data)
{
    return Validator::make($data, app(ItemRequest::class)->rules());
}

The Illuminate\Http\Foundation\FormRequest handles a failedValidation redirecting back to the previous URL with the errorBag available in the session for the view.

This isn't something Illuminate\Http\Request handles for you.

In ItemController write a validate method, and use this as a precondition in store before doing work.

function validate(Request $request) {
    $validator = $this->validator($request->all());
    if ($validator->fails()) {
        $this->throwValidationException(
            $request, $validator
        );
    }
}

function store(ItemRequest $request) {
    $this->validate($request);
    ...
}