Activity Object List gets modified from dialog Object List

Question

I have an activity from which I created a dialog passing a list of objects. In the dialog, I have modified the global object list data.

Problem is my activity object list is also modified from the dialog data manipulation. I didn't use any listener or method to do caller class data. AFAIK these are a separate object and doesn't have the same reference, So it shouldn't have changed.

Activity caller section:

ProductQuantityReviewDialog dialog = new ProductQuantityReviewDialog(context, salesOrderList);
dialog.show();

Dialog class :

private HashMap<Integer, OrderSalesModel> salesOrderList;

public ProductQuantityReviewDialog(@NonNull Context context, HashMap<Integer, OrderSalesModel> salesOrderList) {
        super(context);
        this.context = context;
        this.salesOrderList = salesOrderList;
    }

Update: Tried in this way but same problem.

    public ProductQuantityReviewDialog(@NonNull Context context, HashMap<Integer, OrderSalesModel> salesOrderList) {
        super(context);
        this.context = context;
        orderList = new HashMap<>(salesOrderList);
       // orderList.putAll(salesOrderList);
}

Sharath kumar · Answer 1 · 2017-10-03T12:39:12.560

1

Passing reference inside constructor makes dialog hash map refer to same address as the activity hash map.Instead of passing reference you should maintain a separate list inside dialog.

private Map<Integer, OrderSalesModel> mSalesOrderList;

public RetrieveInput(@NonNull Context context, HashMap<Integer, OrderSalesModel> salesOrderList) {
    super(context);
    this.context = context;
    copyDataToMap(salesOrderList);
}

private void copyDataToMap(HashMap<Integer, OrderSalesModel> salesOrderList) {
    mSalesOrderList = new HashMap<>();
    for (Map.Entry<Integer, OrderSalesModel> entry : salesOrderList.entrySet())
    {
        mSalesOrderList.put(entry.getKey(), entry.getValue());
    }
}

edited Oct 03 '17 at 12:39

answered Oct 03 '17 at 11:12

Sharath kumar

4,064
1
14
20

`orderList = new HashMap<>(); orderList.putAll(salesOrderList);` changed to this but doesn't work. Same problem – Sadiq Md Asif Oct 03 '17 at 11:52
Try this updated code.This should work..your getting same problem? – Sharath kumar Oct 03 '17 at 11:57
tried. same thing! list value updated in the previous activity. – Sadiq Md Asif Oct 03 '17 at 11:59
Try this final edited code..This will work..let me know if it is not working – Sharath kumar Oct 03 '17 at 12:24
same problem! is this the reason of this? https://stackoverflow.com/a/17659412/7267105 – Sadiq Md Asif Oct 03 '17 at 12:34
But these are two different hashmaps right.Here I am creating a different haspmap and adding data – Sharath kumar Oct 03 '17 at 12:35
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/155826/discussion-between-sadiq-md-asif-and-anonymous). – Sadiq Md Asif Oct 03 '17 at 12:36

score 0 · Answer 2 · answered Oct 03 '17 at 11:15

0

In your code . you are passing reference of the hashmap . so another hashmap is also alter .

Initialize new hashmap in you dialog and set all the value to it .

answered Oct 03 '17 at 11:15

Tejas Pandya

3,987
1
26
51

tried both! still getting the same problem. see updated section – Sadiq Md Asif Oct 03 '17 at 12:14

Activity Object List gets modified from dialog Object List

2 Answers2