getting IndexOutOfBounds from charAt()

Question

I am supposed to create a program where a number is inputted, and then using a loop figure out how many number 3's there are in the number. I decided to convert my int to String, and then use charAt() since it would make life a little bit easier. When I try to run the program it doesn't even try to start the scanner and instantly gives me an IndexOutofBounds error.

import java.util.*;

public class countInt {
    static int N;
    static int c;

    public countInt() {
        Scanner kn = new Scanner(System.in);
        System.out.println("Please type in a number between 10 - 1000");
        N = kn.nextInt();
    }

    public static void main(String[] args) {
        String New = Integer.toString(N);
        int NewLength = New.length();

        for (int i=0; i <= NewLength; i++){
            if (New.charAt(i) == '3'){
                c++;
            }
        }

        System.out.println("The number contains " + c + "number 3's");
    }
}

I'm a beginner programmer, so maybe there is something stupid that I missed.

Replace `for (int i=0; i <= NewLength; i++)` with `for (int i=0; i < NewLength; i++)` — Juan Carlos Mendoza, Oct 05 '17 at 20:10
@JuanCarlosMendoza changed it, still getting IndexOutOfBoundsError: 1 — sophierrr, Oct 05 '17 at 20:14
Another problem is that you never call `countInt()` so your N will hold its default value `0`. — Pshemo, Oct 05 '17 at 20:19
call countInt() in the first line of the main method, and the Newlenght should be only lesser instead of equal lesser — Marcos Vasconcelos, Oct 05 '17 at 20:22
Also, the class name should be CountInt, while the variables are n, newString( cause new is reserved), newLenght, this is not a problem but is a convention — Marcos Vasconcelos, Oct 05 '17 at 20:23
`countInt()` is a constructor. You don't call it. You have to create an object. Like this: https://ideone.com/qL70px — 001, Oct 05 '17 at 20:28

getting IndexOutOfBounds from charAt()

0 Answers0